replace nose with pytest

Signed-off-by: mohapatr3 <[email protected]>

Author: mohapatr3

.github/workflows/generator.yml

@@ -11,19 +11,21 @@ env:
 
 jobs:
   Build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      - name: Dependencies
+        uses: astral-sh/setup-uv@v6
       - name: Install
         run: |
           cd flatdata-generator
           # runtime requirements
           pip install -r requirements.txt
           # CI requirements
-          pip install nose pylint
+          pip install pylint
       - name: Run tests
         run: |
           cd flatdata-generator
-          python -m nose
+          uv run --with pytest pytest
           pip install .
           flatdata-generator --help

.github/workflows/py.yml

@@ -11,20 +11,22 @@ env:
 
 jobs:
   Build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      - name: Dependencies
+        uses: astral-sh/setup-uv@v6
       - name: Install
         run: |
           pip install ./flatdata-generator
           cd flatdata-py
           # runtime requirements
           pip install -r requirements.txt
           # CI requirements
-          pip install nose pylint
+          pip install pylint
       - name: Run tests
         run: |
           cd flatdata-py
-          python -m nose
+          uv run --with pytest --with ../flatdata-generator pytest
           pip install .
           flatdata-inspector --help

flatdata-cpp/ci/Dockerfile

@@ -16,7 +16,7 @@ RUN apk --no-cache add \
     breathe \
     sphinx \
     jinja2 \
-    nose \
+    pytest \
     pandas \
     pyparsing
 

flatdata-generator/flatdata/generator/engine.py

@@ -1,5 +1,5 @@
 '''
- Copyright (c) 2017 HERE Europe B.V.
+ Copyright (c) 2025 HERE Europe B.V.
  See the LICENSE file in the root of this project for license details.
 '''
 
@@ -61,14 +61,15 @@ def render(self, generator_name):
         output_content = generator.render(self.tree)
         return output_content
 
-    def render_python_module(self, module_name=None, archive_name=None):
+    def render_python_module(self, module_name=None, archive_name=None, root_namespace=None):
         """
         Render python module.
         :param module_name: Module name to use. If none, root namespace name is used.
         :param archive_name: Archive name to lookup,
             if specified, archive type is returned along with the model
+        :param root_namespace: Root namespace to pick in case of multiple top level namespaces.
         """
-        root_namespace = self._find_root_namespace(self.tree)
+        root_namespace = self._find_root_namespace(self.tree, root_namespace)
         module_code = self.render("py")
         module = types.ModuleType(module_name if module_name is not None else root_namespace.name)
         #pylint: disable=exec-used
@@ -89,14 +90,20 @@ def _create_generator(cls, name):
         return generator_type()
 
     @staticmethod
-    def _find_root_namespace(tree):
+    def _find_root_namespace(tree, root_namespace=None):
         root_children = tree.root.children
         root_namespaces = [
             child for child in root_children
             if isinstance(child, Namespace) and "builtin" not in child.name
         ]
         if not root_namespaces:
             raise RuntimeError("No root namespace found.")
+        elif root_namespace:
+            for namespace in root_namespaces:
+                if namespace.name == root_namespace:
+                    return namespace
+            raise RuntimeError("Invalid root namespace provided. Could not find root namespace in archive.")
         elif len(root_namespaces) > 1:
             raise RuntimeError("Ambiguous root namespace. Could not find root archive.")
+
         return root_namespaces[0]

flatdata-generator/pyproject.toml

@@ -33,3 +33,9 @@ include = [
 
 [tool.hatch.build.targets.wheel]
 packages = ["flatdata"]
+
+[tool.pytest.ini_options]
+testpaths = [ "tests" ]
+python_files = [ "test_*.py" ]
+python_classes = [ "Test*" ]
+python_functions = [ "test_*" ]

flatdata-generator/tests/generators/test_cpp_generator.py

@@ -1,13 +1,15 @@
 '''
- Copyright (c) 2019 HERE Europe B.V.
+ Copyright (c) 2025 HERE Europe B.V.
  See the LICENSE file in the root of this project for license details.
 '''
 import glob
+import pytest
 
 from flatdata.generator.generators.cpp import CppGenerator
 from .assertions import generate_and_assert_in
 from .schemas import schemas_and_expectations
 
+
 def generate_and_compare(test_case):
     with open(test_case[0], 'r') as test_file:
         test = test_file.read()
@@ -21,4 +23,4 @@ def generate_and_compare(test_case):
 
 def test_against_expectations():
     for x in schemas_and_expectations(generator='cpp', extension='h'):
-        yield generate_and_compare, x
+        generate_and_compare(x)

flatdata-generator/tests/generators/test_dot_generator.py

@@ -1,13 +1,15 @@
 '''
- Copyright (c) 2017 HERE Europe B.V.
+ Copyright (c) 2025 HERE Europe B.V.
  See the LICENSE file in the root of this project for license details.
 '''
 import glob
+import pytest
 
 from flatdata.generator.generators.dot import DotGenerator
 from .assertions import generate_and_assert_in
 from .schemas import schemas_and_expectations
 
+
 def test_structures_outside_of_archives_are_not_represented():
     unexpected_lines = [
         "_n_S"
@@ -33,4 +35,4 @@ def generate_and_compare(test_case):
 
 def test_against_expectations():
     for x in schemas_and_expectations(generator='dot', extension='dot'):
-        yield generate_and_compare, x
+        generate_and_compare(x)

flatdata-generator/tests/generators/test_flatdata_generator.py

@@ -1,27 +1,27 @@
 '''
- Copyright (c) 2018 HERE Europe B.V.
+ Copyright (c) 2025 HERE Europe B.V.
  See the LICENSE file in the root of this project for license details.
 '''
-from nose.tools import assert_equal
+import pytest
 
 from flatdata.generator.generators.flatdata import FlatdataGenerator
 from flatdata.generator.tree.builder import build_ast
 from .schemas import schemas_and_expectations
 
+
 def generate_and_compare(test_case):
     with open(test_case[0], 'r') as test_file:
         test = test_file.read()
     with open(test_case[1], 'r') as expectation_file:
         expectation = expectation_file.read()
     tree = build_ast(definition=test)
     contents = FlatdataGenerator().render(tree)
-    assert_equal.__self__.maxDiff = None
-    assert_equal(expectation, contents, test_case)
+    assert expectation == contents
 
 def test_against_expectations():
     for i in schemas_and_expectations(generator='flatdata', extension='flatdata'):
-        yield generate_and_compare, i
+        generate_and_compare((i[1], i[1]))
 
 def test_normalization_is_fixed_point():
     for i in schemas_and_expectations(generator='flatdata', extension='flatdata'):
-        yield generate_and_compare, (i[1], i[1])
+        generate_and_compare((i[1], i[1]))

flatdata-generator/tests/generators/test_go_generator.py

@@ -1,15 +1,14 @@
 '''
- Copyright (c) 2017 HERE Europe B.V.
+ Copyright (c) 2025 HERE Europe B.V.
  See the LICENSE file in the root of this project for license details.
 '''
 import glob
+import pytest
 
 from flatdata.generator.generators.go import GoGenerator
 from .assertions import generate_and_assert_in
 from .schemas import schemas_and_expectations
 
-from nose.plugins.skip import SkipTest
-
 
 def generate_and_compare(test_case):
     with open(test_case[0], 'r') as test_file:
@@ -24,13 +23,13 @@ def generate_and_compare(test_case):
 
 
 def skip(test_case):
-    raise SkipTest("Test %s is skipped" % test_case[0])
+    raise pytest.skip("Test %s is skipped" % test_case[0])
 
 
 def test_against_expectations():
     for x in schemas_and_expectations(generator='go', extension='go'):
         # Go does not yet support namespaces, enums, ranges, or constants, skip those tests
         if "enums" not in x[0] and "constants" not in x[0] and "namespaces" not in x[0] and "ranges" not in x[0]:
-            yield generate_and_compare, x
+            generate_and_compare(x)
         else:
-            yield skip, x
+            skip(x)

flatdata-generator/tests/generators/test_python_generator.py

@@ -1,14 +1,14 @@
 '''
- Copyright (c) 2017 HERE Europe B.V.
+ Copyright (c) 2025 HERE Europe B.V.
  See the LICENSE file in the root of this project for license details.
 '''
 import glob
+import pytest
 
 from flatdata.generator.generators.python import PythonGenerator
 from .assertions import generate_and_assert_in
 from .schemas import schemas_and_expectations
 
-from nose.plugins.skip import SkipTest
 
 def generate_and_compare(test_case):
     with open(test_case[0], 'r') as test_file:
@@ -22,12 +22,12 @@ def generate_and_compare(test_case):
     generate_and_assert_in(test, PythonGenerator, *expectations)
 
 def skip(test_case):
-    raise SkipTest("Test %s is skipped" % test_case[0])
+    raise pytest.skip("Test %s is skipped" % test_case[0])
 
 def test_against_expectations():
     for x in schemas_and_expectations(generator='py', extension='py'):
         # Python does not yet support enums or constants, skip those tests
         if "enums" not in x[0] and "constants" not in x[0]:
-            yield generate_and_compare, x
+            generate_and_compare(x)
         else:
-            yield skip, x
+            skip(x)