Change default version for CatalogVersionRequest (#1298)

Update default version to exclude valid version from a default request.
Update condition as well to control allowed version to be stored as the
latest one

Relates-To: OAM-1387
Signed-off-by: Andrey Kashcheev <[email protected]>

Author: andrey-kashcheev

olp-cpp-sdk-dataservice-read/include/olp/dataservice/read/CatalogClient.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019-2021 HERE Europe B.V.
+ * Copyright (C) 2019-2022 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -151,7 +151,7 @@ class DATASERVICE_READ_API CatalogClient final {
    * @param request The `CatalogVersionRequest` instance that contains
    * a complete set of request parameters.
    *
-   * @return CancellableFuture` that contains the `CatalogVersionResponse`
+   * @return `CancellableFuture` that contains the `CatalogVersionResponse`
    * instance with the catalog configuration or an error. You can also
    * use `CancellableFuture` to cancel this request.
    */

olp-cpp-sdk-dataservice-read/include/olp/dataservice/read/CatalogVersionRequest.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019-2021 HERE Europe B.V.
+ * Copyright (C) 2019-2022 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -151,7 +151,7 @@ class DATASERVICE_READ_API CatalogVersionRequest final {
   }
 
  private:
-  int64_t start_version_{0};
+  int64_t start_version_{-1};
   boost::optional<std::string> billing_tag_;
   FetchOptions fetch_option_{OnlineIfNotFound};
 };

olp-cpp-sdk-dataservice-read/src/repositories/CatalogRepository.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019-2021 HERE Europe B.V.
+ * Copyright (C) 2019-2022 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -145,7 +145,7 @@ CatalogVersionResponse CatalogRepository::GetLatestVersion(
     constexpr auto kDefaultStartVersion = 0;
 
     auto user_set_version = request.GetStartVersion();
-    if (user_set_version != kDefaultStartVersion) {
+    if (user_set_version >= kDefaultStartVersion) {
       if (!cached_version || user_set_version > cached_version->GetVersion()) {
         model::VersionResponse new_response;
         new_response.SetVersion(user_set_version);