Fix cppcheck issues (#1028)

Rename method parameters to match declaration and definition
Remove unused variables

Resolves: OLPEDGE-1062

Signed-off-by: Serhii Lozynskyi <[email protected]>

Author: meravingen123

olp-cpp-sdk-core/src/cache/DefaultCacheImpl.cpp

@@ -565,7 +565,7 @@ int64_t DefaultCacheImpl::MaybeUpdatedProtectedKeys(
     } else if (prev_size > 0) {
       // delete key, as protected list is empty
       batch.Delete(kProtectedKeys);
-      return -1 * (prev_size + strlen(kProtectedKeys));
+      return -1 * static_cast<int64_t>((prev_size + strlen(kProtectedKeys)));
     }
   }
 

olp-cpp-sdk-core/src/cache/SizeCountingEnv.h

@@ -26,7 +26,7 @@ namespace cache {
 
 class SizeCountingEnv : public leveldb::EnvWrapper {
  public:
-  SizeCountingEnv(leveldb::Env* env) : leveldb::EnvWrapper(env) {}
+  explicit SizeCountingEnv(leveldb::Env* env) : leveldb::EnvWrapper(env) {}
 
   virtual uint64_t Size() const { return 0; }
 };

olp-cpp-sdk-core/src/client/PendingUrlRequests.cpp

@@ -174,7 +174,7 @@ bool PendingUrlRequests::CancelAll() {
   return true;
 }
 
-bool PendingUrlRequests::CancelAllAndWait() {
+bool PendingUrlRequests::CancelAllAndWait() const {
   PendingRequestsType pending_requests;
   PendingRequestsType cancelled_requests;
 

olp-cpp-sdk-core/src/client/PendingUrlRequests.h

@@ -123,7 +123,7 @@ class PendingUrlRequests {
   bool CancelAll();
 
   /// Cancel pending requests and wait for all requests to finish, blocking.
-  bool CancelAllAndWait();
+  bool CancelAllAndWait() const;
 
   /// Get the existing pending request associated with the url or create a new
   /// one if not present yet.

olp-cpp-sdk-dataservice-read/src/ReleaseDependencyResolver.cpp

@@ -126,12 +126,12 @@ ReleaseDependencyResolver::CheckProtectedTilesInQuad(
 
 void ReleaseDependencyResolver::ProcessQuadTreeCache(
     const geo::TileKey& root_quad_key, const geo::TileKey& tile,
-    bool& add_key) {
+    bool& add_data_handle_key) {
   QuadTreeIndex cached_tree;
   if (partitions_cache_repository_.Get(layer_id_, root_quad_key, kQuadTreeDepth,
                                        version_, cached_tree)) {
     TilesDataKeysType protected_keys =
-        CheckProtectedTilesInQuad(cached_tree, tile, add_key);
+        CheckProtectedTilesInQuad(cached_tree, tile, add_data_handle_key);
     if (protected_keys.empty()) {
       // no other tiles are protected, can add quad tree to release list
       keys_to_release_.emplace_back(partitions_cache_repository_.CreateQuadKey(

olp-cpp-sdk-dataservice-read/src/ReleaseDependencyResolver.h

@@ -57,7 +57,7 @@ class ReleaseDependencyResolver {
                                 const geo::TileKey& tile,
                                 bool& add_data_handle_key);
 
-  void ProcessQuadTreeCache(const geo::TileKey& root, const geo::TileKey& tile,
+  void ProcessQuadTreeCache(const geo::TileKey& root_quad_key, const geo::TileKey& tile,
                             bool& add_data_handle_key);
 
  private:

olp-cpp-sdk-dataservice-read/src/VersionedLayerClientImpl.h

@@ -98,7 +98,7 @@ class VersionedLayerClientImpl {
 
   virtual bool Protect(const TileKeys& tiles);
 
-  virtual bool Release(const TileKeys& keys);
+  virtual bool Release(const TileKeys& tiles);
 
  private:
   CatalogVersionResponse GetVersion(boost::optional<std::string> billing_tag,

olp-cpp-sdk-dataservice-read/src/repositories/DataRepository.cpp

@@ -123,9 +123,9 @@ BlobApi::DataResponse DataRepository::GetVersionedData(
 
 BlobApi::DataResponse DataRepository::GetBlobData(
     const std::string& layer, const std::string& service,
-    const DataRequest& data_request, client::CancellationContext context) {
-  auto fetch_option = data_request.GetFetchOption();
-  const auto& data_handle = data_request.GetDataHandle();
+    const DataRequest& request, client::CancellationContext context) {
+  auto fetch_option = request.GetFetchOption();
+  const auto& data_handle = request.GetDataHandle();
 
   if (!data_handle) {
     return {{client::ErrorCode::PreconditionFailed, "Data handle is missing"}};
@@ -170,11 +170,11 @@ BlobApi::DataResponse DataRepository::GetBlobData(
   if (service == kBlobService) {
     storage_response = BlobApi::GetBlob(
         storage_api_lookup.GetResult(), layer, data_handle.value(),
-        data_request.GetBillingTag(), boost::none, context);
+        request.GetBillingTag(), boost::none, context);
   } else {
     auto volatile_blob = VolatileBlobApi::GetVolatileBlob(
         storage_api_lookup.GetResult(), layer, data_handle.value(),
-        data_request.GetBillingTag(), context);
+        request.GetBillingTag(), context);
     storage_response = BlobApi::DataResponse(volatile_blob.MoveResult());
   }
 

olp-cpp-sdk-dataservice-read/src/repositories/DataRepository.h

@@ -45,7 +45,7 @@ class DataRepository final {
                                 client::CancellationContext context);
 
   BlobApi::DataResponse GetVersionedData(const std::string& layer_id,
-                                         const DataRequest& data_request,
+                                         const DataRequest& request,
                                          int64_t version,
                                          client::CancellationContext context);
 
@@ -55,7 +55,7 @@ class DataRepository final {
 
   BlobApi::DataResponse GetBlobData(const std::string& layer,
                                     const std::string& service,
-                                    const DataRequest& data_request,
+                                    const DataRequest& request,
                                     client::CancellationContext context);
 
  private:

olp-cpp-sdk-dataservice-read/src/repositories/PartitionsCacheRepository.h

@@ -65,7 +65,7 @@ class PartitionsCacheRepository final {
            const QuadTreeIndex& quad_tree,
            const boost::optional<int64_t>& version);
 
-  bool Get(const std::string& layer, geo::TileKey key, int32_t depth,
+  bool Get(const std::string& layer, geo::TileKey tile_key, int32_t depth,
            const boost::optional<int64_t>& version, QuadTreeIndex& tree);
 
   void Clear(const std::string& layer_id);