Fix rule of five violation. (#1436)

Added copy and move constructors and operators to classes with
virtual destructors. Changed some Impl classes to final.

Resolves: OLPEDGE-2838

Signed-off-by: Yevhen Krasilnyk <[email protected]>

Author: Smartkras

olp-cpp-sdk-dataservice-read/include/olp/dataservice/read/model/Catalog.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019-2021 HERE Europe B.V.
+ * Copyright (C) 2019-2023 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -36,6 +36,10 @@ namespace model {
 class DATASERVICE_READ_API Coverage {
  public:
   Coverage() = default;
+  Coverage(const Coverage&) = default;
+  Coverage(Coverage&&) = default;
+  Coverage& operator=(const Coverage&) = default;
+  Coverage& operator=(Coverage&&) = default;
   virtual ~Coverage() = default;
 
  private:
@@ -78,6 +82,10 @@ class DATASERVICE_READ_API Coverage {
 class DATASERVICE_READ_API IndexDefinition {
  public:
   IndexDefinition() = default;
+  IndexDefinition(const IndexDefinition&) = default;
+  IndexDefinition(IndexDefinition&&) = default;
+  IndexDefinition& operator=(const IndexDefinition&) = default;
+  IndexDefinition& operator=(IndexDefinition&&) = default;
   virtual ~IndexDefinition() = default;
 
  private:
@@ -183,6 +191,10 @@ class DATASERVICE_READ_API IndexDefinition {
 class DATASERVICE_READ_API IndexProperties {
  public:
   IndexProperties() = default;
+  IndexProperties(const IndexProperties&) = default;
+  IndexProperties(IndexProperties&&) = default;
+  IndexProperties& operator=(const IndexProperties&) = default;
+  IndexProperties& operator=(IndexProperties&&) = default;
   virtual ~IndexProperties() = default;
 
  private:
@@ -250,6 +262,10 @@ class DATASERVICE_READ_API IndexProperties {
 class DATASERVICE_READ_API Creator {
  public:
   Creator() = default;
+  Creator(const Creator&) = default;
+  Creator(Creator&&) = default;
+  Creator& operator=(const Creator&) = default;
+  Creator& operator=(Creator&&) = default;
   virtual ~Creator() = default;
 
  private:
@@ -289,6 +305,10 @@ class DATASERVICE_READ_API Creator {
 class DATASERVICE_READ_API Owner {
  public:
   Owner() = default;
+  Owner(const Owner&) = default;
+  Owner(Owner&&) = default;
+  Owner& operator=(const Owner&) = default;
+  Owner& operator=(Owner&&) = default;
   virtual ~Owner() = default;
 
  private:
@@ -346,6 +366,10 @@ class DATASERVICE_READ_API Owner {
 class DATASERVICE_READ_API Partitioning {
  public:
   Partitioning() = default;
+  Partitioning(const Partitioning&) = default;
+  Partitioning(Partitioning&&) = default;
+  Partitioning& operator=(const Partitioning&) = default;
+  Partitioning& operator=(Partitioning&&) = default;
   virtual ~Partitioning() = default;
 
  private:
@@ -425,6 +449,10 @@ class DATASERVICE_READ_API Partitioning {
 class DATASERVICE_READ_API Schema {
  public:
   Schema() = default;
+  Schema(const Schema&) = default;
+  Schema(Schema&&) = default;
+  Schema& operator=(const Schema&) = default;
+  Schema& operator=(Schema&&) = default;
   virtual ~Schema() = default;
 
  private:
@@ -457,6 +485,10 @@ class DATASERVICE_READ_API Schema {
 class DATASERVICE_READ_API StreamProperties {
  public:
   StreamProperties() = default;
+  StreamProperties(const StreamProperties&) = default;
+  StreamProperties(StreamProperties&&) = default;
+  StreamProperties& operator=(const StreamProperties&) = default;
+  StreamProperties& operator=(StreamProperties&&) = default;
   virtual ~StreamProperties() = default;
 
  private:
@@ -544,6 +576,10 @@ class DATASERVICE_READ_API StreamProperties {
 class DATASERVICE_READ_API Encryption {
  public:
   Encryption() = default;
+  Encryption(const Encryption&) = default;
+  Encryption(Encryption&&) = default;
+  Encryption& operator=(const Encryption&) = default;
+  Encryption& operator=(Encryption&&) = default;
   virtual ~Encryption() = default;
 
  private:
@@ -576,6 +612,10 @@ class DATASERVICE_READ_API Encryption {
 class DATASERVICE_READ_API Volume {
  public:
   Volume() = default;
+  Volume(const Volume&) = default;
+  Volume(Volume&&) = default;
+  Volume& operator=(const Volume&) = default;
+  Volume& operator=(Volume&&) = default;
   virtual ~Volume() = default;
 
  private:
@@ -675,6 +715,10 @@ class DATASERVICE_READ_API Volume {
 class DATASERVICE_READ_API Layer {
  public:
   Layer() = default;
+  Layer(const Layer&) = default;
+  Layer(Layer&&) = default;
+  Layer& operator=(const Layer&) = default;
+  Layer& operator=(Layer&&) = default;
   virtual ~Layer() = default;
 
  private:
@@ -1117,6 +1161,10 @@ class DATASERVICE_READ_API Layer {
 class DATASERVICE_READ_API Notifications {
  public:
   Notifications() = default;
+  Notifications(const Notifications&) = default;
+  Notifications(Notifications&&) = default;
+  Notifications& operator=(const Notifications&) = default;
+  Notifications& operator=(Notifications&&) = default;
   virtual ~Notifications() = default;
 
  private:
@@ -1155,6 +1203,10 @@ class DATASERVICE_READ_API Notifications {
 class DATASERVICE_READ_API Catalog {
  public:
   Catalog() = default;
+  Catalog(const Catalog&) = default;
+  Catalog(Catalog&&) = default;
+  Catalog& operator=(const Catalog&) = default;
+  Catalog& operator=(Catalog&&) = default;
   virtual ~Catalog() = default;
 
  private:

olp-cpp-sdk-dataservice-read/include/olp/dataservice/read/model/Partitions.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019-2021 HERE Europe B.V.
+ * Copyright (C) 2019-2023 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,8 +20,8 @@
 #pragma once
 
 #include <string>
-#include <vector>
 #include <utility>
+#include <vector>
 
 #include <boost/optional.hpp>
 
@@ -38,6 +38,10 @@ namespace model {
 class DATASERVICE_READ_API Partition {
  public:
   Partition() = default;
+  Partition(const Partition&) = default;
+  Partition(Partition&&) = default;
+  Partition& operator=(const Partition&) = default;
+  Partition& operator=(Partition&&) = default;
   virtual ~Partition() = default;
 
  private:
@@ -281,6 +285,10 @@ class DATASERVICE_READ_API Partition {
 class Partitions {
  public:
   Partitions() = default;
+  Partitions(const Partitions&) = default;
+  Partitions(Partitions&&) = default;
+  Partitions& operator=(const Partitions&) = default;
+  Partitions& operator=(Partitions&&) = default;
   virtual ~Partitions() = default;
 
  private:

olp-cpp-sdk-dataservice-read/include/olp/dataservice/read/model/VersionResponse.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019-2021 HERE Europe B.V.
+ * Copyright (C) 2019-2023 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -39,6 +39,10 @@ namespace model {
 class DATASERVICE_READ_API VersionResponse {
  public:
   VersionResponse() = default;
+  VersionResponse(const VersionResponse&) = default;
+  VersionResponse(VersionResponse&&) = default;
+  VersionResponse& operator=(const VersionResponse&) = default;
+  VersionResponse& operator=(VersionResponse&&) = default;
   virtual ~VersionResponse() = default;
 
  private:

olp-cpp-sdk-dataservice-read/src/generated/model/Api.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019 HERE Europe B.V.
+ * Copyright (C) 2019-2023 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -36,6 +36,10 @@ namespace model {
 class Api {
  public:
   Api() = default;
+  Api(const Api&) = default;
+  Api(Api&&) = default;
+  Api& operator=(const Api&) = default;
+  Api& operator=(Api&&) = default;
   virtual ~Api() = default;
 
  private:

olp-cpp-sdk-dataservice-read/src/generated/model/Index.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019-2021 HERE Europe B.V.
+ * Copyright (C) 2019-2023 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -32,6 +32,10 @@ namespace model {
 class ParentQuad {
  public:
   ParentQuad() = default;
+  ParentQuad(const ParentQuad&) = default;
+  ParentQuad(ParentQuad&&) = default;
+  ParentQuad& operator=(const ParentQuad&) = default;
+  ParentQuad& operator=(ParentQuad&&) = default;
   virtual ~ParentQuad() = default;
 
  private:
@@ -119,6 +123,10 @@ class ParentQuad {
 class SubQuad {
  public:
   SubQuad() = default;
+  SubQuad(const SubQuad&) = default;
+  SubQuad(SubQuad&&) = default;
+  SubQuad& operator=(const SubQuad&) = default;
+  SubQuad& operator=(SubQuad&&) = default;
   virtual ~SubQuad() = default;
 
  private:
@@ -220,6 +228,10 @@ class SubQuad {
 class Index {
  public:
   Index() = default;
+  Index(const Index&) = default;
+  Index(Index&&) = default;
+  Index& operator=(const Index&) = default;
+  Index& operator=(Index&&) = default;
   virtual ~Index() = default;
 
  private:

olp-cpp-sdk-dataservice-read/src/generated/model/LayerVersions.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019 HERE Europe B.V.
+ * Copyright (C) 2019-2023 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -33,6 +33,10 @@ namespace model {
 class LayerVersion {
  public:
   LayerVersion() = default;
+  LayerVersion(const LayerVersion&) = default;
+  LayerVersion(LayerVersion&&) = default;
+  LayerVersion& operator=(const LayerVersion&) = default;
+  LayerVersion& operator=(LayerVersion&&) = default;
   virtual ~LayerVersion() = default;
 
  private:
@@ -60,6 +64,10 @@ class LayerVersion {
 class LayerVersions {
  public:
   LayerVersions() = default;
+  LayerVersions(const LayerVersions&) = default;
+  LayerVersions(LayerVersions&&) = default;
+  LayerVersions& operator=(const LayerVersions&) = default;
+  LayerVersions& operator=(LayerVersions&&) = default;
   virtual ~LayerVersions() = default;
 
  private:

olp-cpp-sdk-dataservice-write/include/olp/dataservice/write/generated/model/Details.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019-2021 HERE Europe B.V.
+ * Copyright (C) 2019-2023 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -32,6 +32,10 @@ namespace model {
 class DATASERVICE_WRITE_API Details {
  public:
   Details() = default;
+  Details(const Details&) = default;
+  Details(Details&&) = default;
+  Details& operator=(const Details&) = default;
+  Details& operator=(Details&&) = default;
   virtual ~Details() = default;
 
  private:

olp-cpp-sdk-dataservice-write/include/olp/dataservice/write/generated/model/Index.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019-2021 HERE Europe B.V.
+ * Copyright (C) 2019-2023 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -74,7 +74,6 @@ class DATASERVICE_WRITE_API IndexValue {
    * @param type The`IndexType` instance.
    */
   explicit IndexValue(IndexType type) : indexType_(type) {}
-  virtual ~IndexValue() = default;
 
   /// A default copy constructor.
   IndexValue(const IndexValue&) = default;
@@ -88,6 +87,9 @@ class DATASERVICE_WRITE_API IndexValue {
   /// A default copy assignment operator.
   IndexValue& operator=(const IndexValue&) = default;
 
+  /// A default virtual destructor.
+  virtual ~IndexValue() = default;
+
   /**
    * @brief Gets the index value type.
    *
@@ -152,8 +154,6 @@ class DATASERVICE_WRITE_API IntIndexValue final : public IndexValue {
   int64_t intValue_{0};
 
  public:
-  virtual ~IntIndexValue() = default;
-
   /**
    * @brief Creates the `IntIndexValue` instance.
    *
@@ -191,8 +191,6 @@ class DATASERVICE_WRITE_API StringIndexValue final : public IndexValue {
   std::string stringValue_;
 
  public:
-  virtual ~StringIndexValue() = default;
-
   /**
    * @brief Creates the `StringIndexValue` instance.
    *
@@ -229,8 +227,6 @@ class DATASERVICE_WRITE_API TimeWindowIndexValue final : public IndexValue {
   int64_t timeWindowValue_{0};
 
  public:
-  virtual ~TimeWindowIndexValue() = default;
-
   /**
    * @brief Creates the `TimeWindowIndexValue` instance.
    *
@@ -316,7 +312,6 @@ class DATASERVICE_WRITE_API Index final {
  public:
   /// A default constructor.
   Index() = default;
-  virtual ~Index() = default;
 
   /**
    * @brief Creates the `Index` insatnce.