Correct the spelling (#816)

The in-memory and on-disk is a tautology.
Elswhere, the term in-memory used seldomly and
the term on-disk almost mever used.

Relates-To: OAM-221

Signed-off-by: Kirill Zhuchkov <[email protected]>

Author: Kirill Zhuchkov

docs/OverallArchitecture.md

@@ -26,7 +26,7 @@ The following diagram shows an overview of the SDK components and their relation
 
 The core module offers the following platform-independent functionality:
 
-* **cache** - on-disk and in-memory cache
+* **cache** - disk and memory cache
 * **client** - generic HTTP client that performs communication with the HERE Open Location Platform (OLP)
 * **geo** - geo utilities
 * **logging** - logging to file, console or any customer-defined logger

docs/dataservice-cache-example.md

@@ -109,7 +109,7 @@ To create the `OlpClientSettings` object:
 
 3. [Authenticate](#authenticate-to-here-olp-using-client-credentials) to OLP.
 
-4. Set up the `OlpClientSettings` object with the path to the needed cache settings properties (disk space, the limit of runtime memory, maximum file size, in-memory data cache size, options, paths).
+4. Set up the `OlpClientSettings` object with the path to the needed cache settings properties (the limit of runtime memory, disk space, maximum file size, memory data cache size, options, and paths).
   For instructions on how to get the path to the cache settings, see the [Build and Run on Linux](#build) section.
   > **Note:** Perform the first call with the valid mutable cache path, and the second call – with the protected cache path.
 

olp-cpp-sdk-authentication/include/olp/authentication/AuthenticationSettings.h

@@ -74,7 +74,7 @@ struct AUTHENTICATION_API AuthenticationSettings {
 
   /**
    * @brief The maximum number of tokens that can be stored in LRU
-   * in-memory cache.
+   * memory cache.
    */
   size_t token_cache_limit{100u};
 

olp-cpp-sdk-core/include/olp/core/cache/CacheSettings.h

@@ -46,17 +46,17 @@ enum class EvictionPolicy : unsigned char {
 };
 
 /**
- * @brief Settings for in-memory and on-disk caching.
+ * @brief Settings for memory and disk caching.
  */
 struct CORE_API CacheSettings {
   /**
-   * @brief The path to the mutable (read-write) on-disk cache where
+   * @brief The path to the mutable (read-write) disk cache where
    * the SDK caches and lookups the content.
    *
    * You should have write permissions.
    *
    * If this parameter is not set, the downloaded data is stored
-   * only in the in-memory cache that is limited by `#max_memory_cache_size`.
+   * only in the memory cache that is limited by `#max_memory_cache_size`.
    */
   boost::optional<std::string> disk_path_mutable = boost::none;
 
@@ -92,9 +92,9 @@ struct CORE_API CacheSettings {
   size_t max_file_size = 1024u * 1024u * 2u;
 
   /**
-   * @brief Sets the upper limit of the in-memory data cache size (in bytes).
+   * @brief Sets the upper limit of the memory data cache size (in bytes).
    *
-   * If set to `0`, the in-memory cache is not used. The default value is 1 MB.
+   * If set to `0`, the memory cache is not used. The default value is 1 MB.
    */
   size_t max_memory_cache_size = 1024u * 1024u;
 

olp-cpp-sdk-core/include/olp/core/cache/DefaultCache.h

@@ -31,7 +31,7 @@ namespace cache {
 class DefaultCacheImpl;
 
 /**
- * @brief A default cache that provides an in-memory LRU cache and persistence
+ * @brief A default cache that provides a memory LRU cache and persistence
  * of cached key-value pairs.
  *
  * @note By default, the downloaded data is cached only in memory.
@@ -47,7 +47,7 @@ class DefaultCacheImpl;
  * limitation, the default cache can be accessed only by one process
  * exclusively.
  *
- * By default, the maximum size of the in-memory cache is 1MB. To change it,
+ * By default, the maximum size of the memory cache is 1MB. To change it,
  * set `olp::cache::CacheSettings::max_memory_cache_size` to the desired value.
  */
 class CORE_API DefaultCache : public KeyValueCache {

olp-cpp-sdk-core/include/olp/core/client/OlpClientSettings.h

@@ -255,7 +255,7 @@ struct CORE_API OlpClientSettings {
    * results such as metadata, partition data, URLs from the API Lookup Service,
    * and others.
    *
-   * To only use the in-memory LRU cache with limited size, set to `nullptr`.
+   * To only use the memory LRU cache with limited size, set to `nullptr`.
    */
   std::shared_ptr<cache::KeyValueCache> cache = nullptr;
 };

olp-cpp-sdk-core/include/olp/core/client/OlpClientSettingsFactory.h

@@ -76,7 +76,7 @@ class CORE_API OlpClientSettingsFactory final {
 
   /**
    * @brief Creates the `KeyValueCache` instance that includes both a small
-   * in-memory LRU cache and a larger persistent database cache.
+   * memory LRU cache and a larger persistent database cache.
    *
    * The returned cache instance is initialized, opened, and ready to be used.
    *

olp-cpp-sdk-core/src/cache/DiskCache.h

@@ -73,7 +73,7 @@ struct StorageSettings {
 };
 
 /**
- * @brief Class which abstracts the on-disk database engine.
+ * @brief Abstracts the disk database engine.
  */
 class DiskCache {
  public:

olp-cpp-sdk-dataservice-read/include/olp/dataservice/read/CatalogClient.h

@@ -57,7 +57,7 @@ class CatalogClientImpl;
  *     You can set the default implementation
  *     (`olp::client::OlpClientSettingsFactory::CreateDefaultNetworkRequestHandler`)
  *     or pass a custom network implementation to the `CatalogClient` object.
- *   * The on-disk cache.
+ *   * The disk cache.
  *     By default, the `CatalogClient` object uses the default implementation
  *     of `olp::cache::DefaultCache`.
  */

tests/integration/olp-cpp-sdk-dataservice-read/VersionedLayerClientCacheTest.cpp

@@ -208,7 +208,7 @@ TEST_P(VersionedLayerClientCacheTest, GetDataWithPartitionIdDifferentVersions) {
 
   // Test with this parameter is not relevant anymore for cache type none since
   // we cannot query 2 versions from one instance of versioned layer client and
-  // we cannot share default in-memory created cache between 2 instances.
+  // we cannot share default memory created cache between 2 instances.
   if (GetParam() == CacheType::NONE) {
     return;
   }