You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Move **Create platform client settings** to a separate .md file.
- Align the how-to instructions of examples with the Dev Guide
instructions.
- For links to other GitHub pages, replace MD links with HTML
(only for instructions reused in the Dev Guide).
Otherwise, they will be inactive when rendered to the doc portal.
- In doc headings, change title-style capitalization to sentence-style
to align it with the doc portal doc.
Relates-To: OLPEDGE-2348
Signed-off-by: Halyna Dumych <[email protected]>
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+21-21Lines changed: 21 additions & 21 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,24 +2,24 @@
2
2
3
3
## Contributing to HERE Data SDK for C++
4
4
5
-
First off, thanks for taking the time to contribute! The team behind the [HERE Data SDK for C++](https://github.com/heremaps/here-data-sdk-cpp) gratefully accepts contributions via [pull requests](https://help.github.com/articles/about-pull-requests/) filed against the [GitHub project](https://github.com/heremaps/here-data-sdk-cpp/pulls). As part of filing a pull request, we ask you to sign off the [Developer Certificate of Origin](https://developercertificate.org/) (DCO).
5
+
First off, thanks for taking the time to contribute! The team behind [HERE Data SDK for C++](https://github.com/heremaps/here-data-sdk-cpp) gratefully accepts contributions via [pull requests](https://help.github.com/articles/about-pull-requests/) filed against the [GitHub project](https://github.com/heremaps/here-data-sdk-cpp/pulls). As part of filling a pull request, we ask you to add the [Developer Certificate of Origin](https://developercertificate.org/) (DCO) sign-off.
6
6
7
7
## Development
8
8
9
-
### Code Style
9
+
### Code style
10
10
11
11
This SDK follows the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html). In case we differ from the Google C++ Style Guide in any way or are more specific on a given point, the following document reflects such differences.
12
12
13
13
#### Differences from the Google C++ Style Guide
14
14
15
-
##### File Names
15
+
##### File names
16
16
17
17
- Name files in CamelCase. For example, `MyClassName.cpp`.
18
18
- End C++ files with `.cpp` and header files with `.h`.
19
19
- You can move inline functions into a separate `.inl` file to neatly arrange `.h` files.
20
20
- End files that contain a test code with `Test`. For example, `MyClassNameTest.cpp`.
21
21
22
-
##### Enumerator Names
22
+
##### Enumerator names
23
23
24
24
- Use CamelCase for enumeration names, as an enumeration name is a type.
25
25
- Use CamelCase for individual enumerators.
@@ -35,7 +35,7 @@ enum class FetchOption {
35
35
};
36
36
```
37
37
38
-
### File Headers
38
+
### File headers
39
39
40
40
Every `.cpp`, `.h`, and `.inl` file must contain the following header at the very top:
41
41
@@ -81,7 +81,7 @@ CMake files or bash scripts must contain the following header at the very top:
81
81
# License-Filename: LICENSE
82
82
```
83
83
84
-
### Code Formatting
84
+
### Code formatting
85
85
86
86
The SDK uses `clang-format` to automatically format all source code before submission. The SDK follows the standard Google `clang-format` style, as seen in the [.clang-format](./.clang-format) file at the root of this project.
87
87
@@ -104,7 +104,7 @@ If you need to format all `.cpp` and `.h` files in a directory recursively, you
We strive to maintain a high software quality standard and strongly encourage contributions to keep up with the the guidelines.
110
110
In general, we share the view on how a commit message should be written with the [Git project itself](https://github.com/git/git/blob/master/Documentation/SubmittingPatches).
@@ -125,7 +125,7 @@ When you create a commit message, follow these guidelines:
125
125
- If you are unfamiliar with how to fix up the existing commits, please read about [rewriting history](https://git-scm.com/book/id/v2/Git-Tools-Rewriting-History) and `git rebase --interactive` in particular.
126
126
- To resolve conflicts, rebase pull request branches onto their target branch instead of merging the target branch into the pull request branch—such approach results in a cleaner history without "criss-cross" merges.
127
127
128
-
### Design Guidelines
128
+
### Design guidelines
129
129
130
130
- Follow the **SOLID** design principles:
131
131
@@ -143,7 +143,7 @@ When you create a commit message, follow these guidelines:
143
143
144
144
> "Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away." – Antoine de Saint-Exupery
145
145
146
-
### Implementation Guidelines
146
+
### Implementation guidelines
147
147
148
148
- Use the [C++11 standard](http://www.stroustrup.com/C++11FAQ.html).
149
149
- Use [RAII](https://en.cppreference.com/w/cpp/language/raii). Avoid explicit use of new and delete unless there is a good reason to do so.
@@ -158,28 +158,28 @@ When you create a commit message, follow these guidelines:
158
158
- Use `#pragma once` to include guards.
159
159
- Use `nullptr` instead of `NULL` or `0`.
160
160
161
-
### Testing Guidelines
161
+
### Testing guidelines
162
162
163
163
- Use [Google Test](https://github.com/google/googletest) as a test framework.
164
164
- Each unit test endeavors to test one function only.
165
165
- Good tests serve as a good example of how to use the code under test.
166
166
- [Design](#design-guidelines) and [implementation](#implementation-guidelines) Guidelines apply to tests as well.
167
167
168
-
### Component Guidelines
168
+
### Component guidelines
169
169
170
-
#### Component Name
170
+
#### Component name
171
171
172
172
The SDK uses the following pattern for component names: **olp-cpp-sdk**-_component-name_. For example, `olp-cpp-sdk-dataservice-read`.
173
173
174
-
#### API Namespace
174
+
#### API namespace
175
175
176
176
The SDK uses the following pattern for namespace names: **olp**::_component::subcomponent_. For example, `olp::authentication`,`olp::dataservice::write`.
177
177
178
-
#### API Class Name
178
+
#### API class name
179
179
180
180
The SDK uses the following pattern for API class names: \*Api**\*Client**. For example, `StreamLayerClient`.
181
181
182
-
#### API Method Signature
182
+
#### API method signature
183
183
184
184
The SDK provides a set of common classes that are used to define the APIs.
185
185
These classes are located in the **olp-cpp-sdk-core/include/olp/core/client** folder.
The SDK uses `boost::optional` for optional members, parameters, or return types. Also, function comments should indicate whether the parameter is optional or required.
The SDK provides a unified way of performing REST requests by exposing a set of utility classes in the **olp-cpp-sdk-core/include/olp/core/client** folder.
306
306
@@ -335,7 +335,7 @@ class DATASERVICE_READ_API CatalogClient final {
335
335
}
336
336
```
337
337
338
-
#### Components Build Script
338
+
#### Components build script
339
339
340
340
The SDK uses CMake as a build tool and provides a set of utility scripts to build components, export component targets, as well as create and install component configuration files. These scripts are located in the **cmake** folder.
341
341
Make sure that each component has it's own CMake script or scripts that define the project and unit test targets. The component can use the **export_config()** method (from **cmake/common.cmake**) to export a component so that it can be used by a client application that uses **find_package()** to retrieve the component.
@@ -353,7 +353,7 @@ if(EOLP_SDK_ENABLE_TESTING)
353
353
endif()
354
354
```
355
355
356
-
#### Component Documentation
356
+
#### Component documentation
357
357
358
358
The SDK uses [Doxygen](http://www.doxygen.nl/) to generate its documentation from the code.
359
359
Make sure to properly document each header file that is exposed by the component with the use of Doxygen format.
0 commit comments