Skip to content

Commit 452006b

Browse files
authored
Update doc to reuse it in the Dev Guide (#1110)
- Move **Create platform client settings** to a separate .md file. - Align the how-to instructions of examples with the Dev Guide instructions. - For links to other GitHub pages, replace MD links with HTML (only for instructions reused in the Dev Guide). Otherwise, they will be inactive when rendered to the doc portal. - In doc headings, change title-style capitalization to sentence-style to align it with the doc portal doc. Relates-To: OLPEDGE-2348 Signed-off-by: Halyna Dumych <[email protected]>
1 parent 3b60235 commit 452006b

10 files changed

+431
-643
lines changed

CONTRIBUTING.md

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,24 @@
22

33
## Contributing to HERE Data SDK for C++
44

5-
First off, thanks for taking the time to contribute! The team behind the [HERE Data SDK for C++](https://github.com/heremaps/here-data-sdk-cpp) gratefully accepts contributions via [pull requests](https://help.github.com/articles/about-pull-requests/) filed against the [GitHub project](https://github.com/heremaps/here-data-sdk-cpp/pulls). As part of filing a pull request, we ask you to sign off the [Developer Certificate of Origin](https://developercertificate.org/) (DCO).
5+
First off, thanks for taking the time to contribute! The team behind [HERE Data SDK for C++](https://github.com/heremaps/here-data-sdk-cpp) gratefully accepts contributions via [pull requests](https://help.github.com/articles/about-pull-requests/) filed against the [GitHub project](https://github.com/heremaps/here-data-sdk-cpp/pulls). As part of filling a pull request, we ask you to add the [Developer Certificate of Origin](https://developercertificate.org/) (DCO) sign-off.
66

77
## Development
88

9-
### Code Style
9+
### Code style
1010

1111
This SDK follows the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html). In case we differ from the Google C++ Style Guide in any way or are more specific on a given point, the following document reflects such differences.
1212

1313
#### Differences from the Google C++ Style Guide
1414

15-
##### File Names
15+
##### File names
1616

1717
- Name files in CamelCase. For example, `MyClassName.cpp`.
1818
- End C++ files with `.cpp` and header files with `.h`.
1919
- You can move inline functions into a separate `.inl` file to neatly arrange `.h` files.
2020
- End files that contain a test code with `Test`. For example, `MyClassNameTest.cpp`.
2121

22-
##### Enumerator Names
22+
##### Enumerator names
2323

2424
- Use CamelCase for enumeration names, as an enumeration name is a type.
2525
- Use CamelCase for individual enumerators.
@@ -35,7 +35,7 @@ enum class FetchOption {
3535
};
3636
```
3737
38-
### File Headers
38+
### File headers
3939
4040
Every `.cpp`, `.h`, and `.inl` file must contain the following header at the very top:
4141
@@ -81,7 +81,7 @@ CMake files or bash scripts must contain the following header at the very top:
8181
# License-Filename: LICENSE
8282
```
8383

84-
### Code Formatting
84+
### Code formatting
8585

8686
The SDK uses `clang-format` to automatically format all source code before submission. The SDK follows the standard Google `clang-format` style, as seen in the [.clang-format](./.clang-format) file at the root of this project.
8787

@@ -104,7 +104,7 @@ If you need to format all `.cpp` and `.h` files in a directory recursively, you
104104
find foo/bar/ -iname *.h -o -iname *.cpp | xargs clang-format -i --style=file
105105
```
106106

107-
### Style Guidelines for Commit Messages
107+
### Style guidelines for commit messages
108108

109109
We strive to maintain a high software quality standard and strongly encourage contributions to keep up with the the guidelines.
110110
In general, we share the view on how a commit message should be written with the [Git project itself](https://github.com/git/git/blob/master/Documentation/SubmittingPatches).
@@ -125,7 +125,7 @@ When you create a commit message, follow these guidelines:
125125
- If you are unfamiliar with how to fix up the existing commits, please read about [rewriting history](https://git-scm.com/book/id/v2/Git-Tools-Rewriting-History) and `git rebase --interactive` in particular.
126126
- To resolve conflicts, rebase pull request branches onto their target branch instead of merging the target branch into the pull request branch—such approach results in a cleaner history without "criss-cross" merges.
127127

128-
### Design Guidelines
128+
### Design guidelines
129129

130130
- Follow the **SOLID** design principles:
131131

@@ -143,7 +143,7 @@ When you create a commit message, follow these guidelines:
143143

144144
> "Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away." – Antoine de Saint-Exupery
145145

146-
### Implementation Guidelines
146+
### Implementation guidelines
147147

148148
- Use the [C++11 standard](http://www.stroustrup.com/C++11FAQ.html).
149149
- Use [RAII](https://en.cppreference.com/w/cpp/language/raii). Avoid explicit use of new and delete unless there is a good reason to do so.
@@ -158,28 +158,28 @@ When you create a commit message, follow these guidelines:
158158
- Use `#pragma once` to include guards.
159159
- Use `nullptr` instead of `NULL` or `0`.
160160

161-
### Testing Guidelines
161+
### Testing guidelines
162162

163163
- Use [Google Test](https://github.com/google/googletest) as a test framework.
164164
- Each unit test endeavors to test one function only.
165165
- Good tests serve as a good example of how to use the code under test.
166166
- [Design](#design-guidelines) and [implementation](#implementation-guidelines) Guidelines apply to tests as well.
167167

168-
### Component Guidelines
168+
### Component guidelines
169169

170-
#### Component Name
170+
#### Component name
171171

172172
The SDK uses the following pattern for component names: **olp-cpp-sdk**-_component-name_. For example, `olp-cpp-sdk-dataservice-read`.
173173

174-
#### API Namespace
174+
#### API namespace
175175

176176
The SDK uses the following pattern for namespace names: **olp**::_component::subcomponent_. For example, `olp::authentication`,`olp::dataservice::write`.
177177

178-
#### API Class Name
178+
#### API class name
179179

180180
The SDK uses the following pattern for API class names: \*Api**\*Client**. For example, `StreamLayerClient`.
181181

182-
#### API Method Signature
182+
#### API method signature
183183

184184
The SDK provides a set of common classes that are used to define the APIs.
185185
These classes are located in the **olp-cpp-sdk-core/include/olp/core/client** folder.
@@ -232,7 +232,7 @@ olp::client::CancellableFuture<CatalogResponse> GetCatalog(const CatalogRequest&
232232
olp::client::CancellationToken GetCatalog(const CatalogRequest& request, const CatalogResponseCallback& callback);
233233
```
234234
235-
#### API Setters and Getters
235+
#### API setters and getters
236236
237237
The SDK uses the following pattern for getters and setters:
238238
@@ -255,7 +255,7 @@ inline PublishDataRequest& WithLayerId(std::string&& layer_id) {
255255
}
256256
```
257257

258-
#### API Optional Parameters
258+
#### API optional parameters
259259

260260
The SDK uses `boost::optional` for optional members, parameters, or return types. Also, function comments should indicate whether the parameter is optional or required.
261261

@@ -277,7 +277,7 @@ inline PublishDataRequest& WithBillingTag(std::string&& billing_tag) {
277277
}
278278
```
279279
280-
#### API Binary Data
280+
#### API binary data
281281
282282
The SDK uses the `std::vector<unsigned char>` type to represent binary data.
283283
Using `shared_ptr<std::vector<unsigned char>>` ensures that no data copy is required to transfer or process data.
@@ -300,7 +300,7 @@ inline PublishDataRequest& WithData(std::shared_ptr<std::vector<unsigned char>>&
300300
}
301301
```
302302

303-
### REST Client
303+
### REST client
304304

305305
The SDK provides a unified way of performing REST requests by exposing a set of utility classes in the **olp-cpp-sdk-core/include/olp/core/client** folder.
306306

@@ -335,7 +335,7 @@ class DATASERVICE_READ_API CatalogClient final {
335335
}
336336
```
337337
338-
#### Components Build Script
338+
#### Components build script
339339
340340
The SDK uses CMake as a build tool and provides a set of utility scripts to build components, export component targets, as well as create and install component configuration files. These scripts are located in the **cmake** folder.
341341
Make sure that each component has it's own CMake script or scripts that define the project and unit test targets. The component can use the **export_config()** method (from **cmake/common.cmake**) to export a component so that it can be used by a client application that uses **find_package()** to retrieve the component.
@@ -353,7 +353,7 @@ if(EOLP_SDK_ENABLE_TESTING)
353353
endif()
354354
```
355355

356-
#### Component Documentation
356+
#### Component documentation
357357

358358
The SDK uses [Doxygen](http://www.doxygen.nl/) to generate its documentation from the code.
359359
Make sure to properly document each header file that is exposed by the component with the use of Doxygen format.

0 commit comments

Comments
 (0)