Fix the DefaultCache::Put behavior (#602)

Fix the DefaultCache::Put behavior when the value does not fit in-memory cache

When the value does not fit the in-memory cache, it still cached on disk.

Resolves: OLPSUP-9206

Signed-off-by: Mykhailo Kuchma <[email protected]>

Author: mykhailo-kuchma

olp-cpp-sdk-core/src/cache/DefaultCache.cpp

@@ -134,8 +134,11 @@ bool DefaultCache::Put(const std::string& key, const boost::any& value,
 
   auto encodedItem = encoder();
   if (memory_cache_) {
-    if (!memory_cache_->Put(key, value, expiry, encodedItem.size()))
-      return false;
+    if (!memory_cache_->Put(key, value, expiry, encodedItem.size())) {
+      OLP_SDK_LOG_WARNING_F(kLogTag,
+                            "Failed to store value in memory cache %s, size %d",
+                            key.c_str(), static_cast<int>(encodedItem.size()));
+    }
   }
 
   if (mutable_cache_) {
@@ -162,7 +165,9 @@ bool DefaultCache::Put(const std::string& key,
 
   if (memory_cache_) {
     if (!memory_cache_->Put(key, value, expiry, value->size())) {
-      return false;
+      OLP_SDK_LOG_WARNING_F(kLogTag,
+                            "Failed to store value in memory cache %s, size %d",
+                            key.c_str(), static_cast<int>(value->size()));
     }
   }
 

olp-cpp-sdk-core/tests/cache/DefaultCacheTest.cpp

@@ -343,3 +343,30 @@ TEST(DefaultCacheTest, AlreadyInUsePath) {
   olp::cache::DefaultCache cache2(settings);
   ASSERT_EQ(olp::cache::DefaultCache::OpenDiskPathFailure, cache2.Open());
 }
+
+TEST(DefaultCacheTest, ValueGreaterThanMemCacheLimit) {
+  using namespace olp::cache;
+
+  const std::string content_key = "test_key";
+  const std::string content =
+      "a very long string that does not fit into the in memory cache";
+
+  olp::cache::CacheSettings settings;
+  settings.max_memory_cache_size = 10;
+  settings.disk_path_mutable = olp::utils::Dir::TempDirectory() + "/mutable";
+
+  DefaultCache cache(settings);
+  EXPECT_EQ(cache.Open(), DefaultCache::StorageOpenResult::Success);
+
+  auto input_buffer = std::make_shared<std::vector<unsigned char>>(
+      std::begin(content), std::end(content));
+  EXPECT_TRUE(cache.Put(content_key, input_buffer, 15));
+
+  auto output_buffer = cache.Get(content_key);
+  ASSERT_TRUE(output_buffer != nullptr);
+
+  EXPECT_TRUE(std::equal(output_buffer->begin(), output_buffer->end(),
+                         content.begin()));
+
+  cache.Close();
+}