Use system clock time as a fallback (#616)

* Use system clock time as a fallback in AuthenticationClient::SignInClient()
   request when GetTimeFromServer() call fails.

Resolves: OLPEDGE-1499
Signed-off-by: Serhii Lozynskyi <[email protected]>

Author: meravingen123

olp-cpp-sdk-authentication/src/AuthenticationClient.cpp

@@ -278,19 +278,16 @@ client::CancellationToken AuthenticationClient::Impl::SignInClient(
   client::CancellationContext context;
 
   auto time_callback = [=](TimeResponse response) mutable {
-    if (!response.IsSuccessful()) {
-      callback(AuthenticationError(
-          static_cast<int>(response.GetError().GetHttpStatusCode()),
-          response.GetError().GetMessage()));
-      return;
-    }
+    // As a fallback use local system time as a timestamp
+    time_t timestamp =
+        response.IsSuccessful() ? response.GetResult() : std::time(nullptr);
 
     std::string url = server_url_;
     url.append(kOauthEndpoint);
     http::NetworkRequest request(url);
     request.WithVerb(http::NetworkRequest::HttpVerb::POST);
     request.WithHeader(http::kAuthorizationHeader,
-                       generateHeader(credentials, url, response.GetResult()));
+                       generateHeader(credentials, url, timestamp));
     request.WithHeader(http::kContentTypeHeader, kApplicationJson);
     request.WithHeader(http::kUserAgentHeader, http::kOlpSdkUserAgent);
     request.WithSettings(network_settings_);

tests/integration/olp-cpp-sdk-authentication/AuthenticationClientTest.cpp

@@ -172,12 +172,12 @@ class AuthenticationClientTest : public ::testing::Test {
 
     EXPECT_CALL(*network_, Send(testing::_, testing::_, testing::_, testing::_,
                                 testing::_))
-        .Times(1)
-        .WillOnce([&](olp::http::NetworkRequest request,
-                      olp::http::Network::Payload payload,
-                      olp::http::Network::Callback callback,
-                      olp::http::Network::HeaderCallback header_callback,
-                      olp::http::Network::DataCallback data_callback) {
+        .Times(2)  // First is GetTimeFromServer(). Second is actual SignIn.
+        .WillRepeatedly([&](olp::http::NetworkRequest request,
+                            olp::http::Network::Payload payload,
+                            olp::http::Network::Callback callback,
+                            olp::http::Network::HeaderCallback header_callback,
+                            olp::http::Network::DataCallback data_callback) {
           olp::http::RequestId request_id(5);
           if (payload) {
             *payload << data;

tests/integration/olp-cpp-sdk-authentication/HereAccountOauth2Test.cpp

@@ -274,7 +274,28 @@ TEST_F(HereAccountOauth2Test, AutoRefreshingTokenCancelAsync) {
 
         return olp::http::SendOutcome(request_id);
       });
+  EXPECT_CALL(*network_, Send(IsGetRequest(kTimestampUrl), _, _, _, _))
+      .Times(2)
+      .WillRepeatedly([&](olp::http::NetworkRequest request,
+                          olp::http::Network::Payload payload,
+                          olp::http::Network::Callback callback,
+                          olp::http::Network::HeaderCallback header_callback,
+                          olp::http::Network::DataCallback data_callback) {
+        olp::http::RequestId request_id(5);
+        if (payload) {
+          *payload << kResponseTime;
+        }
+        callback(olp::http::NetworkResponse()
+                     .WithRequestId(request_id)
+                     .WithStatus(olp::http::HttpStatusCode::OK));
+        if (data_callback) {
+          auto raw = const_cast<char*>(kResponseTime.c_str());
+          data_callback(reinterpret_cast<uint8_t*>(raw), 0,
+                        kResponseTime.size());
+        }
 
+        return olp::http::SendOutcome(request_id);
+      });
   Settings settings({key_, secret_});
   settings.network_request_handler = network_;
   TokenEndpoint token_endpoint(settings);