Skip to content

Commit 81e4aa3

Browse files
Remove deprecated methods.
Resolves: OLPEDGE-1152 Signed-off-by: Mykhailo Kuchma <[email protected]>
1 parent 020ed75 commit 81e4aa3

File tree

4 files changed

+0
-44
lines changed

4 files changed

+0
-44
lines changed

olp-cpp-sdk-core/include/olp/core/client/CancellationToken.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,6 @@ class CORE_API CancellationToken {
4343
*/
4444
CancellationToken(std::function<void()> func);
4545

46-
/**
47-
* @brief Cancels the current operation, calls the func_ instance variable.
48-
*/
49-
OLP_SDK_DEPRECATED("Deprecated, use Cancel instead.")
50-
void cancel() const;
51-
5246
/**
5347
* @brief Cancels the current operation, calls the func_ instance variable.
5448
*/

olp-cpp-sdk-core/src/client/CancellationToken.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ namespace client {
2424
CancellationToken::CancellationToken(std::function<void()> func)
2525
: func_(std::move(func)) {}
2626

27-
void CancellationToken::cancel() const { Cancel(); }
28-
2927
void CancellationToken::Cancel() const {
3028
if (func_) {
3129
func_();

olp-cpp-sdk-dataservice-read/include/olp/dataservice/read/CatalogClient.h

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -103,32 +103,6 @@ class DATASERVICE_READ_API CatalogClient final {
103103
client::CancellableFuture<CatalogVersionResponse> GetLatestVersion(
104104
CatalogVersionRequest request);
105105

106-
/**
107-
* @brief fetches catalog version asynchronously.
108-
* @param request contains the complete set of request parameters.
109-
* @param callback will be invoked once the catalog version is
110-
* available, or an error is encountered.
111-
* @return A token that can be used to cancel this request
112-
* @deprecated Will be removed in 1.1, please use \c GetLatestVersion instead.
113-
*/
114-
OLP_SDK_DEPRECATED(
115-
"Will be removed in 1.1, please use GetLatestVersion() instead")
116-
client::CancellationToken GetCatalogMetadataVersion(
117-
CatalogVersionRequest request, CatalogVersionCallback callback);
118-
119-
/**
120-
* @brief fetches catalog version asynchronously.
121-
* @param request contains the complete set of request parameters.
122-
* @return CancellableFuture of type CatalogVersionResponse, which when
123-
* complete will contain the catalog configuration or an error.
124-
* Alternatively, the CancellableFuture can be used to cancel this request.
125-
* @deprecated Will be removed in 1.1, please use \c GetLatestVersion instead.
126-
*/
127-
OLP_SDK_DEPRECATED(
128-
"Will be removed in 1.1, please use GetLatestVersion() instead")
129-
client::CancellableFuture<CatalogVersionResponse> GetCatalogMetadataVersion(
130-
CatalogVersionRequest request);
131-
132106
private:
133107
std::unique_ptr<CatalogClientImpl> impl_;
134108
};

olp-cpp-sdk-dataservice-read/src/CatalogClient.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,6 @@ client::CancellableFuture<CatalogVersionResponse>
6161
CatalogClient::GetLatestVersion(CatalogVersionRequest request) {
6262
return impl_->GetLatestVersion(std::move(request));
6363
}
64-
65-
client::CancellationToken CatalogClient::GetCatalogMetadataVersion(
66-
CatalogVersionRequest request, CatalogVersionCallback callback) {
67-
return impl_->GetLatestVersion(std::move(request), std::move(callback));
68-
}
69-
70-
client::CancellableFuture<CatalogVersionResponse>
71-
CatalogClient::GetCatalogMetadataVersion(CatalogVersionRequest request) {
72-
return impl_->GetLatestVersion(std::move(request));
73-
}
7464
} // namespace read
7565
} // namespace dataservice
7666
} // namespace olp

0 commit comments

Comments
 (0)