Change BadRequest to NotFound error in tests (#1349)

andrey-kashcheev · web-flow · commit 845a814fbaf5 · 2022-07-20T10:15:37.000+02:00
Platform now reports `(404) Not Found` error instead of expected
`(400) Bad Request` for non-existent layers. Update tests accordingly.

Relates-To: OLPEDGE-2764
Signed-off-by: Andrey Kashcheev &lt;ext-andrey.kashcheev@here.com&gt;
diff --git a/tests/functional/olp-cpp-sdk-dataservice-read/DataserviceReadVersionedLayerClientTest.cpp b/tests/functional/olp-cpp-sdk-dataservice-read/DataserviceReadVersionedLayerClientTest.cpp
@@ -360,7 +360,7 @@ TEST_F(DataserviceReadVersionedLayerClientTest, GetPartitionsForInvalidLayer) {
       });
 
   ASSERT_FALSE(partitions_response.IsSuccessful());
-  ASSERT_EQ(olp::client::ErrorCode::BadRequest,
+  ASSERT_EQ(olp::client::ErrorCode::NotFound,
             partitions_response.GetError().GetErrorCode());
 }
 
@@ -625,7 +625,7 @@ TEST_F(DataserviceReadVersionedLayerClientTest, GetTileWithInvalidLayerId) {
   });
 
   ASSERT_FALSE(data_response.IsSuccessful());
-  ASSERT_EQ(olp::client::ErrorCode::BadRequest,
+  ASSERT_EQ(olp::client::ErrorCode::NotFound,
             data_response.GetError().GetErrorCode());
 }
 

Original file line number	Diff line number	Diff line change
`@@ -360,7 +360,7 @@ TEST_F(DataserviceReadVersionedLayerClientTest, GetPartitionsForInvalidLayer) {`
`360`	`360`	`});`
`361`	`361`
`362`	`362`	`ASSERT_FALSE(partitions_response.IsSuccessful());`
`363`		`- ASSERT_EQ(olp::client::ErrorCode::BadRequest,`
	`363`	`+ ASSERT_EQ(olp::client::ErrorCode::NotFound,`
`364`	`364`	`partitions_response.GetError().GetErrorCode());`
`365`	`365`	`}`
`366`	`366`
`@@ -625,7 +625,7 @@ TEST_F(DataserviceReadVersionedLayerClientTest, GetTileWithInvalidLayerId) {`
`625`	`625`	`});`
`626`	`626`
`627`	`627`	`ASSERT_FALSE(data_response.IsSuccessful());`
`628`		`- ASSERT_EQ(olp::client::ErrorCode::BadRequest,`
	`628`	`+ ASSERT_EQ(olp::client::ErrorCode::NotFound,`
`629`	`629`	`data_response.GetError().GetErrorCode());`
`630`	`630`	`}`
`631`	`631`