Add http::ErrorCodes to DefaultRetryCondition() (#1213)

Default retry condition func must also consider http::ErrorCodes. Unit
test tuned accordingly.

Relates-To: OLPEDGE-2567

Signed-off-by: Kostiantyn Zvieriev <[email protected]>

Author: kzvieriev

olp-cpp-sdk-core/src/client/OlpClientSettings.cpp

@@ -33,6 +33,14 @@ bool DefaultRetryCondition(const HttpResponse& response) {
       response.status == http::HttpStatusCode::TOO_MANY_REQUESTS) {
     return true;
   }
+
+  if (response.status == static_cast<int>(http::ErrorCode::IO_ERROR) ||
+      response.status == static_cast<int>(http::ErrorCode::OFFLINE_ERROR) ||
+      response.status == static_cast<int>(http::ErrorCode::TIMEOUT_ERROR) ||
+      response.status ==
+          static_cast<int>(http::ErrorCode::NETWORK_OVERLOAD_ERROR)) {
+    return true;
+  }
   return false;
 }
 

olp-cpp-sdk-core/tests/client/OlpClientTest.cpp

@@ -252,10 +252,11 @@ TEST_P(OlpClientTest, DefaultRetryCondition) {
   olp::http::RequestId request_id = 5;
   std::vector<std::future<void>> futures;
 
-  // retry for 429 and all 5xx status codes.
+  // retry for IO, offline, timeout, network overload error codes and 429, all
+  // 5xx http status codes.
   auto attempt_statuses =
-      std::queue<int>{{429, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509,
-                       510, 511, 598, 599, 200}};
+      std::queue<int>{{-1,  -4,  -7,  -8,  429, 500, 501, 502, 503, 504,
+                       505, 506, 507, 508, 509, 510, 511, 598, 599, 200}};
   client_settings_.retry_settings.max_attempts = attempt_statuses.size();
   client_settings_.retry_settings.backdown_strategy =
       [](std::chrono::milliseconds, size_t) {
@@ -1547,6 +1548,7 @@ TEST_P(OlpClientTest, CancelRetry) {
 
 TEST_P(OlpClientTest, SlowDownError) {
   auto network = network_;
+  client_settings_.retry_settings.max_attempts = 0;
   client_.SetSettings(client_settings_);
   constexpr int kExpectedError =
       static_cast<int>(http::ErrorCode::NETWORK_OVERLOAD_ERROR);