Skip to content

Commit 9740ef2

Browse files
Move some function bodies to cpp (#915)
Move operator= and move constructor of AuthenticationClient class to cpp file to prevent 'use of undeclared AuthenticationClientImpl' error. Resolves: OLPEDGE-2079 Signed-off-by: Serhii Lozynskyi <[email protected]>
1 parent ea46be0 commit 9740ef2

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

olp-cpp-sdk-authentication/include/olp/authentication/AuthenticationClient.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,8 +285,8 @@ class AUTHENTICATION_API AuthenticationClient {
285285
// Non-copyable but movable
286286
AuthenticationClient(const AuthenticationClient&) = delete;
287287
AuthenticationClient& operator=(const AuthenticationClient&) = delete;
288-
AuthenticationClient(AuthenticationClient&&) noexcept = default;
289-
AuthenticationClient& operator=(AuthenticationClient&&) noexcept = default;
288+
AuthenticationClient(AuthenticationClient&&) noexcept;
289+
AuthenticationClient& operator=(AuthenticationClient&&) noexcept;
290290

291291
/**
292292
* @brief Signs in with your HERE Account client credentials and requests

olp-cpp-sdk-authentication/src/AuthenticationClient.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@ AuthenticationClient::AuthenticationClient(AuthenticationSettings settings)
3737

3838
AuthenticationClient::~AuthenticationClient() = default;
3939

40+
AuthenticationClient::AuthenticationClient(AuthenticationClient&&) noexcept =
41+
default;
42+
AuthenticationClient& AuthenticationClient::operator=(
43+
AuthenticationClient&&) noexcept = default;
44+
4045
client::CancellationToken AuthenticationClient::SignInClient(
4146
AuthenticationCredentials credentials, SignInProperties properties,
4247
SignInClientCallback callback) {

0 commit comments

Comments
 (0)