Skip to content

Commit 99821c8

Browse files
Adapt CancelPendingRequests method name to common style.
Relates-To: OLPEDGE-978 Signed-off-by: Mykhailo Kuchma <[email protected]>
1 parent be960e3 commit 99821c8

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

olp-cpp-sdk-dataservice-read/include/olp/dataservice/read/CatalogClient.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,11 @@ class DATASERVICE_READ_API CatalogClient final {
5656

5757
~CatalogClient() = default;
5858

59-
bool cancelPendingRequests();
59+
/**
60+
* @brief Cancel currently active requests.
61+
* @return True on success
62+
*/
63+
bool CancelPendingRequests();
6064

6165
/**
6266
* @brief fetches catalog configuration asynchronously.

olp-cpp-sdk-dataservice-read/src/CatalogClient.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ CatalogClient::CatalogClient(client::HRN catalog,
3838
std::move(settings));
3939
}
4040

41-
bool CatalogClient::cancelPendingRequests() {
41+
bool CatalogClient::CancelPendingRequests() {
4242
return impl_->CancelPendingRequests();
4343
}
4444

tests/integration/olp-cpp-sdk-dataservice-read/CatalogClientTest.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1915,7 +1915,7 @@ TEST_P(CatalogClientTest, DISABLED_CancelPendingRequestsCatalog) {
19151915
wait->get_future().get();
19161916
}
19171917
// Cancel them all
1918-
catalog_client->cancelPendingRequests();
1918+
catalog_client->CancelPendingRequests();
19191919
for (auto pause : pauses) {
19201920
pause->set_value();
19211921
}
@@ -2010,7 +2010,7 @@ TEST_P(CatalogClientTest, DISABLED_CancelPendingRequestsPartitions) {
20102010
}
20112011
std::cout << "done waitingg" << std::endl;
20122012
// Cancel them all
2013-
catalog_client->cancelPendingRequests();
2013+
catalog_client->CancelPendingRequests();
20142014
std::cout << "done cancelling" << std::endl;
20152015
for (auto pause : pauses) {
20162016
pause->set_value();

0 commit comments

Comments
 (0)