Add static task scheduler instance for stream writing tests.

This should temporary fix the issue when the task is capturing the last
reference to task scheduler.
This behavior will be fixed in the future.

Resolves: OLPEDGE-962

Signed-off-by: Mykhailo Kuchma <[email protected]>

Author: mykhailo-kuchma

tests/functional/olp-cpp-sdk-dataservice-write/DataserviceWriteStreamLayerClientCacheTest.cpp

@@ -95,6 +95,8 @@ class DataserviceWriteStreamLayerClientCacheTest : public ::testing::Test {
   static void SetUpTestSuite() {
     s_network = olp::client::OlpClientSettingsFactory::
         CreateDefaultNetworkRequestHandler();
+    s_task_scheduler =
+        olp::client::OlpClientSettingsFactory::CreateDefaultTaskScheduler(1u);
   }
 
   virtual void SetUp() override {
@@ -145,8 +147,7 @@ class DataserviceWriteStreamLayerClientCacheTest : public ::testing::Test {
     olp::client::OlpClientSettings settings;
     settings.authentication_settings = auth_client_settings;
     settings.network_request_handler = network;
-    settings.task_scheduler =
-        olp::client::OlpClientSettingsFactory::CreateDefaultTaskScheduler(1u);
+    settings.task_scheduler = s_task_scheduler;
 
     disk_cache_ = std::make_shared<olp::cache::DefaultCache>();
     EXPECT_EQ(disk_cache_->Open(),
@@ -171,6 +172,7 @@ class DataserviceWriteStreamLayerClientCacheTest : public ::testing::Test {
 
  protected:
   static std::shared_ptr<olp::http::Network> s_network;
+  static std::shared_ptr<olp::thread::TaskScheduler> s_task_scheduler;
 
   std::shared_ptr<StreamLayerClient> client_;
   std::shared_ptr<std::vector<unsigned char>> data_;
@@ -185,6 +187,13 @@ class DataserviceWriteStreamLayerClientCacheTest : public ::testing::Test {
 std::shared_ptr<olp::http::Network>
     DataserviceWriteStreamLayerClientCacheTest::s_network;
 
+// Static network instance is necessary as it needs to outlive any created
+// clients. This is a known limitation as triggered send requests capture the
+// task_scheduler instance inside the callbacks, and it could happen that the
+// task is trying to destroy task scheduler, that will result in a crash.
+std::shared_ptr<olp::thread::TaskScheduler>
+    DataserviceWriteStreamLayerClientCacheTest::s_task_scheduler;
+
 TEST_F(DataserviceWriteStreamLayerClientCacheTest, Queue) {
   auto error = client_->Queue(
       PublishDataRequest().WithData(data_).WithLayerId(GetTestLayer()));

tests/functional/olp-cpp-sdk-dataservice-write/DataserviceWriteStreamLayerClientTest.cpp

@@ -160,6 +160,8 @@ class DataserviceWriteStreamLayerClientTest : public ::testing::Test {
   static void SetUpTestSuite() {
     s_network = olp::client::OlpClientSettingsFactory::
         CreateDefaultNetworkRequestHandler();
+    s_task_scheduler =
+        olp::client::OlpClientSettingsFactory::CreateDefaultTaskScheduler(1u);
   }
 
   virtual std::shared_ptr<StreamLayerClient> CreateStreamLayerClient() {
@@ -181,8 +183,7 @@ class DataserviceWriteStreamLayerClientTest : public ::testing::Test {
     olp::client::OlpClientSettings settings;
     settings.authentication_settings = auth_client_settings;
     settings.network_request_handler = network;
-    settings.task_scheduler =
-        olp::client::OlpClientSettingsFactory::CreateDefaultTaskScheduler(1u);
+    settings.task_scheduler = s_task_scheduler;
 
     return std::make_shared<StreamLayerClient>(
         olp::client::HRN{GetTestCatalog()}, StreamLayerClientSettings{},
@@ -203,6 +204,7 @@ class DataserviceWriteStreamLayerClientTest : public ::testing::Test {
 
  protected:
   static std::shared_ptr<olp::http::Network> s_network;
+  static std::shared_ptr<olp::thread::TaskScheduler> s_task_scheduler;
 
   std::shared_ptr<StreamLayerClient> client_;
   std::shared_ptr<std::vector<unsigned char>> data_;
@@ -215,6 +217,13 @@ class DataserviceWriteStreamLayerClientTest : public ::testing::Test {
 std::shared_ptr<olp::http::Network>
     DataserviceWriteStreamLayerClientTest::s_network;
 
+// Static network instance is necessary as it needs to outlive any created
+// clients. This is a known limitation as triggered send requests capture the
+// task_scheduler instance inside the callbacks, and it could happen that the
+// task is trying to destroy task scheduler, that will result in a crash.
+std::shared_ptr<olp::thread::TaskScheduler>
+    DataserviceWriteStreamLayerClientTest::s_task_scheduler;
+
 TEST_F(DataserviceWriteStreamLayerClientTest, PublishData) {
   auto response =
       client_