Skip to content

Commit b0d21fe

Browse files
authored
Switch to RelWithDebInfo everywhere if possible (#1186)
This will help to catch a crash and see decoded stacktrace. Remove build.sh which is duplicate of scripts/ios/azure_ios_build_psv.sh Relates-To: OAM-1035 Signed-off-by: Yaroslav Stefinko <[email protected]>
1 parent 2264357 commit b0d21fe

File tree

4 files changed

+5
-34
lines changed

4 files changed

+5
-34
lines changed

scripts/android/build-test-emulator.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/bin/bash -ex
22
#
3-
# Copyright (C) 2020 HERE Europe B.V.
3+
# Copyright (C) 2020-2021 HERE Europe B.V.
44
#
55
# Licensed under the Apache License, Version 2.0 (the "License");
66
# you may not use this file except in compliance with the License.
@@ -34,7 +34,7 @@ mkdir -p build && cd build
3434
echo ""
3535
echo ""
3636
echo "*************** $VARIANT Build SDK for C++ ********** Start ***************"
37-
CMAKE_COMMAND="cmake .. -DCMAKE_TOOLCHAIN_FILE=$NDK_ROOT/build/cmake/android.toolchain.cmake \
37+
CMAKE_COMMAND="cmake .. -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_TOOLCHAIN_FILE=$NDK_ROOT/build/cmake/android.toolchain.cmake \
3838
-DANDROID_PLATFORM=android-$ANDROID_API -DANDROID_STL=c++_static -DANDROID_ABI=$ANDROID_ABI"
3939
BUILD_COMMAND="cmake --build . -- -j4"
4040

scripts/android/build.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ ls -la $ANDROID_NDK_HOME/platforms
3636

3737
mkdir -p build && cd build
3838
cmake .. -DCMAKE_TOOLCHAIN_FILE="$ANDROID_HOME/ndk/21.3.6528147/build/cmake/android.toolchain.cmake" \
39+
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
3940
-DANDROID_PLATFORM=android-28 \
4041
-DANDROID_ABI=arm64-v8a \
4142
-DANDROID_NDK="$ANDROID_HOME/ndk/21.3.6528147" \

scripts/ios/azure_ios_build_psv.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/bin/bash -e
22
#
3-
# Copyright (C) 2019 HERE Europe B.V.
3+
# Copyright (C) 2019-2021 HERE Europe B.V.
44
#
55
# Licensed under the Apache License, Version 2.0 (the "License");
66
# you may not use this file except in compliance with the License.
@@ -21,10 +21,10 @@
2121
mkdir -p build && cd build
2222
cmake ../ -GXcode \
2323
-DCMAKE_TOOLCHAIN_FILE=../cmake/toolchains/iOS.cmake \
24+
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
2425
-DPLATFORM=iphoneos \
2526
-DOLP_SDK_ENABLE_TESTING=NO \
2627
-DSIMULATOR=YES \
2728
-DOLP_SDK_BUILD_EXAMPLES=ON
2829

2930
xcodebuild
30-
cd ..

scripts/ios/build.sh

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)