Enable compiler warnings (#736)

Enable compiler warnings and treat them as errors:
 * unused parameters
 * unused functions

Updated the psv script to trigger an error on new warnings.

Relates-To: OLPEDGE-1728
Signed-off-by: Mykhailo Kuchma <[email protected]>

Author: mykhailo-kuchma

olp-cpp-sdk-core/src/client/OlpClient.cpp

@@ -328,7 +328,7 @@ CancellationToken OlpClient::CallApi(
     const std::string& path, const std::string& method,
     const OlpClient::ParametersType& query_params,
     const OlpClient::ParametersType& header_params,
-    const OlpClient::ParametersType& form_params,
+    const OlpClient::ParametersType& /*form_params*/,
     const OlpClient::RequestBodyType& post_body,
     const std::string& content_type,
     const NetworkAsyncCallback& callback) const {
@@ -368,7 +368,7 @@ CancellationToken OlpClient::CallApi(
 HttpResponse OlpClient::CallApi(std::string path, std::string method,
                                 OlpClient::ParametersType query_params,
                                 OlpClient::ParametersType header_params,
-                                OlpClient::ParametersType forms_params,
+                                OlpClient::ParametersType /*forms_params*/,
                                 OlpClient::RequestBodyType post_body,
                                 std::string content_type,
                                 CancellationContext context) const {

olp-cpp-sdk-core/src/http/curl/NetworkCurl.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019 HERE Europe B.V.
+ * Copyright (C) 2019-2020 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -61,28 +61,6 @@ namespace {
 
 const char* kLogTag = "CURL";
 
-std::vector<std::pair<std::string, std::string> > GetStatistics(
-    CURL* handle, std::size_t retryCount) {
-  std::vector<std::pair<std::string, std::string> > statistics;
-  double time;
-  curl_easy_getinfo(handle, CURLINFO_TOTAL_TIME, &time);
-  statistics.emplace_back("TotalTime", std::to_string(time));
-  curl_easy_getinfo(handle, CURLINFO_NAMELOOKUP_TIME, &time);
-  statistics.emplace_back("NameLookupTime", std::to_string(time));
-  curl_easy_getinfo(handle, CURLINFO_CONNECT_TIME, &time);
-  statistics.emplace_back("ConnectTime", std::to_string(time));
-  curl_easy_getinfo(handle, CURLINFO_APPCONNECT_TIME, &time);
-  statistics.emplace_back("AppConnectTime", std::to_string(time));
-  curl_easy_getinfo(handle, CURLINFO_PRETRANSFER_TIME, &time);
-  statistics.emplace_back("PreTransferTime", std::to_string(time));
-  curl_easy_getinfo(handle, CURLINFO_STARTTRANSFER_TIME, &time);
-  statistics.emplace_back("StartTransferTime", std::to_string(time));
-  curl_easy_getinfo(handle, CURLINFO_REDIRECT_TIME, &time);
-  statistics.emplace_back("RedirectTime", std::to_string(time));
-  statistics.emplace_back("Retries", std::to_string(retryCount));
-  return statistics;
-}
-
 #ifdef OLP_SDK_NETWORK_HAS_OPENSSL
 
 const auto curl_ca_bundle_name = "ca-bundle.crt";
@@ -179,24 +157,6 @@ int ConvertErrorCode(CURLcode curl_code) {
 }
 
 #ifdef OLP_SDK_NETWORK_HAS_OPENSSL
-// Lifetime of the mutex table is managed by NetworkCurl object.
-static std::mutex* gSslMutexes;
-
-void SslLockingFunction(int mode, int n, const char* file, int line) {
-  if (gSslMutexes) {
-    if (mode & CRYPTO_LOCK) {
-      gSslMutexes[n].lock();
-    } else {
-      gSslMutexes[n].unlock();
-    }
-  }
-}
-
-unsigned long SslIdFunction(void) {
-  std::hash<std::thread::id> hasher;
-  return static_cast<unsigned long>(hasher(std::this_thread::get_id()));
-}
-
 #ifdef NETWORK_USE_TIMEPROVIDER
 static curl_code SslctxFunction(CURL* curl, void* sslctx, void*) {
   // get the current time in seconds since epoch
@@ -467,7 +427,6 @@ ErrorCode NetworkCurl::SendImplementation(
   handle->transfer_timeout = config.GetTransferTimeout();
   handle->max_retries = config.GetRetries();
   handle->ignore_offset = false;   // request.IgnoreOffset();
-  handle->get_statistics = false;  // request.GetStatistics();
   handle->skip_content = false;    // config->SkipContentWhenError();
 
   for (const auto& header : request.GetHeaders()) {
@@ -691,7 +650,6 @@ NetworkCurl::RequestHandle* NetworkCurl::GetHandle(
       handle.body = std::move(body);
       handle.send_time = std::chrono::steady_clock::now();
       handle.error_text[0] = 0;
-      handle.get_statistics = false;
       handle.skip_content = false;
 
       return &handle;

olp-cpp-sdk-core/src/http/curl/NetworkCurl.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019 HERE Europe B.V.
+ * Copyright (C) 2019-2020 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -118,7 +118,6 @@ class NetworkCurl : public olp::http::Network,
     bool in_use{};
     bool range_out{};
     bool cancelled{};
-    bool get_statistics{};
     bool skip_content{};
     char error_text[CURL_ERROR_SIZE]{};
   };

olp-cpp-sdk-core/src/thread/ThreadPoolTaskScheduler.cpp

@@ -43,24 +43,20 @@ constexpr auto kLogTag = "ThreadPoolTaskScheduler";
 
 void SetCurrentThreadName(const std::string& thread_name) {
   // Currently only supported for pthread users
+  CORE_UNUSED(thread_name);
 
 #if defined(PORTING_PLATFORM_MAC)
   // Note that in Mac based systems the pthread_setname_np takes 1 argument
   // only.
   pthread_setname_np(thread_name.c_str());
-#elif defined(PORTING_PLATFORM_WINDOWS) || defined(PORTING_PLATFORM_EMSCRIPTEN)
-  // Unused
-  CORE_UNUSED(thread_name);
-#else  // Linux, Android, QNX
-#if defined(OLP_SDK_HAVE_PTHREAD_SETNAME_NP)
+#elif defined(OLP_SDK_HAVE_PTHREAD_SETNAME_NP) // Linux, Android, QNX
   // QNX allows 100 but Linux only 16 so select min value and apply for both.
   // If maximum length is exceeded on some systems, e.g. Linux, the name is not
   // set at all. So better truncate it to have at least the minimum set.
   constexpr size_t kMaxThreadNameLength = 16u;
   std::string truncated_name = thread_name.substr(0, kMaxThreadNameLength - 1);
   pthread_setname_np(pthread_self(), truncated_name.c_str());
 #endif  // OLP_SDK_HAVE_PTHREAD_SETNAME_NP
-#endif  // PORTING_PLATFORM_MAC
 }
 
 }  // namespace

olp-cpp-sdk-core/tests/cache/InMemoryCacheTest.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019 HERE Europe B.V.
+ * Copyright (C) 2019-2020 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -335,10 +335,10 @@ TEST(InMemoryCacheTest, CustomCost) {
   auto oversized_model = "value: " + oversized;
 
   struct MyCacheCost {
-    std::size_t operator()(const ItemTuple& s) const { return 2; }
+    std::size_t operator()(const ItemTuple&) const { return 2; }
   };
 
-  auto cost_func = [](const ItemTuple& tuple) { return 2; };
+  auto cost_func = [](const ItemTuple&) { return 2; };
 
   olp::cache::InMemoryCache cache(1, MyCacheCost());