Add support for non-copyable types in ApiResponse (#1343)

Add missing move constructors to the slicing and extending ApiResponse
class, it is required to support non-copyable response types.

Relates-To: OLPEDGE-2753

Signed-off-by: Mykhailo Kuchma <[email protected]>

Author: mykhailo-kuchma

olp-cpp-sdk-core/include/olp/core/client/ApiResponse.h

@@ -86,14 +86,39 @@ class ApiResponse : public ResponseExtension<Payload> {
    *
    * @param other The `ApiResponse` instance.
    */
-  template <typename P = Payload, typename = typename std::enable_if<
-                                      !std::is_same<P, void>::value>::type>
-  ApiResponse(const ApiResponse<Result, Error, void>& other)  // NOLINT
+  template <
+      typename P = Payload, typename R = Result,
+      typename = typename std::enable_if<!std::is_same<P, void>::value>::type,
+      typename =
+          typename std::enable_if<std::is_copy_constructible<R>::value>::type>
+  ApiResponse(const ApiResponse<R, Error, void>& other)  // NOLINT
       : ResponseExtension<P>(),
         result_(other.GetResult()),
         error_(other.GetError()),
         success_(other.IsSuccessful()) {}
 
+  /**
+   * @brief Creates the `ApiResponse` instance from a similar response type
+   * without payload. The payload is default initialized.
+   *
+   * @note Enabled only for the use cases when the input response type has no
+   * payload.
+   *
+   * Used for moving the successfully executed request.
+   *
+   * @param other The `ApiResponse` instance.
+   */
+  template <
+      typename P = Payload, typename R = Result,
+      typename = typename std::enable_if<!std::is_same<P, void>::value>::type,
+      typename =
+          typename std::enable_if<std::is_move_constructible<R>::value>::type>
+  ApiResponse(ApiResponse<R, Error, void>&& other)  // NOLINT
+      : ResponseExtension<P>(),
+        result_(other.MoveResult()),
+        error_(other.GetError()),
+        success_(other.IsSuccessful()) {}
+
   /**
    * @brief Creates the `ApiResponse` instance from a similar response type
    * without payload, and a separate payload.
@@ -126,14 +151,38 @@ class ApiResponse : public ResponseExtension<Payload> {
    * @param other The `ApiResponse` instance.
    */
   template <
-      typename U, typename P = Payload,
-      typename = typename std::enable_if<std::is_same<P, void>::value>::type>
-  ApiResponse(const ApiResponse<Result, Error, U>& other)
+      typename U, typename P = Payload, typename R = Result,
+      typename = typename std::enable_if<std::is_same<P, void>::value>::type,
+      typename =
+          typename std::enable_if<std::is_copy_constructible<R>::value>::type>
+  ApiResponse(const ApiResponse<R, Error, U>& other)
       : ResponseExtension<P>(),
         result_(other.GetResult()),
         error_(other.GetError()),
         success_(other.IsSuccessful()) {}
 
+  /**
+   * @brief Creates the `ApiResponse` instance from a similar request with a
+   * payload.
+   *
+   * @note Enabled only for the use cases when the input with a payload is
+   * sliced to the response without payload.
+   *
+   * Used for moving the successfully executed request.
+   *
+   * @param other The `ApiResponse` instance.
+   */
+  template <
+      typename U, typename P = Payload, typename R = Result,
+      typename = typename std::enable_if<std::is_same<P, void>::value>::type,
+      typename =
+          typename std::enable_if<std::is_move_constructible<R>::value>::type>
+  ApiResponse(ApiResponse<R, Error, U>&& other)
+      : ResponseExtension<P>(),
+        result_(other.MoveResult()),
+        error_(other.GetError()),
+        success_(other.IsSuccessful()) {}
+
   /**
    * @brief Creates the `ApiResponse` instance.
    *

olp-cpp-sdk-core/tests/client/ApiResponseTest.cpp

@@ -117,12 +117,20 @@ TEST(ApiResponseTest, ResponseExtention) {
 }
 
 TEST(ApiResponseTest, ResultWithoutCopyCtor) {
-  using ProvateResponse = ApiResponse<PrivateClass, ErrorType, PayloadT>;
+  using PrivateResponse = ApiResponse<PrivateClass, ErrorType>;
+  using ExtendedPrivateResponse =
+      ApiResponse<PrivateClass, ErrorType, PayloadT>;
   // move constructed
-  ProvateResponse response_1(PrivateClass(1));
+  ExtendedPrivateResponse response_1(PrivateClass(1));
   // move asigned
-  ProvateResponse response_2 = PrivateClass(1);
+  ExtendedPrivateResponse response_2 = PrivateClass(1);
   // response can be moved
-  ProvateResponse response_3 = std::move(response_2);
+  ExtendedPrivateResponse response_3 = std::move(response_2);
+  // no payload
+  PrivateResponse response_4(PrivateClass(1));
+  // extended
+  ExtendedPrivateResponse response_5(std::move(response_4));
+  // sliced
+  PrivateResponse response_6(std::move(response_5));
 }
 }  // namespace