Remove deprecated disk_path (#707)

Relates-To: OLPEDGE-1662

Signed-off-by: Mykhailo Kuchma <[email protected]>

Author: mykhailo-kuchma

olp-cpp-sdk-core/include/olp/core/cache/CacheSettings.h

@@ -40,17 +40,6 @@ enum OpenOptions : unsigned char {
  * @brief Settings for in-memory and on-disk caching.
  */
 struct CacheSettings {
-  /**
-   * @brief The path to the on-disk cache.
-   *
-   * If this parameter is not set, the downloaded data is stored
-   * only in the in-memory cache that is limited by `#max_memory_cache_size`.
-   *
-   * @deprecated Use #disk_path_mutable instead.
-   */
-  OLP_SDK_DEPRECATED("Use disk_path_mutable instead. Will be removed 03.2020")
-  boost::optional<std::string> disk_path = boost::none;
-
   /**
    * @brief The path to the mutable (read-write) on-disk cache where
    * the SDK caches and lookups the content.

olp-cpp-sdk-core/src/cache/DefaultCache.cpp

@@ -19,11 +19,7 @@
 
 #include "olp/core/porting/warning_disable.h"
 
-PORTING_PUSH_WARNINGS()
-PORTING_CLANG_GCC_DISABLE_WARNING("-Wdeprecated-declarations")
-// Generated class methods use a deprecated field and generate warning
 #include "olp/core/cache/DefaultCache.h"
-PORTING_POP_WARNINGS()
 
 #include "DiskCache.h"
 #include "InMemoryCache.h"
@@ -64,16 +60,6 @@ bool StoreExpiry(const std::string& key, olp::cache::DiskCache& disk_cache,
                      olp::cache::InMemoryCache::DefaultTimeProvider()()));
 }
 
-void ValidateDiskPath(olp::cache::CacheSettings& settings) {
-  if (!settings.disk_path_mutable) {
-    PORTING_PUSH_WARNINGS()
-    PORTING_CLANG_GCC_DISABLE_WARNING("-Wdeprecated-declarations")
-    PORTING_MSVC_DISABLE_WARNINGS(4996)
-    settings.disk_path_mutable = settings.disk_path;
-    PORTING_POP_WARNINGS()
-  }
-}
-
 }  // namespace
 
 namespace olp {
@@ -295,9 +281,6 @@ DefaultCache::StorageOpenResult DefaultCache::SetupStorage() {
     memory_cache_.reset(new InMemoryCache(settings_.max_memory_cache_size));
   }
 
-  // Temporary code for backwards compatibility.
-  ValidateDiskPath(settings_);
-
   if (settings_.disk_path_mutable) {
     StorageSettings storage_settings;
     storage_settings.max_disk_storage = settings_.max_disk_storage;