Fix flaky test SyncQueueTest.ConcurrentUsage (#744)

meravingen123 · web-flow · commit e3512c4f4636 · 2020-03-27T17:07:17.000+03:00
Fix for flaky test SyncQueueTest.ConcurrentUsage which was failed due
to SyncQueue emptiness check that could be true before all tasks were
actually complete.

Resolves: OLPEDGE-1713

Signed-off-by: Serhii Lozynskyi &lt;ext-serhii.lozynskyi@here.com&gt;
diff --git a/olp-cpp-sdk-core/tests/thread/SyncQueueTest.cpp b/olp-cpp-sdk-core/tests/thread/SyncQueueTest.cpp
@@ -197,7 +197,7 @@ TEST(SyncQueueTest, ConcurrentUsage) {
                1000u;
   };
 
-  while (!sync_queue.Empty() && check_condition()) {
+  while (check_condition()) {
     std::this_thread::sleep_for(kSleep / 3);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ TEST(SyncQueueTest, ConcurrentUsage) {`
`197`	`197`	`1000u;`
`198`	`198`	`};`
`199`	`199`
`200`		`- while (!sync_queue.Empty() && check_condition()) {`
	`200`	`+ while (check_condition()) {`
`201`	`201`	`std::this_thread::sleep_for(kSleep / 3);`
`202`	`202`	`}`
`203`	`203`