Skip to content

Commit f098e07

Browse files
authored
Fix Doxygen warnings (#1270)
Add API doc to omit Doxygen errors. Relates-To: OLPESGE-731 Signed-off-by: Halyna Dumych <[email protected]>
1 parent 9f9ef8a commit f098e07

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+789
-244
lines changed

olp-cpp-sdk-authentication/include/olp/authentication/AuthenticationClient.h

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,10 +286,16 @@ class AUTHENTICATION_API AuthenticationClient {
286286
explicit AuthenticationClient(AuthenticationSettings settings);
287287
virtual ~AuthenticationClient();
288288

289-
// Non-copyable but movable
289+
/// A copy constructor.
290290
AuthenticationClient(const AuthenticationClient&) = delete;
291+
292+
/// A copy assignment operator.
291293
AuthenticationClient& operator=(const AuthenticationClient&) = delete;
294+
295+
/// A default move constructor.
292296
AuthenticationClient(AuthenticationClient&&) noexcept;
297+
298+
/// A move assignment operator.
293299
AuthenticationClient& operator=(AuthenticationClient&&) noexcept;
294300

295301
/**
@@ -437,7 +443,7 @@ class AUTHENTICATION_API AuthenticationClient {
437443
* @brief Signs in with your valid Apple token and requests your user access
438444
* token.
439445
*
440-
* @param sign_in_properties The `AppleSignInProperties` instance.
446+
* @param properties The `AppleSignInProperties` instance.
441447
* @param callback The `SignInUserCallback` method that is called when
442448
* the user sign-in request is completed. If successful, the returned HTTP
443449
* status is 200. If a new account is created as a part of the sign-in

olp-cpp-sdk-authentication/include/olp/authentication/AuthenticationError.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ namespace authentication {
3131
* @brief Contains information on the authentication error.
3232
*
3333
* You can get the following information on the authentication error: the error
34-
* code ( \ref GetErrorCode ) and error message ( \ref GetMessage ).
34+
* code (`GetErrorCode`) and error message (`GetMessage`).
3535
*
3636
* @deprecated Will be removed by 12.2020. Use `client::ApiError` instead.
3737
*/

olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeRequest.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ namespace authentication {
4747
class AUTHENTICATION_API AuthorizeRequest final {
4848
public:
4949
/**
50-
* @brief The type alias for the action pair.
50+
* @brief An alias for the action pair.
5151
*
5252
* The first parameter is the type of action.
5353
* The second one is optional and represents the resource.
@@ -58,7 +58,7 @@ class AUTHENTICATION_API AuthorizeRequest final {
5858
using Action = std::pair<std::string, std::string>;
5959

6060
/**
61-
* @brief The type alias for the vector of actions.
61+
* @brief An alias for the vector of actions.
6262
*/
6363
using Actions = std::vector<Action>;
6464

olp-cpp-sdk-authentication/include/olp/authentication/AuthorizeResult.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class AUTHENTICATION_API Permission {
4141
/**
4242
* @brief Sets the action associated with the resource.
4343
*
44-
* @param The action to associate with.
44+
* @param action The action to associate with.
4545
*/
4646
void SetAction(std::string action) { action_ = std::move(action); }
4747

@@ -55,7 +55,7 @@ class AUTHENTICATION_API Permission {
5555
/**
5656
* @brief Sets the resource with which the action and decision are associated.
5757
*
58-
* @param The resource to associate with the decision and action.
58+
* @param resource The resource to associate with the decision and action.
5959
*/
6060
void SetResource(std::string resource) { resource_ = std::move(resource); }
6161

@@ -69,7 +69,7 @@ class AUTHENTICATION_API Permission {
6969
/**
7070
* @brief Sets the decision associated with the resource.
7171
*
72-
* @param The decision to associate with the resource.
72+
* @param decision The decision to associate with the resource.
7373
*/
7474
void SetDecision(DecisionType decision) { decision_ = decision; }
7575

@@ -107,7 +107,7 @@ class AUTHENTICATION_API ActionResult {
107107
/**
108108
* @brief Sets the policy decision.
109109
*
110-
* @param The policy decision.
110+
* @param decision The policy decision.
111111
*/
112112
void SetDecision(DecisionType decision) { decision_ = decision; }
113113

@@ -179,7 +179,7 @@ class AUTHENTICATION_API AuthorizeResult {
179179
/**
180180
* @brief Sets the client ID.
181181
*
182-
* @param The client ID.
182+
* @param client_id The client ID.
183183
*/
184184
void SetClientId(std::string client_id) { client_id_ = std::move(client_id); }
185185

olp-cpp-sdk-authentication/include/olp/authentication/AutoRefreshingToken.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ class AUTHENTICATION_API OLP_SDK_DEPRECATED("Will be removed by 10.2020.")
6565
* If no token has been retrieved yet or the current token is expired or
6666
* expires within five minutes, a new token is requested. Otherwise,
6767
* the cached token is returned. This method is thread-safe.
68+
*
6869
* @note This method is blocked when a new token needs to be retrieved.
6970
* Therefore, the token should not be called from a time-sensitive thread (for
7071
* example, the UI thread).

olp-cpp-sdk-authentication/include/olp/authentication/Crypto.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,13 @@
2828
namespace olp {
2929
namespace authentication {
3030

31-
/**
32-
* @brief Crypto class exposes the cryptographic algoritms used by the library.
33-
*/
31+
/// The cryptographic algoritms used by the library.
3432
class AUTHENTICATION_API Crypto {
3533
public:
34+
/// The hash length after the SHA-256 encryption.
3635
static const size_t Sha256DigestLength = 32;
36+
37+
/// An alias for the hash.
3738
using Sha256Digest = std::array<unsigned char, Sha256DigestLength>;
3839

3940
/**

olp-cpp-sdk-authentication/include/olp/authentication/TokenProvider.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,16 @@ class TokenProvider {
6565
: impl_(std::make_shared<TokenProviderImpl>(
6666
std::move(settings), std::chrono::seconds(MinimumValidity))) {}
6767

68-
// Default copyable, default movable.
68+
/// A default copy constructor.
6969
TokenProvider(const TokenProvider& other) = default;
70+
71+
/// A default move constructor.
7072
TokenProvider(TokenProvider&& other) noexcept = default;
73+
74+
/// A default copy assignment operator.
7175
TokenProvider& operator=(const TokenProvider& other) = default;
76+
77+
/// A default move assignment operator.
7278
TokenProvider& operator=(TokenProvider&& other) noexcept = default;
7379

7480
/**

olp-cpp-sdk-authentication/include/olp/authentication/TokenRequest.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ class AUTHENTICATION_API OLP_SDK_DEPRECATED("Will be removed in 10.2020")
3636
public:
3737
/**
3838
* @brief Creates the `TokenRequest` instance.
39-
* @param expiresIn (Optional) The number of seconds left before the new
39+
*
40+
* @param expires_in (Optional) The number of seconds left before the new
4041
* access token expires.
4142
*/
4243
TokenRequest(

olp-cpp-sdk-authentication/include/olp/authentication/TokenResult.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ namespace authentication {
3434
* @brief A parsed response received from the OAuth2.0 token endpoint.
3535
*
3636
* You can get the following information: the access token issued by
37-
* the authorization server ( \ref GetAccessToken ), its expiry time
38-
* ( \ref GetExpiryTime ), HTTP status code ( \ref GetHttpStatus ),
39-
* and error description ( \ref GetErrorResponse ) in case of a failure.
37+
* the authorization server (`GetAccessToken`), its expiry time
38+
* (`GetExpiryTime`), HTTP status code (`GetHttpStatus`),
39+
* and error description (`GetErrorResponse`) in case of a failure.
4040
*/
4141
class AUTHENTICATION_API TokenResult {
4242
public:

olp-cpp-sdk-authentication/include/olp/authentication/UserAccountInfoResponse.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ class AUTHENTICATION_API UserAccountInfoResponse {
263263
* @brief Sets the timestamp (milliseconds since the Unix epoch) of when
264264
* the account was created.
265265
*
266-
* @param time The epoch time when the account was created.
266+
* @param created_time The epoch time when the account was created.
267267
*/
268268
void SetCreatedTime(time_t created_time) { created_time_ = created_time; }
269269

0 commit comments

Comments
 (0)