Skip to content

Commit 2a5da09

Browse files
author
Jakub Amanowicz
committed
marked more TODOs for CASL-784
Signed-off-by: Jakub Amanowicz <jakub.amanowicz@here.com>
1 parent caf311e commit 2a5da09

File tree

3 files changed

+15
-9
lines changed

3 files changed

+15
-9
lines changed

here-naksha-app-service/src/main/java/com/here/naksha/app/service/http/ops/PropertySearchUtil.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
///*
1+
// TODO: cleanup as part of CASL-784
2+
//*
23
// * Copyright (C) 2017-2024 HERE Europe B.V.
34
// *
45
// * Licensed under the Apache License, Version 2.0 (the "License");
Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
1-
package com.here.naksha.lib.core.util;
2-
3-
import com.here.naksha.lib.core.util.storage.RequestHelper;
4-
5-
public class RequestHelperTest {
6-
7-
//TODO(lib-core test) see if this test is still relevant now that PRef is no longer available (replaced with Property?)
1+
// TODO: clean up as part of CASL-784
2+
// see if this test is still relevant now that PRef is no longer available (replaced with Property?)
3+
//
4+
//package com.here.naksha.lib.core.util;
5+
//
6+
//import com.here.naksha.lib.core.util.storage.RequestHelper;
7+
//
8+
//public class RequestHelperTest {
9+
//
10+
//
811
// @Test
912
// public void testPRefFromStandardPath() {
1013
// final PRef pref = RequestHelper.pRefFromPropPath(new String[]{"properties","@ns:com:here:xyz","tags"});
@@ -18,4 +21,4 @@ public class RequestHelperTest {
1821
// assertNotNull(pref);
1922
// assertTrue(pref instanceof NON_INDEXED_PREF, "Must be instanceof NonIndexedPRef");
2023
// }
21-
}
24+
//}

here-naksha-lib-model/src/jvmMain/java/naksha/model/util/RequestHelper.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,8 @@ private RequestHelper() {}
203203
// return ProxyGeoUtil.toJtsMultiPoint(multiPoint);
204204
// }
205205

206+
// TODO: cleanup as part of CASL-784
207+
//
206208
// /**
207209
// * Helper function that returns instance of PRef or NonIndexedPRef depending on
208210
// * whether the propPath provided matches with standard (indexed) property search or not.

0 commit comments

Comments
 (0)