[DRAFT] Make VoidType a unit type #872
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives makes
VoidTypea unit type with a single valueunit.This allows for a uniform treatment (and thus less code) of function calls with return value and without return values.
In fact, there are no functions without return values anymore, a void function returns the unit value. The class
VoidFunctionCallbecomes obsolete.The callsite now has to assign the return value to a register of void type:
Issues/Possible TODOs:
_is fine, but it might not be for SPIRV?VoidTypetoUnitType, or even replace it entirely by an empty aggregate type.VoidTypeif we want to use it as a proper unit type.Now thatVoidFunctionCallis gone, we can mergeValueFunctionCallinto the base classFunctionCall.