Skip to content

Commit 78d1582

Browse files
chore: resolve devcenter articles (#3573)
* updating ownership doc link and removing deprecated free tier condition doc * updating test references for article * updating the unit test for dev center article * updating the link to be the pipeline page for ownership
1 parent f0b17c0 commit 78d1582

File tree

3 files changed

+8
-20
lines changed

3 files changed

+8
-20
lines changed

src/commands/ps/index.ts

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ function printExtended(dynos: DynoExtended[]) {
8686
}
8787

8888
async function printAccountQuota(heroku: APIClient, app: AppProcessTier, account: Account) {
89-
if (app.process_tier !== 'free' && app.process_tier !== 'eco') {
89+
if (app.process_tier !== 'eco') {
9090
return
9191
}
9292

@@ -116,21 +116,11 @@ async function printAccountQuota(heroku: APIClient, app: AppProcessTier, account
116116
const appHours = Math.floor(appQuotaUsed / 60)
117117
const appMinutes = Math.floor(appQuotaUsed % 60)
118118

119-
if (app.process_tier === 'eco') {
120-
ux.stdout(`Eco dyno hours quota remaining this month: ${hours}h ${minutes}m (${percentage}%)`)
121-
ux.stdout(`Eco dyno usage for this app: ${appHours}h ${appMinutes}m (${appPercentage}%)`)
122-
ux.stdout('For more information on Eco dyno hours, see:')
123-
ux.stdout(color.info('https://devcenter.heroku.com/articles/eco-dyno-hours'))
124-
ux.stdout()
125-
}
126-
127-
if (app.process_tier === 'free') {
128-
ux.stdout(`Free dyno hours quota remaining this month: ${hours}h ${minutes}m (${percentage}%)`)
129-
ux.stdout(`Free dyno usage for this app: ${appHours}h ${appMinutes}m (${appPercentage}%)`)
130-
ux.stdout('For more information on dyno sleeping and how to upgrade, see:')
131-
ux.stdout(color.info('https://devcenter.heroku.com/articles/dyno-sleeping'))
132-
ux.stdout()
133-
}
119+
ux.stdout(`Eco dyno hours quota remaining this month: ${hours}h ${minutes}m (${percentage}%)`)
120+
ux.stdout(`Eco dyno usage for this app: ${appHours}h ${appMinutes}m (${appPercentage}%)`)
121+
ux.stdout('For more information on Eco dyno hours, see:')
122+
ux.stdout(color.info('https://devcenter.heroku.com/articles/eco-dyno-hours'))
123+
ux.stdout()
134124
}
135125

136126
function decorateOneOffDyno(dyno: DynoExtended) : string {

src/lib/pipelines/ownership.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export function warnMixedOwnership(pipelineApps: Array<AppWithPipelineCoupling>,
1313
let message = `Some apps in this pipeline do not belong to ${color.team(owner)}.`
1414
message += '\n\nAll apps in a pipeline must have the same owner as the pipeline owner.'
1515
message += '\nTransfer these apps or change the pipeline owner in pipeline settings.'
16-
message += `\nSee ${color.info('https://devcenter.heroku.com/articles/pipeline-ownership-transition')} for more info.`
16+
message += `\nSee ${color.info('https://devcenter.heroku.com/articles/pipelines')} for more info.`
1717
ux.warn(message)
1818
}
1919
}

test/unit/commands/pipelines/info.unit.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,8 @@ describe('pipelines:info', function () {
103103
`Warning: Some apps in this pipeline do not belong to ${owner}.`,
104104
'All apps in a pipeline must have the same owner as the pipeline owner.',
105105
'Transfer these apps or change the pipeline owner in pipeline settings.',
106-
'See https://devcenter.heroku.com/articles/pipeline-ownership-transition',
107-
'for more info.',
106+
'See https://devcenter.heroku.com/articles/pipelines for more info.',
108107
]
109-
110108
warningMessage.forEach(message => {
111109
expect(stderr).to.contain(message)
112110
})

0 commit comments

Comments
 (0)