fix: address UI issues with confirmation prompts on multiple commands (W-21649376) (#3602)

Fixing UI issue with confirmation prompt

Author: sbosio

src/commands/addons/attach.ts

@@ -1,6 +1,6 @@
-import {color} from '@heroku/heroku-cli-util'
 import {Command, flags} from '@heroku-cli/command'
 import * as Heroku from '@heroku-cli/schema'
+import {color} from '@heroku/heroku-cli-util'
 import {Args, ux} from '@oclif/core'
 
 import {trapConfirmationRequired} from '../../lib/addons/util.js'
@@ -36,10 +36,16 @@ export default class Attach extends Command {
         addon: {name: addon.name}, app: {name: app}, confirm: confirmed, name: as, namespace,
       }
 
-      ux.action.start(`Attaching ${credential ? color.name(credential) + ' of ' : ''}${color.datastore(addon.name || '')}${as ? ' as ' + color.attachment(as) : ''} to ${color.app(app)}`)
-      const {body: attachments} = await this.heroku.post<Heroku.AddOnAttachment>('/addon-attachments', {body})
-      ux.action.stop()
-      return attachments
+      try {
+        ux.action.start(`Attaching ${credential ? color.name(credential) + ' of ' : ''}${color.datastore(addon.name || '')}${as ? ' as ' + color.attachment(as) : ''} to ${color.app(app)}`)
+        const {body: attachment} = await this.heroku.post<Heroku.AddOnAttachment>('/addon-attachments', {body})
+        ux.action.stop()
+
+        return attachment
+      } catch (error: unknown) {
+        ux.action.stop(color.red('!'))
+        throw error
+      }
     }
 
     if (credential && credential !== 'default') {

src/lib/addons/create_addon.ts

@@ -1,6 +1,6 @@
-import {color, utils} from '@heroku/heroku-cli-util'
 import {APIClient} from '@heroku-cli/command'
 import * as Heroku from '@heroku-cli/schema'
+import {color, utils} from '@heroku/heroku-cli-util'
 import {ux} from '@oclif/core'
 
 import {waitForAddonProvisioning} from './addons_wait.js'
@@ -40,18 +40,22 @@ export default async function (
       plan: {name: plan},
     }
 
-    ux.action.start(options.actionStartMessage || `Creating ${plan} on ${color.app(app)}`)
-    const {body: addon} = await heroku.post<Heroku.AddOn>(`/apps/${app}/addons`, {
-      body,
-      headers: {
-        'accept-expansion': 'plan',
-        'x-heroku-legacy-provider-messages': 'true',
-      },
-    })
+    try {
+      ux.action.start(options.actionStartMessage || `Creating ${plan} on ${color.app(app)}`)
+      const {body: addon} = await heroku.post<Heroku.AddOn>(`/apps/${app}/addons`, {
+        body,
+        headers: {
+          'accept-expansion': 'plan',
+          'x-heroku-legacy-provider-messages': 'true',
+        },
+      })
+      ux.action.stop(options.actionStopMessage || color.green(util.formatPriceText(addon.plan?.price || '')))
 
-    ux.action.stop(options.actionStopMessage || color.green(util.formatPriceText(addon.plan?.price || '')))
-
-    return addon
+      return addon
+    } catch (error: unknown) {
+      ux.action.stop(color.red('!'))
+      throw error
+    }
   }
 
   let addon = await util.trapConfirmationRequired<Heroku.AddOn>(app, confirm, confirm => (createAddonRequest(confirm)))