perf: improve Windows CLI performance (#3610)

* perf: optimize Windows startup time by skipping telemetry by default

Improves Windows CLI startup performance by skipping telemetry loading:
- Skip telemetry module loading on Windows unless ENABLE_WINDOWS_TELEMETRY=true
- Use dynamic imports for telemetry in all hooks to avoid loading on Windows
- Add performance tracking support via DEBUG=oclif:perf or DEBUG=*

Changes:
- bin/run: Skip telemetry on Windows, enable performance tracking
- All analytics hooks: Use dynamic imports and check ENABLE_WINDOWS_TELEMETRY

Performance impact:
- Reduces Windows startup from ~8s to ~6s (testing showed further improvements expected)
- Eliminates loading of OpenTelemetry/Sentry modules on Windows
- No impact on non-Windows platforms

Testing:
- Set ENABLE_WINDOWS_TELEMETRY=true on Windows to enable telemetry when needed
- Use DEBUG=oclif:perf or DEBUG=* to see detailed performance metrics

* perf: implement lazy initialization in global_telemetry.ts

Refactor telemetry initialization to eliminate blocking module load and
reduce Windows performance impact.

Key changes:
- Remove top-level await that blocks module loading on every command
- Defer Sentry.init(), registerInstrumentations(), and OTEL setup until
  first use via ensureInitialized() pattern
- Eliminate package.json file read by using config.version from oclif
  Config object (already loaded during CLI bootstrap)
- Add early return in initializeInstrumentation() when DISABLE_TELEMETRY=true
- Add getProcessor() getter for backward compatibility

Performance impact:
- Removes ~1-2ms of blocking I/O on macOS
- Expected to save 500ms-2s on Windows where file I/O is 2-3x slower
  and antivirus scanning impacts every file read
- Combined with dynamic imports, significantly reduces Windows startup time

Technical details:
- config.version = config.options.version || config.pjson.version || '0.0.0'
- setupTelemetry() stores config.version on first call (during init hook)
- ensureInitialized() called from initializeInstrumentation(), sendToHoneycomb(),
  and sendToSentry() to ensure setup happens before use
- All initialization respects isTelemetryDisabled flag

* perf: avoid redundant package.json read in init/version hook

Use already-loaded config.pjson instead of reading package.json from disk
again via packageParser.

Changes:
- Remove import of getAllVersionFlags() from packageParser
- Get version flags directly from this.config.pjson.oclif.additionalVersionFlags
- Build the flags list in memory instead of triggering a file read

Performance impact:
- Eliminates 654ms file read on Windows (seen in performance testing)
- No disk I/O since oclif already loaded package.json into config.pjson
- Hook functionality remains identical

* chore: remove unused packageParser.ts

Remove packageParser.ts as it's no longer used after optimizing the
init/version hook to use config.pjson directly.

The file was only imported by init/version hook which now gets version
flags from this.config.pjson.oclif.additionalVersionFlags instead of
reading package.json from disk.

* deps: update @heroku/heroku-cli-util to 10.7.0 with granular imports

Update @heroku/heroku-cli-util from 10.6.1 to 10.7.0 which introduces
granular import paths for better tree-shaking and module loading performance.

Changes:
- Update package.json dependency to ^10.7.0
- Migrate all imports from barrel exports to granular paths:
  - import {color} from '@heroku/heroku-cli-util'
    → import * as color from '@heroku/heroku-cli-util/color'
  - Similar changes for prompt, confirm, action, table, etc.

This change improves module loading performance by allowing bundlers
to load only the specific modules needed rather than the entire package.

* linting fixes

* perf: make SIGINT/SIGTERM telemetry fire-and-forget

Convert signal handlers from async/await to fire-and-forget to improve exit responsiveness.

Changes:
- Remove async from SIGINT/SIGTERM handlers
- Remove await before sendTelemetry() calls
- Add .catch(() => {}) to suppress unhandled promise rejections
- Call process.exit(1) immediately without blocking

Benefits:
- Immediate exit when user hits Ctrl+C (no blocking wait)
- Better UX - responsive termination behavior
- Telemetry send initiated but doesn't delay exit
- Normal command completions still captured via beforeExit handler

* switch to modular imports for some hooks files

* perf: implement lazy initialization in colorize.ts

Move color pre-assignment from module load time to first use via ensureInitialized().

Changes:
- Add ensureInitialized() function to lazily assign colors
- Call ensureInitialized() in getColorForIdentifier() before any color lookups
- Remove module-load-time side effects (pre-assignment calls)

Benefits:
- Eliminates side effects at import time
- Same behavior - common identifiers still get consistent colors
- Defers work until actually needed
- Better for module loading performance

* refactor: improve Windows performance

- Rename bin/run to bin/run.js with symlink for compatibility
- Add --no-deprecation flag to suppress Node.js warnings
- Update bin/run.cmd to reference run.js directly
- Change terms-of-service hook to use async file I/O instead of sync

* remove spaces test. we don't want to keep spaces around just for smoke
tests.

* restore intended display order for pipelines dif

Author: eablack

bin/run

@@ -0,0 +1 @@
+run.js

bin/run

@@ -1,3 +1,3 @@
 @echo off
 
-node "%~dp0\run" %*
+node "%~dp0\run.js" %*

bin/run.cmd

@@ -0,0 +1,69 @@
+#!/usr/bin/env -S node --no-deprecation
+/* eslint-disable n/no-process-exit */
+/* eslint-disable n/no-unpublished-bin */
+
+import {execute, settings} from '@oclif/core'
+
+// Enable performance tracking when DEBUG=oclif:perf or DEBUG=* is set
+if (process.env.DEBUG?.includes('oclif:perf') || process.env.DEBUG === '*') {
+  settings.performanceEnabled = true
+}
+
+process.env.HEROKU_UPDATE_INSTRUCTIONS = process.env.HEROKU_UPDATE_INSTRUCTIONS || 'update with: "npm update -g heroku"'
+
+const now = new Date()
+const cliStartTime = now.getTime()
+
+// Skip telemetry entirely on Windows for performance (unless explicitly enabled)
+const enableTelemetry = process.platform !== 'win32' || process.env.ENABLE_WINDOWS_TELEMETRY === 'true'
+let globalTelemetry
+
+if (enableTelemetry) {
+  // Dynamically import telemetry only when needed
+  globalTelemetry = await import('../dist/global_telemetry.js')
+}
+
+process.once('beforeExit', async code => {
+  if (!enableTelemetry) return
+
+  // capture as successful exit
+  if (global.cliTelemetry) {
+    if (global.cliTelemetry.isVersionOrHelp) {
+      const cmdStartTime = global.cliTelemetry.commandRunDuration
+      global.cliTelemetry.commandRunDuration = globalTelemetry.computeDuration(cmdStartTime)
+    }
+
+    global.cliTelemetry.exitCode = code
+    global.cliTelemetry.cliRunDuration = globalTelemetry.computeDuration(cliStartTime)
+    const telemetryData = global.cliTelemetry
+    await globalTelemetry.sendTelemetry(telemetryData)
+  }
+})
+
+process.on('SIGINT', () => {
+  if (enableTelemetry) {
+    // Fire-and-forget: attempt to send telemetry but don't block exit
+    const error = new Error('Received SIGINT')
+    error.cliRunDuration = globalTelemetry.computeDuration(cliStartTime)
+    globalTelemetry.sendTelemetry(error).catch(() => {})
+  }
+
+  process.exit(1)
+})
+
+process.on('SIGTERM', () => {
+  if (enableTelemetry) {
+    // Fire-and-forget: attempt to send telemetry but don't block exit
+    const error = new Error('Received SIGTERM')
+    error.cliRunDuration = globalTelemetry.computeDuration(cliStartTime)
+    globalTelemetry.sendTelemetry(error).catch(() => {})
+  }
+
+  process.exit(1)
+})
+
+if (enableTelemetry) {
+  globalTelemetry.initializeInstrumentation()
+}
+
+await execute({dir: import.meta.url})

bin/run.js

@@ -10,7 +10,7 @@
     "@heroku-cli/notifications": "^1.2.6",
     "@heroku-cli/schema": "^1.0.25",
     "@heroku/buildpack-registry": "^1.0.1",
-    "@heroku/heroku-cli-util": "^10.6.1",
+    "@heroku/heroku-cli-util": "^10.7.0",
     "@heroku/http-call": "^5.5.1",
     "@heroku/mcp-server": "^1.2.0",
     "@heroku/socksv5": "^0.0.9",

package-lock.json

@@ -59,7 +59,6 @@ declare -a COMMANDS=(
   "$CMD_BIN run -x -a heroku-cli-test-staging -- 'bash -c \"exit 0\"'"
   "$CMD_BIN run:detached \"echo 'Hello World'\" -a heroku-cli-test-staging"
   "$CMD_BIN sessions"
-  "$CMD_BIN spaces"
   "$CMD_BIN status"
   "$CMD_BIN teams"
   "$CMD_BIN version"

package.json

@@ -1,6 +1,6 @@
-import {color} from '@heroku/heroku-cli-util'
 import {Command, flags} from '@heroku-cli/command'
 import * as Heroku from '@heroku-cli/schema'
+import * as color from '@heroku/heroku-cli-util/color'
 import {Args, ux} from '@oclif/core'
 
 import {getOwner, isTeamApp} from '../../lib/teamUtils.js'

scripts/postrelease/test_release

@@ -1,24 +1,65 @@
-import {color, hux} from '@heroku/heroku-cli-util'
 import {Command, flags} from '@heroku-cli/command'
 import {HerokuAPIError} from '@heroku-cli/command/lib/api-client.js'
 import * as Heroku from '@heroku-cli/schema'
-import {ux} from '@oclif/core'
+import {color, hux} from '@heroku/heroku-cli-util'
+import {ux} from '@oclif/core/ux'
 import _ from 'lodash'
 
 import {getOwner, isTeamApp} from '../../lib/teamUtils.js'
 
+type AdminWithPermissions = Heroku.TeamMember & {
+  permissions?: Heroku.TeamAppPermission[],
+}
+
 type MemberData = {
   email: string,
   permissions?: string
   role: string,
 }
 
-type AdminWithPermissions = {
-  permissions?: Heroku.TeamAppPermission[],
-} & Heroku.TeamMember
+export default class AccessIndex extends Command {
+  static description = 'list who has access to an app'
+  static flags = {
+    app: flags.app({required: true}),
+    json: flags.boolean({description: 'output in json format'}),
+    remote: flags.remote({char: 'r'}),
+  }
 
-function printJSON(collaborators: Heroku.TeamAppCollaborator[]) {
-  ux.stdout(JSON.stringify(collaborators, null, 2))
+  static topic = 'access'
+
+  public async run(): Promise<void> {
+    const {flags} = await this.parse(AccessIndex)
+    const {app: appName, json} = flags
+    const {body: app} = await this.heroku.get<Heroku.App>(`/apps/${appName}`)
+    let {body: collaborators} = await this.heroku.get<Heroku.TeamAppCollaborator[]>(`/apps/${appName}/collaborators`)
+    if (isTeamApp(app.owner?.email)) {
+      const teamName = getOwner(app.owner?.email)
+      try {
+        const {body: members} = await this.heroku.get<Heroku.TeamMember[]>(`/teams/${teamName}/members`)
+        let admins: AdminWithPermissions[] = members.filter(member => member.role === 'admin')
+        const {body: adminPermissions} = await this.heroku.get<Heroku.TeamAppPermission[]>('/teams/permissions')
+        admins = _.forEach(admins, admin => {
+          admin.user = {email: admin.email}
+          admin.permissions = adminPermissions
+          return admin
+        })
+        collaborators = buildCollaboratorsArray(collaborators, admins)
+      } catch (error: any) {
+        if (!(error instanceof HerokuAPIError && error.http.statusCode === 403))
+          throw error
+      }
+    }
+
+    if (json)
+      printJSON(collaborators)
+    else
+      printAccess(app, collaborators)
+  }
+}
+
+function buildCollaboratorsArray(collaboratorsRaw: Heroku.TeamAppCollaborator[], admins: Heroku.TeamMember[]) {
+  const collaboratorsNoAdmins = _.reject(collaboratorsRaw, {role: 'admin'})
+  return _.union(collaboratorsNoAdmins, admins)
 }
 
 function buildTableColumns(showPermissions: boolean) {
@@ -65,47 +106,6 @@ function printAccess(app: Heroku.App, collaborators: any[]) {
   )
 }
 
-function buildCollaboratorsArray(collaboratorsRaw: Heroku.TeamAppCollaborator[], admins: Heroku.TeamMember[]) {
-  const collaboratorsNoAdmins = _.reject(collaboratorsRaw, {role: 'admin'})
-  return _.union(collaboratorsNoAdmins, admins)
-}
-
-export default class AccessIndex extends Command {
-  static description = 'list who has access to an app'
-  static flags = {
-    app: flags.app({required: true}),
-    json: flags.boolean({description: 'output in json format'}),
-    remote: flags.remote({char: 'r'}),
-  }
-
-  static topic = 'access'
-
-  public async run(): Promise<void> {
-    const {flags} = await this.parse(AccessIndex)
-    const {app: appName, json} = flags
-    const {body: app} = await this.heroku.get<Heroku.App>(`/apps/${appName}`)
-    let {body: collaborators} = await this.heroku.get<Heroku.TeamAppCollaborator[]>(`/apps/${appName}/collaborators`)
-    if (isTeamApp(app.owner?.email)) {
-      const teamName = getOwner(app.owner?.email)
-      try {
-        const {body: members} = await this.heroku.get<Heroku.TeamMember[]>(`/teams/${teamName}/members`)
-        let admins: AdminWithPermissions[] = members.filter(member => member.role === 'admin')
-        const {body: adminPermissions} = await this.heroku.get<Heroku.TeamAppPermission[]>('/teams/permissions')
-        admins = _.forEach(admins, admin => {
-          admin.user = {email: admin.email}
-          admin.permissions = adminPermissions
-          return admin
-        })
-        collaborators = buildCollaboratorsArray(collaborators, admins)
-      } catch (error: any) {
-        if (!(error instanceof HerokuAPIError && error.http.statusCode === 403))
-          throw error
-      }
-    }
-
-    if (json)
-      printJSON(collaborators)
-    else
-      printAccess(app, collaborators)
-  }
+function printJSON(collaborators: Heroku.TeamAppCollaborator[]) {
+  ux.stdout(JSON.stringify(collaborators, null, 2))
 }

src/commands/access/add.ts

@@ -1,7 +1,7 @@
-import {color} from '@heroku/heroku-cli-util'
 import {Command, flags} from '@heroku-cli/command'
 import * as Heroku from '@heroku-cli/schema'
-import {ux} from '@oclif/core'
+import * as color from '@heroku/heroku-cli-util/color'
+import {ux} from '@oclif/core/ux'
 
 export default class AccessRemove extends Command {
   static description = 'remove users from a team app'