refactor: remove unnecessary re-exports from global-telemetry

Remove all re-exports from global-telemetry.ts and have consumers import
utilities directly from telemetry-utils.ts where appropriate.

Changes:
- Removed re-exports of getProcessor, initializeInstrumentation
- Removed re-exports of ensureSentryInitialized
- Removed re-exports of computeDuration, isTelemetryEnabled
- Removed re-exports of types (CLIError, Telemetry, TelemetryGlobal)

Updated imports:
- bin/run.js: Import computeDuration from telemetry-utils
- All hooks: Import isTelemetryEnabled from telemetry-utils
- Hooks still import orchestrator functions from global-telemetry
  (setupTelemetry, reportCmdNotFound)

Updated tests:
- Removed duplicate computeDuration and isTelemetryEnabled tests from
  global-telemetry.unit.test.ts (already tested in telemetry-utils.unit.test.ts)
- Removed unused sinon imports
- Test file now only tests orchestrator functions

Windows compatibility:
- Added windowsHide: true to sentry.ts spawn call to prevent console
  windows on Windows

Benefits:
- Clearer API surface - global-telemetry only exports what it owns
- No unnecessary indirection for utility functions
- Makes it obvious which functions are orchestrators vs utilities
- Better test organization - tests colocated with implementations
- Reduces coupling between modules

The public API of global-telemetry now consists only of:
- setupTelemetry()
- reportCmdNotFound()
- sendTelemetry()

Author: eablack

bin/run.js

@@ -20,7 +20,7 @@ const enableTelemetry = process.platform !== 'win32' || process.env.ENABLE_WINDO
 if (enableTelemetry) {
   // Dynamically import telemetry modules
   const {setupTelemetryHandlers} = await import('../dist/lib/analytics-telemetry/worker-client.js')
-  const {computeDuration} = await import('../dist/lib/analytics-telemetry/global-telemetry.js')
+  const {computeDuration} = await import('../dist/lib/analytics-telemetry/telemetry-utils.js')
 
   // Setup all telemetry handlers (beforeExit, SIGINT, SIGTERM)
   setupTelemetryHandlers({

src/hooks/command_not_found/performance_analytics.ts

@@ -1,14 +1,15 @@
 import {Hook} from '@oclif/core/hooks'
 
 const performance_analytics: Hook<'command_not_found'> = async function () {
-  const telemetry = await import('../../lib/analytics-telemetry/global-telemetry.js')
+  const {isTelemetryEnabled} = await import('../../lib/analytics-telemetry/telemetry-utils.js')
+  const {reportCmdNotFound} = await import('../../lib/analytics-telemetry/global-telemetry.js')
 
   // Use the consolidated telemetry check
-  if (!telemetry.isTelemetryEnabled()) {
+  if (!isTelemetryEnabled()) {
     return
   }
 
-  (global as any).cliTelemetry = telemetry.reportCmdNotFound(this.config)
+  (global as any).cliTelemetry = reportCmdNotFound(this.config)
 }
 
 export default performance_analytics

src/hooks/finally/sentry.ts

@@ -93,10 +93,10 @@ const finallyHook: Hook<'finally'> = async function (options) {
     return
   }
 
-  const telemetry = await import('../../lib/analytics-telemetry/global-telemetry.js')
+  const {isTelemetryEnabled} = await import('../../lib/analytics-telemetry/telemetry-utils.js')
 
   // Use the consolidated telemetry check
-  if (!telemetry.isTelemetryEnabled()) {
+  if (!isTelemetryEnabled()) {
     return
   }
 

src/hooks/init/performance_analytics.ts

@@ -1,14 +1,15 @@
 import {Hook} from '@oclif/core/hooks'
 
 const performance_analytics: Hook<'init'> = async function (options) {
-  const telemetry = await import('../../lib/analytics-telemetry/global-telemetry.js')
+  const {isTelemetryEnabled} = await import('../../lib/analytics-telemetry/telemetry-utils.js')
+  const {setupTelemetry} = await import('../../lib/analytics-telemetry/global-telemetry.js')
 
   // Use the consolidated telemetry check
-  if (!telemetry.isTelemetryEnabled()) {
+  if (!isTelemetryEnabled()) {
     return
   }
 
-  (global as any).cliTelemetry = telemetry.setupTelemetry(this.config, options)
+  (global as any).cliTelemetry = setupTelemetry(this.config, options)
 }
 
 export default performance_analytics

src/hooks/postrun/performance_analytics.ts

@@ -7,15 +7,15 @@ const performance_analytics: Hook<'postrun'> = async function () {
     return
   }
 
-  const telemetry = await import('../../lib/analytics-telemetry/global-telemetry.js')
+  const {isTelemetryEnabled, computeDuration} = await import('../../lib/analytics-telemetry/telemetry-utils.js')
 
   // Use the consolidated telemetry check
-  if (!telemetry.isTelemetryEnabled()) {
+  if (!isTelemetryEnabled()) {
     return
   }
 
   const cmdStartTime = globalAny.cliTelemetry.commandRunDuration
-  globalAny.cliTelemetry.commandRunDuration = telemetry.computeDuration(cmdStartTime)
+  globalAny.cliTelemetry.commandRunDuration = computeDuration(cmdStartTime)
   globalAny.cliTelemetry.lifecycleHookCompletion.postrun = true
   await Reflect.get(globalThis, 'recordPromise')
 }

src/hooks/prerun/analytics.ts

@@ -3,10 +3,11 @@ import {Hook} from '@oclif/core/hooks'
 import Analytics from '../../analytics.js'
 
 const analytics: Hook<'prerun'> = async function (options) {
-  const telemetry = await import('../../lib/analytics-telemetry/global-telemetry.js')
+  const {isTelemetryEnabled} = await import('../../lib/analytics-telemetry/telemetry-utils.js')
+  const {setupTelemetry} = await import('../../lib/analytics-telemetry/global-telemetry.js')
 
   // Use the consolidated telemetry check
-  if (!telemetry.isTelemetryEnabled()) {
+  if (!isTelemetryEnabled()) {
     return
   }
 
@@ -19,7 +20,7 @@ const analytics: Hook<'prerun'> = async function (options) {
     globalAny.cliTelemetry.isVersionOrHelp = false
     globalAny.cliTelemetry.lifecycleHookCompletion.prerun = true
   } else {
-    globalAny.cliTelemetry = telemetry.setupTelemetry(this.config, options)
+    globalAny.cliTelemetry = setupTelemetry(this.config, options)
   }
 
   const analyticsInstance = new Analytics(this.config)

src/lib/analytics-telemetry/global-telemetry.ts

@@ -5,21 +5,15 @@
 
 import type {Config} from '@oclif/core/interfaces'
 
-// Re-export Honeycomb client functions
-export {getProcessor, initializeInstrumentation} from './honeycomb-client.js'
-
-export {ensureSentryInitialized} from './sentry-client.js'
-
 // Import internal dependencies
 import {sendToHoneycomb} from './honeycomb-client.js'
 import {sendToSentry} from './sentry-client.js'
 import {
-  CLIError,
   isTelemetryDisabled,
   setVersion,
   Telemetry,
-  telemetryDebug,
   TelemetryData,
+  telemetryDebug,
 } from './telemetry-utils.js'
 
 /**
@@ -123,14 +117,3 @@ export function setupTelemetry(config: Config, opts: TelemetryOptions): Telemetr
 
   return irregularTelemetryObject
 }
-
-// Export ensureSentryInitialized for use by finally hook
-
-// Re-export utilities and types
-export {
-  type CLIError,
-  computeDuration,
-  isTelemetryEnabled,
-  type Telemetry,
-  type TelemetryGlobal,
-} from './telemetry-utils.js'

test/unit/analytics-telemetry/global-telemetry.unit.test.ts

@@ -1,20 +1,12 @@
 import {expect} from 'chai'
 import nock from 'nock'
-import * as sinon from 'sinon'
 
 import * as globalTelemetry from '../../../src/lib/analytics-telemetry/global-telemetry.js'
 
 const isDev = process.env.IS_DEV_ENVIRONMENT === 'true'
 
 describe('global-telemetry', function () {
-  let sandbox: sinon.SinonSandbox
-
-  beforeEach(function () {
-    sandbox = sinon.createSandbox()
-  })
-
   afterEach(function () {
-    sandbox.restore()
     nock.cleanAll()
   })
 
@@ -167,27 +159,4 @@ describe('global-telemetry', function () {
       process.env.DISABLE_TELEMETRY = originalDisableTelemetry
     })
   })
-
-  describe('computeDuration', function () {
-    it('computes time duration correctly', function () {
-      const now = new Date()
-      const startTime = now.getTime() - 1000 // 1 second ago
-
-      const duration = globalTelemetry.computeDuration(startTime)
-
-      expect(duration).to.be.greaterThan(900)
-      expect(duration).to.be.lessThan(1100)
-    })
-  })
-
-  describe('isTelemetryEnabled', function () {
-    it('returns false when DISABLE_TELEMETRY is true', function () {
-      const originalDisableTelemetry = process.env.DISABLE_TELEMETRY
-      process.env.DISABLE_TELEMETRY = 'true'
-
-      expect(globalTelemetry.isTelemetryEnabled()).to.be.false
-
-      process.env.DISABLE_TELEMETRY = originalDisableTelemetry
-    })
-  })
 })