Skip to content

Commit 34508bf

Browse files
committed
Temporarily Revert "Fix pipenv install twice in CI"
This reverts commit c410fd3. This is a temporary revert in order to release new python binaries first and then roll this change out in a separate release. This keeps releases smaller and better organized in case we need to roll back.
1 parent a165486 commit 34508bf

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

bin/steps/pipenv

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,16 +60,10 @@ if [ ! "$SKIP_PIPENV_INSTALL" ]; then
6060
# avoid this eager behavior.
6161
/app/.heroku/python/bin/pip install pipenv==$PIPENV_VERSION --upgrade --upgrade-strategy only-if-needed &> /dev/null
6262

63-
# Install the test dependencies, for CI.
64-
if [ "$INSTALL_TEST" ]; then
65-
puts-step "Installing test dependencies…"
66-
/app/.heroku/python/bin/pipenv install --dev --system --deploy 2>&1 | cleanup | indent
67-
6863
# Install the dependencies.
69-
elif [[ ! -f Pipfile.lock ]]; then
64+
if [[ ! -f Pipfile.lock ]]; then
7065
puts-step "Installing dependencies with Pipenv $PIPENV_VERSION"
7166
/app/.heroku/python/bin/pipenv install --system --skip-lock 2>&1 | indent
72-
7367
else
7468
pipenv-to-pip Pipfile.lock > requirements.txt
7569
"$BIN_DIR/steps/pip-uninstall"
@@ -79,6 +73,12 @@ if [ ! "$SKIP_PIPENV_INSTALL" ]; then
7973
puts-step "Installing dependencies with Pipenv $PIPENV_VERSION"
8074
/app/.heroku/python/bin/pipenv install --system --deploy 2>&1 | indent
8175
fi
76+
77+
# Install the test dependencies, for CI.
78+
if [ "$INSTALL_TEST" ]; then
79+
puts-step "Installing test dependencies…"
80+
/app/.heroku/python/bin/pipenv install --dev --system --deploy 2>&1 | cleanup | indent
81+
fi
8282
fi
8383
else
8484
export SKIP_PIP_INSTALL=1

0 commit comments

Comments
 (0)