Skip to content

Commit 37d1474

Browse files
authored
Tests: Prevent shadowing of the Python 3.7 version warning test (#1074)
Previously the test for Python 3.8 version warnings was named the same as an earlier test for Python 3.7, meaning the earlier test definition was overwritten and so never run. The later test has now been renamed to the correct version, and the test ordering adjusted for consistency with the rest of the file. Closes @W-8110123@. [skip changelog]
1 parent 40167d8 commit 37d1474

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

test/run-versions

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -140,27 +140,27 @@ testPython3_7_fail() {
140140
assertCapturedError
141141
}
142142

143-
testPython3_7_warn() {
144-
compile "python3_8_warn"
143+
testPython3_8() {
144+
updateVersion "python3_8" $LATEST_38
145+
compile "python3_8"
145146
if [[ $STACK = "cedar-14" ]]; then
146147
assertCapturedError
147148
else
148-
assertCaptured "python-3.8.0"
149-
assertCaptured "security update!"
149+
assertNotCaptured "security update"
150+
assertCaptured $LATEST_38
151+
assertCaptured "Installing pip 20.1.1, setuptools 47.1.1 and wheel 0.34.2"
150152
assertCaptured "Installing SQLite3"
151153
assertCapturedSuccess
152154
fi
153155
}
154156

155-
testPython3_8() {
156-
updateVersion "python3_8" $LATEST_38
157-
compile "python3_8"
157+
testPython3_8_warn() {
158+
compile "python3_8_warn"
158159
if [[ $STACK = "cedar-14" ]]; then
159160
assertCapturedError
160161
else
161-
assertNotCaptured "security update"
162-
assertCaptured $LATEST_38
163-
assertCaptured "Installing pip 20.1.1, setuptools 47.1.1 and wheel 0.34.2"
162+
assertCaptured "python-3.8.0"
163+
assertCaptured "security update!"
164164
assertCaptured "Installing SQLite3"
165165
assertCapturedSuccess
166166
fi

0 commit comments

Comments
 (0)