Skip to content

Commit 64fb396

Browse files
authored
Remove duplicate pipenv metric event (#1070)
Since the `tool.pipenv` event is being emitted twice per pipenv build, inflating its usage. This whole file could do with a massive refactor (4 levels deep of conditionals is never a good sign), but that can wait until a later PR. In the future it would also be great to have testing of metrics events. Closes @W-8094963@.
1 parent eb6ee49 commit 64fb396

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
## Unreleased
44

5+
- Remove duplicate pipenv metric event (#1070).
56
- Emit metrics for how the Python version was chosen for an app (#1069).
67
- Emit Python version metric events for all builds, not just clean installs (#1066).
78

bin/steps/pipenv

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ set -e
99
if [[ -f Pipfile.lock ]]; then
1010
if [[ -f .heroku/python/Pipfile.lock.sha256 ]]; then
1111
if [[ $(openssl dgst -sha256 Pipfile.lock) == $(cat .heroku/python/Pipfile.lock.sha256) ]]; then
12-
# Measure that we're using Pipenv.
13-
mcount "tool.pipenv"
14-
1512
# Don't skip installation of there are git deps.
1613
if ! grep -q 'git' Pipfile.lock; then
1714
echo "Skipping installation, as Pipfile.lock hasn't changed since last deploy." | indent

0 commit comments

Comments
 (0)