Skip to content

Commit 9a83036

Browse files
committed
add 3.8 support
1 parent a165486 commit 9a83036

File tree

4 files changed

+13
-2
lines changed

4 files changed

+13
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
# Master
44

5+
- Add support for Python 3.8 branch
56
- Sqlite3 Update:
67
- Add Tests
78
- Test for Pysqlite

bin/compile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ export VENDOR_URL
5252
source "$BIN_DIR/default_pythons"
5353

5454
# Supported Python Branches
55+
PY38="python-3.8"
5556
PY37="python-3.7"
5657
PY36="python-3.6"
5758
PY35="python-3.5"

bin/default_pythons

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
#!/usr/bin/env bash
22

33
DEFAULT_PYTHON_VERSION="python-3.6.9"
4+
LATEST_38="python-3.8.0"
5+
LATEST_37="python-3.7.5"
46
LATEST_36="python-3.6.9"
5-
LATEST_37="python-3.7.4"
67
LATEST_35="python-3.5.7"
78
LATEST_34="python-3.4.10"
89
LATEST_27="python-2.7.16"
910

10-
export DEFAULT_PYTHON_VERSION LATEST_37 LATEST_36 LATEST_35 LATEST_34 LATEST_27
11+
export DEFAULT_PYTHON_VERSION LATEST_38 LATEST_37 LATEST_36 LATEST_35 LATEST_34 LATEST_27

bin/steps/python

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,14 @@ VENDORED_PYTHON="${VENDOR_URL}/runtimes/$PYTHON_VERSION.tar.gz"
1010
SECURITY_UPDATE="Python has released a security update! Please consider upgrading to"
1111

1212
# check if runtime exists
13+
if curl --output /dev/null --silent --head --fail "$VENDORED_PYTHON"; then
14+
if [[ "$PYTHON_VERSION" == $PY38* ]]; then
15+
# do things to alert the user of security release available
16+
if [ "$PYTHON_VERSION" != "$LATEST_38" ]; then
17+
puts-warn "$SECURITY_UPDATE" "$LATEST_38"
18+
echo " Learn More: https://devcenter.heroku.com/articles/python-runtimes"
19+
fi
20+
fi
1321
if curl --output /dev/null --silent --head --fail "$VENDORED_PYTHON"; then
1422
if [[ "$PYTHON_VERSION" == $PY37* ]]; then
1523
# do things to alert the user of security release available

0 commit comments

Comments
 (0)