Skip to content

Commit dd0aee7

Browse files
committed
update metrics
1 parent 23827b5 commit dd0aee7

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

bin/steps/collectstatic

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,22 +44,20 @@ if [ ! "$DISABLE_COLLECTSTATIC" ] && [ -f "$MANAGE_FILE" ] && [ "$DJANGO_INSTALL
4444
# Display a warning if collectstatic failed.
4545
[ "$COLLECTSTATIC_STATUS" -ne 0 ] && {
4646

47-
mcount "failure.collectstatic"
48-
4947
if grep -q 'SyntaxError' "$COLLECTSTATIC_LOG"; then
5048
mcount "failure.collectstatic.syntax-error"
51-
fi
5249

53-
if grep -q 'ImproperlyConfigured' "$COLLECTSTATIC_LOG"; then
50+
elif grep -q 'ImproperlyConfigured' "$COLLECTSTATIC_LOG"; then
5451
mcount "failure.collectstatic.improper-configuration"
55-
fi
5652

57-
if grep -q 'The CSS file' "$COLLECTSTATIC_LOG"; then
53+
elif grep -q 'The CSS file' "$COLLECTSTATIC_LOG"; then
5854
mcount "failure.collectstatic.fancy-references"
59-
fi
6055

61-
if grep -q 'OSError' "$COLLECTSTATIC_LOG"; then
56+
elif grep -q 'OSError' "$COLLECTSTATIC_LOG"; then
6257
mcount "failure.collectstatic.missing-file"
58+
59+
else
60+
mcount "failure.collectstatic.other"
6361
fi
6462

6563
echo

bin/steps/pip-install

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@ if [ ! "$SKIP_PIP_INSTALL" ]; then
2020
mcount "tool.pip"
2121

2222
# Count expected build failures.
23-
if grep -q 'wsgiref' requirements.txt; then
24-
mcount "failure.wsgiref"
25-
fi
2623
if grep -q '==0.0.0' requirements.txt; then
2724
mcount "failure.none-version"
2825
fi
@@ -35,10 +32,10 @@ if [ ! "$SKIP_PIP_INSTALL" ]; then
3532
show-warnings
3633

3734
if [[ ! $PIP_STATUS -eq 0 ]]; then
35+
mcount "failure.pip-install"
3836
exit 1
3937
fi
4038

41-
4239
# Smart Requirements handling
4340
cp requirements.txt .heroku/python/requirements-declared.txt
4441
/app/.heroku/python/bin/pip freeze --disable-pip-version-check > .heroku/python/requirements-installed.txt

0 commit comments

Comments
 (0)