Skip to content

Commit e821501

Browse files
authored
Merge branch 'master' into test-staged-binaries
2 parents 03c12e8 + 1d938c3 commit e821501

File tree

13 files changed

+60
-21
lines changed

13 files changed

+60
-21
lines changed

CHANGELOG.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33
# Master
44

55
- Test staged binaries on Travis
6+
7+
--------------------------------------------------------------------------------
8+
# 158 (2019-10-21)
9+
10+
- Python 3.7.5 and 3.8.0 now available on Heroku 18 and 16.
11+
- Add support for Python 3.8 branch
612
- Sqlite3 Update:
7-
- Add Tests
8-
- Test for Pysqlite
9-
- Bug fix: pipenv no longer installs twice on CI
13+
- Test Improvements
1014
- Add support for staging binary testing
11-
--------------------------------------------------------------------------------
1215

1316
# 157 (2019-09-18)
1417

bin/compile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ export VENDOR_URL
5252
source "$BIN_DIR/default_pythons"
5353

5454
# Supported Python Branches
55+
PY38="python-3.8"
5556
PY37="python-3.7"
5657
PY36="python-3.6"
5758
PY35="python-3.5"

bin/default_pythons

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
#!/usr/bin/env bash
22

33
DEFAULT_PYTHON_VERSION="python-3.6.9"
4+
LATEST_38="python-3.8.0"
5+
LATEST_37="python-3.7.5"
46
LATEST_36="python-3.6.9"
5-
LATEST_37="python-3.7.4"
67
LATEST_35="python-3.5.7"
78
LATEST_34="python-3.4.10"
89
LATEST_27="python-2.7.16"
910

10-
export DEFAULT_PYTHON_VERSION LATEST_37 LATEST_36 LATEST_35 LATEST_34 LATEST_27
11+
export DEFAULT_PYTHON_VERSION LATEST_38 LATEST_37 LATEST_36 LATEST_35 LATEST_34 LATEST_27

bin/steps/pipenv

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,16 +60,10 @@ if [ ! "$SKIP_PIPENV_INSTALL" ]; then
6060
# avoid this eager behavior.
6161
/app/.heroku/python/bin/pip install pipenv==$PIPENV_VERSION --upgrade --upgrade-strategy only-if-needed &> /dev/null
6262

63-
# Install the test dependencies, for CI.
64-
if [ "$INSTALL_TEST" ]; then
65-
puts-step "Installing test dependencies…"
66-
/app/.heroku/python/bin/pipenv install --dev --system --deploy 2>&1 | cleanup | indent
67-
6863
# Install the dependencies.
69-
elif [[ ! -f Pipfile.lock ]]; then
64+
if [[ ! -f Pipfile.lock ]]; then
7065
puts-step "Installing dependencies with Pipenv $PIPENV_VERSION"
7166
/app/.heroku/python/bin/pipenv install --system --skip-lock 2>&1 | indent
72-
7367
else
7468
pipenv-to-pip Pipfile.lock > requirements.txt
7569
"$BIN_DIR/steps/pip-uninstall"
@@ -79,6 +73,12 @@ if [ ! "$SKIP_PIPENV_INSTALL" ]; then
7973
puts-step "Installing dependencies with Pipenv $PIPENV_VERSION"
8074
/app/.heroku/python/bin/pipenv install --system --deploy 2>&1 | indent
8175
fi
76+
77+
# Install the test dependencies, for CI.
78+
if [ "$INSTALL_TEST" ]; then
79+
puts-step "Installing test dependencies…"
80+
/app/.heroku/python/bin/pipenv install --dev --system --deploy 2>&1 | cleanup | indent
81+
fi
8282
fi
8383
else
8484
export SKIP_PIP_INSTALL=1

bin/steps/python

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,13 @@ SECURITY_UPDATE="Python has released a security update! Please consider upgradin
1111

1212
# check if runtime exists
1313
if curl --output /dev/null --silent --head --fail "$VENDORED_PYTHON"; then
14+
if [[ "$PYTHON_VERSION" == $PY38* ]]; then
15+
# do things to alert the user of security release available
16+
if [ "$PYTHON_VERSION" != "$LATEST_38" ]; then
17+
puts-warn "$SECURITY_UPDATE" "$LATEST_38"
18+
echo " Learn More: https://devcenter.heroku.com/articles/python-runtimes"
19+
fi
20+
fi
1421
if [[ "$PYTHON_VERSION" == $PY37* ]]; then
1522
# do things to alert the user of security release available
1623
if [ "$PYTHON_VERSION" != "$LATEST_37" ]; then

builds/runtimes/python-3.7.5

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
#!/usr/bin/env bash
2+
# Build Path: /app/.heroku/python/
3+
4+
source $(dirname $0)/python3

builds/runtimes/python-3.8.0

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
#!/usr/bin/env bash
2+
# Build Path: /app/.heroku/python/
3+
4+
source $(dirname $0)/python3
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
python-3.4.0
1+
python-3.4.9
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
requests

test/fixtures/python3_8/runtime.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
python-3.8.0

0 commit comments

Comments
 (0)