Skip to content

Commit f072b73

Browse files
committed
Fix-up SC2219 errors in our shell scripts
Caught these with the re-added shellcheck linting.
1 parent f174d03 commit f072b73

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

bin/compile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ fi
221221

222222
# Download / Install Python, from pre-build binaries available on Amazon S3.
223223
# This step also bootstraps pip / setuptools.
224-
let start=$(nowms)
224+
(( start=$(nowms) ))
225225
# shellcheck source=bin/steps/python
226226
source "$BIN_DIR/steps/python"
227227
mtime "python.install.time" "${start}"
@@ -233,7 +233,7 @@ source "$BIN_DIR/steps/pipenv"
233233
# Uninstall removed dependencies with Pip.
234234
# The buildpack will automatically remove any declared dependencies (in requirements.txt)
235235
# that were explicitly removed. This machinery is a bit complex, but it is not complicated.
236-
let start=$(nowms)
236+
(( start=$(nowms) ))
237237
# shellcheck source=bin/steps/pip-uninstall
238238
source "$BIN_DIR/steps/pip-uninstall"
239239
mtime "pip.uninstall.time" "${start}"
@@ -277,7 +277,7 @@ source "$BIN_DIR/steps/gdal"
277277
# -----------
278278

279279
# Install dependencies with pip (where the magic happens).
280-
let start=$(nowms)
280+
(( start=$(nowms) ))
281281
# shellcheck source=bin/steps/pip-install
282282
source "$BIN_DIR/steps/pip-install"
283283
mtime "pip.install.time" "${start}"
@@ -286,7 +286,7 @@ mtime "pip.install.time" "${start}"
286286
# Note: this may only work on Python 2.7. I don't think many customers use this functionality,
287287
# and it should probably be undocumented.
288288
# (there's an import error on 3.6 that should hopefully be fixed upstream at some point)
289-
let start=$(nowms)
289+
(( start=$(nowms) ))
290290
sub_env "$BIN_DIR/steps/nltk"
291291
mtime "nltk.download.time" "${start}"
292292

@@ -304,7 +304,7 @@ fi
304304
# This is the cause for the majority of build failures on the Python platform.
305305
# These failures are intentional — if collectstatic (which can be tricky, at times) fails,
306306
# your build fails.
307-
let start=$(nowms)
307+
(( start=$(nowms) ))
308308
sub_env "$BIN_DIR/steps/collectstatic"
309309
mtime "collectstatic.time" "${start}"
310310

0 commit comments

Comments
 (0)