Skip to content

Commit f1b0f8c

Browse files
committed
correct the pass/fail metric for python 34
1 parent f90dfbc commit f1b0f8c

File tree

2 files changed

+17
-8
lines changed

2 files changed

+17
-8
lines changed

test/fixtures/python3_4/runtime.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
python-3.4.9
1+
python-3.4.10

test/run-versions

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,25 +38,34 @@ testPython2_fail() {
3838
}
3939

4040
testPython3_4() {
41-
updateVersion "python3_4" $LATEST_34
4241
compile "python3_4"
4342
assertCaptured $LATEST_34
4443
assertNotCaptured "security update"
45-
if [[ $STACK == "cedar-14" ]] || [[ $STACK == "heroku-16" ]]; then
46-
assertCapturedSuccess
44+
# if cedar 14 and legacy binaries, fail. if cedar 14 and staging, succeed.
45+
if [[ ! -n $USE_STAGING_BINARIES ]] && [[ $STACK == "cedar-14" ]]; then
46+
assertCapturedError
47+
# if heroku 18 and legacy binaries, succeed. if heroku 18 and staging, fail.
48+
elif [[ -n $USE_STAGING_BINARIES ]] && [[ $STACK == "heroku-18" ]]; then
49+
assertCapturedError
4750
else
48-
assertCapturedError
51+
# all else succeed
52+
assertCapturedSuccess
4953
fi
5054
}
5155

5256
testPython3_4_warn() {
5357
compile "python3_4_warn"
5458
assertCaptured "python-3.4.9"
5559
assertCaptured "security update!"
56-
if [[ $STACK == "cedar-14" ]] || [[ $STACK == "heroku-16" ]]; then
57-
assertCapturedSuccess
60+
# if cedar 14 and legacy binaries, fail. if cedar 14 and staging, succeed.
61+
if [[ ! -n $USE_STAGING_BINARIES ]] && [[ $STACK == "cedar-14" ]]; then
62+
assertCapturedError
63+
# if heroku 18 and legacy binaries, succeed. if heroku 18 and staging, fail.
64+
elif [[ -n $USE_STAGING_BINARIES ]] && [[ $STACK == "heroku-18" ]]; then
65+
assertCapturedError
5866
else
59-
assertCapturedError
67+
# all else succeed
68+
assertCapturedSuccess
6069
fi
6170
}
6271

0 commit comments

Comments
 (0)