Use stack state for recall view list, not engine scope

Author: mcslee

src/main/java/heronarts/lx/snapshot/LXSnapshotEngine.java

@@ -419,9 +419,6 @@ public LXGlobalSnapshot getCursorSnapshot() {
     return null;
   }
 
-  private final List<LXSnapshot.View> recallViews =
-    new ArrayList<LXSnapshot.View>();
-
   /**
    * Recall this snapshot, apply all of its values
    *
@@ -459,8 +456,10 @@ public boolean recall(LXGlobalSnapshot snapshot, List<LXCommand> commands) {
       commands.add(new LXCommand.Parameter.SetValue(this.autoCycleCursor, this.autoCycleCursor.getValuei()));
     }
     this.autoCycleCursor.setValue(snapshot.getIndex());
-    this.recallViews.clear();
-    this.recallViews.addAll(snapshot.views);
+
+    final List<View> recallViews = new ArrayList<>();
+    recallViews.addAll(snapshot.views);
+
     if (this.transitionEnabled.isOn()) {
       transition = true;
       this.inTransition = snapshot;
@@ -470,12 +469,12 @@ public boolean recall(LXGlobalSnapshot snapshot, List<LXCommand> commands) {
     if (this.missingChannelMode.getEnum() == MissingChannelMode.DISABLE) {
       for (LXAbstractChannel channel : this.lx.engine.mixer.channels) {
         if (channel.enabled.isOn() && !snapshot.hasChannelFaderView(channel)) {
-          this.recallViews.add(snapshot.getMissingChannelView(channel));
+          recallViews.add(snapshot.getMissingChannelView(channel));
         }
       }
     }
 
-    for (View view : this.recallViews) {
+    for (View view : recallViews) {
       if (view.activeFlag = isValidView(view, mixer, pattern, effect, modulation, output, master)) {
         if (transition) {
           view.startTransition();