fix ci

Author: apricote

docs/reference/manual/hcloud_primary-ip_create.md

@@ -41,6 +41,7 @@ func TestListAll(t *testing.T) {
 					},
 				},
 				Created:    time.Now().Add(-72 * time.Hour),
+				Location:   &hcloud.Location{Name: "hel1"},
 				Datacenter: &hcloud.Datacenter{Name: "hel1-dc2"},
 			},
 		}, nil)
@@ -236,8 +237,8 @@ func TestListAll(t *testing.T) {
 
 	expOut := `SERVERS
 ---
-ID    NAME        STATUS    IPV4        IPV6   PRIVATE NET   DATACENTER   AGE
-123   my server   running   192.0.2.1   -      -             hel1-dc2     3d 
+ID    NAME        STATUS    IPV4        IPV6   PRIVATE NET   LOCATION   AGE
+123   my server   running   192.0.2.1   -      -             hel1       3d 
 
 IMAGES
 ---

docs/reference/manual/hcloud_server_create.md

@@ -39,7 +39,7 @@ func TestCreate(t *testing.T) {
 			hcloud.PrimaryIPCreateOpts{
 				Name:         "my-ip",
 				Type:         "ipv4",
-				Datacenter:   "fsn1-dc14",
+				Location:     "fsn1",
 				Labels:       map[string]string{"foo": "bar"},
 				AssigneeType: "server",
 				AutoDelete:   hcloud.Ptr(true),
@@ -87,6 +87,9 @@ func TestCreateJSON(t *testing.T) {
 		Name: "my-ip",
 		IP:   net.ParseIP("192.168.2.1"),
 		Type: "ipv4",
+		Location: &hcloud.Location{
+			Name: "fsn1",
+		},
 		Datacenter: &hcloud.Datacenter{
 			ID:       1,
 			Name:     "fsn1-dc14",
@@ -106,7 +109,7 @@ func TestCreateJSON(t *testing.T) {
 			hcloud.PrimaryIPCreateOpts{
 				Name:         "my-ip",
 				Type:         "ipv4",
-				Datacenter:   "fsn1-dc14",
+				Location:     "fsn1",
 				Labels:       map[string]string{"foo": "bar"},
 				AssigneeType: "server",
 				AutoDelete:   hcloud.Ptr(true),

internal/cmd/all/list_test.go

@@ -12,7 +12,7 @@
       "id": 0,
       "latitude": 0,
       "longitude": 0,
-      "name": "",
+      "name": "fsn1",
       "network_zone": ""
     },
     "datacenter": {

internal/cmd/primaryip/create_test.go

@@ -444,8 +444,7 @@ func createOptsFromFlags(
 		// Else -> Backwards-compatible split
 		var datacenterID int64
 		datacenterID, err = strconv.ParseInt(datacenterIDOrName, 10, 64)
-
-		if err != nil {
+		if err == nil {
 			// Input was a valid number/ID
 			var datacenter *hcloud.Datacenter
 			datacenter, _, err = s.Client().Datacenter().GetByID(s, datacenterID)
@@ -466,6 +465,7 @@ func createOptsFromFlags(
 
 			if len(parts) != 2 {
 				err = fmt.Errorf("Datacenter name is not valid, expected format $LOCATION-$DATACENTER, but got: %s", datacenterIDOrName)
+				return
 			}
 
 			createOpts.Location = &hcloud.Location{Name: parts[0]}

internal/cmd/primaryip/testdata/create_response.json

@@ -91,9 +91,9 @@ var ListCmd = &base.ListCmd[*hcloud.Server, schema.Server]{
 			AddFieldFn("datacenter", func(server *hcloud.Server) string {
 				if server.Datacenter != nil {
 					return server.Datacenter.Name
-				} else {
-					return "-"
 				}
+				return "-"
+
 			}).
 			AddFieldFn("location", func(server *hcloud.Server) string {
 				return server.Location.Name