diff --git a/internal/hcops/load_balancer.go b/internal/hcops/load_balancer.go index 40714593..e5bf99f9 100644 --- a/internal/hcops/load_balancer.go +++ b/internal/hcops/load_balancer.go @@ -950,6 +950,7 @@ func (l *LoadBalancerOps) ReconcileHCLBServices( warnMsg, ) klog.Warning(warnMsg) + continue } b := &hclbServiceOptsBuilder{ diff --git a/internal/hcops/load_balancer_test.go b/internal/hcops/load_balancer_test.go index e3bfa854..9aba8124 100644 --- a/internal/hcops/load_balancer_test.go +++ b/internal/hcops/load_balancer_test.go @@ -1609,31 +1609,6 @@ func TestLoadBalancerOps_ReconcileHCLBServices(t *testing.T) { MaxTargets: 25, }, }, - mock: func(_ *testing.T, tt *LBReconcilementTestCase) { - opts := hcloud.LoadBalancerAddServiceOpts{ - Protocol: hcloud.LoadBalancerServiceProtocolTCP, - ListenPort: hcloud.Ptr(80), - DestinationPort: hcloud.Ptr(8080), - HealthCheck: &hcloud.LoadBalancerAddServiceOptsHealthCheck{ - Protocol: hcloud.LoadBalancerServiceProtocolTCP, - Port: hcloud.Ptr(8080), - }, - } - action := tt.fx.MockAddService(opts, tt.initialLB, nil) - tt.fx.ActionClient.On("WaitFor", tt.fx.Ctx, action).Return(nil) - - opts = hcloud.LoadBalancerAddServiceOpts{ - Protocol: hcloud.LoadBalancerServiceProtocolTCP, - ListenPort: hcloud.Ptr(443), - DestinationPort: hcloud.Ptr(8443), - HealthCheck: &hcloud.LoadBalancerAddServiceOptsHealthCheck{ - Protocol: hcloud.LoadBalancerServiceProtocolTCP, - Port: hcloud.Ptr(8443), - }, - } - action = tt.fx.MockAddService(opts, tt.initialLB, nil) - tt.fx.ActionClient.On("WaitFor", tt.fx.Ctx, action).Return(nil) - }, perform: func(t *testing.T, tt *LBReconcilementTestCase) { _, err := tt.fx.LBOps.ReconcileHCLBServices(tt.fx.Ctx, tt.initialLB, tt.service) assert.NoError(t, err)