test: improve tests for storage boxes types

Author: jooola

tests/unit/storage_box_types/test_client.py

@@ -7,6 +7,7 @@
 import pytest
 from dateutil.parser import isoparse
 
+from hcloud import Client
 from hcloud.storage_box_types import (
     BoundStorageBoxType,
     StorageBoxTypesClient,
@@ -23,24 +24,30 @@ def assert_bound_model(
     assert o.name == "bx11"
 
 
+@pytest.fixture(name="request_mock")
+def request_mock_fixture():
+    return mock.MagicMock()
+
+
 @pytest.fixture(name="client")
-def client_fixture() -> StorageBoxTypesClient:
-    return StorageBoxTypesClient(client=mock.MagicMock())
+def client_fixture(request_mock) -> StorageBoxTypesClient:
+    client = Client("")
+    client._request_hetzner = request_mock
+    return StorageBoxTypesClient(client=client)
 
 
 class TestClient:
     def test_get_by_id(
         self,
+        request_mock: mock.MagicMock,
         client: StorageBoxTypesClient,
         storage_box_type1,
     ):
-        client._client._request_hetzner.return_value = {
-            "storage_box_type": storage_box_type1
-        }
+        request_mock.return_value = {"storage_box_type": storage_box_type1}
 
         result = client.get_by_id(42)
 
-        client._client._request_hetzner.assert_called_with(
+        request_mock.assert_called_with(
             method="GET",
             url="/storage_box_types/42",
         )
@@ -73,18 +80,19 @@ def test_get_by_id(
     )
     def test_get_list(
         self,
+        request_mock: mock.MagicMock,
         client: StorageBoxTypesClient,
         storage_box_type1,
         storage_box_type2,
         params,
     ):
-        client._client._request_hetzner.return_value = {
+        request_mock.return_value = {
             "storage_box_types": [storage_box_type1, storage_box_type2]
         }
 
         result = client.get_list(**params)
 
-        client._client._request_hetzner.assert_called_with(
+        request_mock.assert_called_with(
             url="/storage_box_types",
             method="GET",
             params=params,
@@ -113,18 +121,19 @@ def test_get_list(
     )
     def test_get_all(
         self,
+        request_mock: mock.MagicMock,
         client: StorageBoxTypesClient,
         storage_box_type1,
         storage_box_type2,
         params,
     ):
-        client._client._request_hetzner.return_value = {
+        request_mock.return_value = {
             "storage_box_types": [storage_box_type1, storage_box_type2]
         }
 
         result = client.get_all(**params)
 
-        client._client._request_hetzner.assert_called_with(
+        request_mock.assert_called_with(
             url="/storage_box_types",
             method="GET",
             params={**params, "page": 1, "per_page": 50},
@@ -145,18 +154,17 @@ def test_get_all(
 
     def test_get_by_name(
         self,
+        request_mock: mock.MagicMock,
         client: StorageBoxTypesClient,
         storage_box_type1,
     ):
-        client._client._request_hetzner.return_value = {
-            "storage_box_types": [storage_box_type1]
-        }
+        request_mock.return_value = {"storage_box_types": [storage_box_type1]}
 
         result = client.get_by_name("bx11")
 
         params = {"name": "bx11"}
 
-        client._client._request_hetzner.assert_called_with(
+        request_mock.assert_called_with(
             method="GET",
             url="/storage_box_types",
             params=params,

tests/unit/storage_box_types/test_domain.py

@@ -0,0 +1,15 @@
+from __future__ import annotations
+
+import pytest
+
+from hcloud.storage_box_types import StorageBoxType
+
+
+@pytest.mark.parametrize(
+    "value",
+    [
+        (StorageBoxType(id=1),),
+    ],
+)
+def test_eq(value):
+    assert value == value