Skip to content

Commit 6908111

Browse files
LKaemmerlingLKaemmerling
authored
Fix: Unify setting of request parameters within get_list methods. (#91)
1 parent 950f1d8 commit 6908111

File tree

28 files changed

+102
-88
lines changed

28 files changed

+102
-88
lines changed

‎CHANGELOG.rst‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
History
33
=======
44

5+
master (XXXX-XX-XX)
6+
--------------------
7+
8+
* Fix: Unify setting of request parameters within `get_list` methods.
9+
510
1.8.0 (2020-06-22)
611
--------------------
712

‎docs/index.rst‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Create Server
3636
from hcloud.images.domain import Image
3737
3838
client = Client(token="{YOUR_API_TOKEN}") # Please paste your API token here between the quotes
39-
response = client.servers.create(name="my-server", server_type=ServerType(name="cx11"), image=Image(name="ubuntu-18.04"))
39+
response = client.servers.create(name="my-server", server_type=ServerType(name="cx11"), image=Image(name="ubuntu-20.04"))
4040
server = response.server
4141
print(server)
4242
print("Root Password: " + response.root_password)

‎examples/create_server.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from hcloud.server_types.domain import ServerType
44

55
client = Client(token="{YOUR_API_TOKEN}") # Please paste your API token here between the quotes
6-
response = client.servers.create(name="my-server", server_type=ServerType("cx11"), image=Image(name="ubuntu-18.04"))
6+
response = client.servers.create(name="my-server", server_type=ServerType("cx11"), image=Image(name="ubuntu-20.04"))
77
server = response.server
88
print(server)
99
print("Root Password" + response.root_password)

‎hcloud/certificates/client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def get_list(self,
6363
if name is not None:
6464
params["name"] = name
6565

66-
if label_selector:
66+
if label_selector is not None:
6767
params["label_selector"] = label_selector
6868

6969
if page is not None:

‎hcloud/floating_ips/client.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -202,13 +202,13 @@ def get_list(self,
202202
"""
203203
params = {}
204204

205-
if label_selector:
205+
if label_selector is not None:
206206
params['label_selector'] = label_selector
207-
if page:
207+
if page is not None:
208208
params['page'] = page
209-
if per_page:
209+
if per_page is not None:
210210
params['per_page'] = per_page
211-
if name:
211+
if name is not None:
212212
params['name'] = name
213213

214214
response = self._client.request(url="/floating_ips", method="GET", params=params)

‎hcloud/images/client.py‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -178,21 +178,21 @@ def get_list(self,
178178
:return: (List[:class:`BoundImage <hcloud.images.client.BoundImage>`], :class:`Meta <hcloud.core.domain.Meta>`)
179179
"""
180180
params = {}
181-
if name:
181+
if name is not None:
182182
params['name'] = name
183-
if label_selector:
183+
if label_selector is not None:
184184
params['label_selector'] = label_selector
185-
if bound_to:
185+
if bound_to is not None:
186186
params['bound_to'] = bound_to
187-
if type:
187+
if type is not None:
188188
params['type'] = type
189-
if sort:
189+
if sort is not None:
190190
params['sort'] = sort
191-
if page:
191+
if page is not None:
192192
params['page'] = page
193-
if per_page:
193+
if per_page is not None:
194194
params['per_page'] = per_page
195-
if status:
195+
if status is not None:
196196
params['status'] = per_page
197197

198198
response = self._client.request(url="/images", method="GET", params=params)

‎hcloud/isos/client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def get_list(self,
3838
:return: (List[:class:`BoundIso <hcloud.isos.client.BoundIso>`], :class:`Meta <hcloud.core.domain.Meta>`)
3939
"""
4040
params = {}
41-
if name:
41+
if name is not None:
4242
params['name'] = name
4343
if page is not None:
4444
params['page'] = page

‎hcloud/load_balancers/client.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -217,13 +217,13 @@ def get_list(
217217
:return: (List[:class:`BoundLoadBalancer <hcloud.load_balancers.client.BoundLoadBalancer>`], :class:`Meta <hcloud.core.domain.Meta>`)
218218
"""
219219
params = {}
220-
if name:
220+
if name is not None:
221221
params["name"] = name
222-
if label_selector:
222+
if label_selector is not None:
223223
params["label_selector"] = label_selector
224-
if page:
224+
if page is not None:
225225
params["page"] = page
226-
if per_page:
226+
if per_page is not None:
227227
params["per_page"] = per_page
228228

229229
response = self._client.request(url="/load_balancers", method="GET", params=params)

‎hcloud/networks/client.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,13 +173,13 @@ def get_list(
173173
:return: (List[:class:`BoundNetwork <hcloud.networks.client.BoundNetwork>`], :class:`Meta <hcloud.core.domain.Meta>`)
174174
"""
175175
params = {}
176-
if name:
176+
if name is not None:
177177
params["name"] = name
178-
if label_selector:
178+
if label_selector is not None:
179179
params["label_selector"] = label_selector
180-
if page:
180+
if page is not None:
181181
params["page"] = page
182-
if per_page:
182+
if per_page is not None:
183183
params["per_page"] = per_page
184184

185185
response = self._client.request(url="/networks", method="GET", params=params)

‎hcloud/servers/client.py‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -346,15 +346,15 @@ def get_list(self,
346346
:return: (List[:class:`BoundServer <hcloud.servers.client.BoundServer>`], :class:`Meta <hcloud.core.domain.Meta>`)
347347
"""
348348
params = {}
349-
if name:
349+
if name is not None:
350350
params['name'] = name
351-
if label_selector:
351+
if label_selector is not None:
352352
params['label_selector'] = label_selector
353-
if status:
353+
if status is not None:
354354
params["status"] = status
355-
if page:
355+
if page is not None:
356356
params['page'] = page
357-
if per_page:
357+
if per_page is not None:
358358
params['per_page'] = per_page
359359

360360
response = self._client.request(url="/servers", method="GET", params=params)

0 commit comments

Comments
 (0)