wip

Author: jooola

tests/unit/servers/test_client.py

@@ -1146,6 +1146,87 @@ def test_change_alias_ips(
         assert action.progress == 0
         assert action.command == "change_alias_ips"
 
+    @pytest.mark.parametrize(
+        "server", [Server(id=1), BoundServer(mock.MagicMock(), dict(id=1))]
+    )
+    @pytest.mark.parametrize(
+        "placement_group",
+        [PlacementGroup(id=897), BoundPlacementGroup(mock.MagicMock, dict(id=897))],
+    )
+    def test_add_to_placement_group(
+        self,
+        request_mock: mock.MagicMock,
+        servers_client: ServersClient,
+        server,
+        placement_group,
+        response_add_to_placement_group,
+    ):
+        request_mock.return_value = response_add_to_placement_group
+
+        action = servers_client.add_to_placement_group(server, placement_group)
+
+        request_mock.assert_called_with(
+            method="POST",
+            url="/servers/1/actions/add_to_placement_group",
+            json={"placement_group": 897},
+        )
+
+        assert action.id == 13
+
+    @pytest.mark.parametrize(
+        "server", [Server(id=1), BoundServer(mock.MagicMock(), dict(id=1))]
+    )
+    def test_remove_from_placement_group(
+        self,
+        request_mock: mock.MagicMock,
+        servers_client: ServersClient,
+        server,
+        response_remove_from_placement_group,
+    ):
+        request_mock.return_value = response_remove_from_placement_group
+
+        action = servers_client.remove_from_placement_group(server)
+
+        request_mock.assert_called_with(
+            method="POST",
+            url="/servers/1/actions/remove_from_placement_group",
+        )
+
+        assert action.id == 13
+
+    @pytest.mark.parametrize(
+        "server", [Server(id=1), BoundServer(mock.MagicMock(), dict(id=1))]
+    )
+    def test_get_metrics(
+        self,
+        request_mock: mock.MagicMock,
+        servers_client: ServersClient,
+        server,
+        response_get_metrics,
+    ):
+        request_mock.return_value = response_get_metrics
+
+        response = servers_client.get_metrics(
+            server,
+            type=["cpu", "disk"],
+            start="2023-12-14T17:40:00+01:00",
+            end="2023-12-14T17:50:00+01:00",
+        )
+
+        request_mock.assert_called_with(
+            method="GET",
+            url="/servers/1/metrics",
+            params={
+                "type": "cpu,disk",
+                "start": "2023-12-14T17:40:00+01:00",
+                "end": "2023-12-14T17:50:00+01:00",
+            },
+        )
+
+        assert "cpu" in response.metrics.time_series
+        assert "disk.0.iops.read" in response.metrics.time_series
+        assert len(response.metrics.time_series["disk.0.iops.read"]["values"]) == 3
+
     # def test_update(
     #     self,
     #     request_mock: mock.MagicMock,
@@ -1183,34 +1264,6 @@ def test_change_alias_ips(
     #     assert action.id == 1
     #     assert action.progress == 0
 
-    # def test_get_metrics(
-    #     self,
-    #     request_mock: mock.MagicMock,
-    #     bound_server: BoundServer,
-    #     response_get_metrics,
-    # ):
-    #     request_mock.return_value = response_get_metrics
-
-    #     response = bound_server.get_metrics(
-    #         type=["cpu", "disk"],
-    #         start="2023-12-14T17:40:00+01:00",
-    #         end="2023-12-14T17:50:00+01:00",
-    #     )
-
-    #     request_mock.assert_called_with(
-    #         method="GET",
-    #         url="/servers/14/metrics",
-    #         params={
-    #             "type": "cpu,disk",
-    #             "start": "2023-12-14T17:40:00+01:00",
-    #             "end": "2023-12-14T17:50:00+01:00",
-    #         },
-    #     )
-
-    #     assert "cpu" in response.metrics.time_series
-    #     assert "disk.0.iops.read" in response.metrics.time_series
-    #     assert len(response.metrics.time_series["disk.0.iops.read"]["values"]) == 3
-
     # def test_power_off(
     #     self,
     #     request_mock: mock.MagicMock,
@@ -1632,46 +1685,6 @@ def test_change_alias_ips(
     #     assert action.progress == 0
     #     assert action.command == "change_alias_ips"
 
-    # @pytest.mark.parametrize(
-    #     "placement_group",
-    #     [PlacementGroup(id=897), BoundPlacementGroup(mock.MagicMock, dict(id=897))],
-    # )
-    # def test_add_to_placement_group(
-    #     self,
-    #     request_mock: mock.MagicMock,
-    #     bound_server,
-    #     placement_group,
-    #     response_add_to_placement_group,
-    # ):
-    #     request_mock.return_value = response_add_to_placement_group
-
-    #     action = bound_server.add_to_placement_group(placement_group)
-
-    #     request_mock.assert_called_with(
-    #         method="POST",
-    #         url="/servers/14/actions/add_to_placement_group",
-    #         json={"placement_group": 897},
-    #     )
-
     #     assert action.id == 13
     #     assert action.progress == 0
     #     assert action.command == "add_to_placement_group"
-
-    # def test_remove_from_placement_group(
-    #     self,
-    #     request_mock: mock.MagicMock,
-    #     bound_server,
-    #     response_remove_from_placement_group,
-    # ):
-    #     request_mock.return_value = response_remove_from_placement_group
-
-    #     action = bound_server.remove_from_placement_group()
-
-    #     request_mock.assert_called_with(
-    #         method="POST",
-    #         url="/servers/14/actions/remove_from_placement_group",
-    #     )
-
-    #     assert action.id == 13
-    #     assert action.progress == 100
-    #     assert action.command == "remove_from_placement_group"