feat: deprecate datacenter in primary ips and servers

jooola · jooola · commit d47b0519f317 · 2025-12-19T15:01:33.000+01:00
See https://docs.hetzner.cloud/changelog#2025-12-16-phasing-out-datacenters
diff --git a/hcloud/primary_ips/client.py b/hcloud/primary_ips/client.py
@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import warnings
 from typing import TYPE_CHECKING, Any, NamedTuple
 
 from ..actions import ActionsPageResult, BoundAction, ResourceActionsClient
@@ -9,6 +10,7 @@
 if TYPE_CHECKING:
     from .._client import Client
     from ..datacenters import BoundDatacenter, Datacenter
+    from ..locations import BoundLocation, Location
 
 
 class BoundPrimaryIP(BoundModelBase[PrimaryIP], PrimaryIP):
@@ -24,10 +26,15 @@ def __init__(
     ):
         # pylint: disable=import-outside-toplevel
         from ..datacenters import BoundDatacenter
+        from ..locations import BoundLocation
 
-        datacenter = data.get("datacenter", {})
-        if datacenter:
-            data["datacenter"] = BoundDatacenter(client._parent.datacenters, datacenter)
+        raw = data.get("datacenter", {})
+        if raw:
+            data["datacenter"] = BoundDatacenter(client._parent.datacenters, raw)
+
+        raw = data.get("location", {})
+        if raw:
+            data["location"] = BoundLocation(client._parent.locations, raw)
 
         super().__init__(client, data, complete)
 
@@ -309,6 +316,7 @@ def create(
         type: str,
         name: str,
         datacenter: Datacenter | BoundDatacenter | None = None,
+        location: Location | BoundLocation | None = None,
         assignee_type: str | None = "server",
         assignee_id: int | None = None,
         auto_delete: bool | None = False,
@@ -319,6 +327,7 @@ def create(
         :param type: str Primary IP type Choices: ipv4, ipv6
         :param name: str
         :param datacenter: Datacenter (optional)
+        :param location: Location (optional)
         :param assignee_type: str (optional)
         :param assignee_id: int (optional)
         :param auto_delete: bool (optional)
@@ -333,7 +342,16 @@ def create(
             "auto_delete": auto_delete,
         }
         if datacenter is not None:
+            warnings.warn(
+                "The 'datacenter' argument is deprecated and will be removed after 1 July 2026. "
+                "Please use the 'location' argument instead. "
+                "See https://docs.hetzner.cloud/changelog#2025-12-16-phasing-out-datacenters",
+                DeprecationWarning,
+                stacklevel=2,
+            )
             data["datacenter"] = datacenter.id_or_name
+        if location is not None:
+            data["location"] = location.id_or_name
         if assignee_id is not None:
             data["assignee_id"] = assignee_id
         if labels is not None:
diff --git a/hcloud/primary_ips/domain.py b/hcloud/primary_ips/domain.py
@@ -1,12 +1,14 @@
 from __future__ import annotations
 
+import warnings
 from typing import TYPE_CHECKING, TypedDict
 
 from ..core import BaseDomain, DomainIdentityMixin
 
 if TYPE_CHECKING:
     from ..actions import BoundAction
     from ..datacenters import BoundDatacenter
+    from ..locations import BoundLocation
     from ..rdns import DNSPtr
     from .client import BoundPrimaryIP
 
@@ -24,6 +26,8 @@ class PrimaryIP(BaseDomain, DomainIdentityMixin):
            Array of reverse DNS entries
     :param datacenter: :class:`Datacenter <hcloud.datacenters.client.BoundDatacenter>`
            Datacenter the Primary IP was created in.
+    :param location: :class:`Location <hcloud.locations.client.BoundLocation>`
+           Location the Primary IP was created in.
     :param blocked: boolean
            Whether the IP is blocked
     :param protection: dict
@@ -42,12 +46,11 @@ class PrimaryIP(BaseDomain, DomainIdentityMixin):
            Delete the Primary IP when the Assignee it is assigned to is deleted.
     """
 
-    __api_properties__ = (
+    __properties__ = (
         "id",
         "ip",
         "type",
         "dns_ptr",
-        "datacenter",
         "blocked",
         "protection",
         "labels",
@@ -57,7 +60,14 @@ class PrimaryIP(BaseDomain, DomainIdentityMixin):
         "assignee_type",
         "auto_delete",
     )
-    __slots__ = __api_properties__
+    __api_properties__ = (
+        *__properties__,
+        "datacenter",
+    )
+    __slots__ = (
+        *__properties__,
+        "_datacenter",
+    )
 
     def __init__(
         self,
@@ -66,6 +76,7 @@ def __init__(
         ip: str | None = None,
         dns_ptr: list[DNSPtr] | None = None,
         datacenter: BoundDatacenter | None = None,
+        location: BoundLocation | None = None,
         blocked: bool | None = None,
         protection: PrimaryIPProtection | None = None,
         labels: dict[str, str] | None = None,
@@ -80,6 +91,7 @@ def __init__(
         self.ip = ip
         self.dns_ptr = dns_ptr
         self.datacenter = datacenter
+        self.location = location
         self.blocked = blocked
         self.protection = protection
         self.labels = labels
@@ -89,6 +101,27 @@ def __init__(
         self.assignee_type = assignee_type
         self.auto_delete = auto_delete
 
+    @property
+    def datacenter(self) -> BoundDatacenter | None:
+        """
+        Datacenter the Primary IP was created in.
+
+        .. deprecated:: 2.13
+            See https://docs.hetzner.cloud/changelog#2025-12-16-phasing-out-datacenters
+        """
+        warnings.warn(
+            "The 'datacenter' property is deprecated and will be removed after 1 July 2026. "
+            "Please use the 'location' property instead. "
+            "",
+            DeprecationWarning,
+            stacklevel=2,
+        )
+        return self._datacenter
+
+    @datacenter.setter
+    def datacenter(self, value: BoundDatacenter | None) -> None:
+        self._datacenter = value
+
 
 class PrimaryIPProtection(TypedDict):
     delete: bool
diff --git a/hcloud/servers/client.py b/hcloud/servers/client.py
@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import warnings
 from datetime import datetime
 from typing import TYPE_CHECKING, Any, NamedTuple
 
@@ -12,6 +13,7 @@
 from ..floating_ips import BoundFloatingIP
 from ..images import BoundImage, CreateImageResponse
 from ..isos import BoundIso
+from ..locations import BoundLocation, Location
 from ..metrics import Metrics
 from ..placement_groups import BoundPlacementGroup
 from ..primary_ips import BoundPrimaryIP
@@ -39,7 +41,6 @@
     from ..firewalls import Firewall
     from ..images import Image
     from ..isos import Iso
-    from ..locations import BoundLocation, Location
     from ..networks import BoundNetwork, Network
     from ..placement_groups import PlacementGroup
     from ..server_types import ServerType
@@ -60,9 +61,13 @@ def __init__(
         data: dict[str, Any],
         complete: bool = True,
     ):
-        datacenter = data.get("datacenter")
-        if datacenter is not None:
-            data["datacenter"] = BoundDatacenter(client._parent.datacenters, datacenter)
+        raw = data.get("datacenter")
+        if raw:
+            data["datacenter"] = BoundDatacenter(client._parent.datacenters, raw)
+
+        raw = data.get("location")
+        if raw:
+            data["location"] = BoundLocation(client._parent.locations, raw)
 
         volumes = data.get("volumes", [])
         if volumes:
@@ -662,6 +667,13 @@ def create(
         if location is not None:
             data["location"] = location.id_or_name
         if datacenter is not None:
+            warnings.warn(
+                "The 'datacenter' argument is deprecated and will be removed after 1 July 2026. "
+                "Please use the 'location' argument instead. "
+                "See https://docs.hetzner.cloud/changelog#2025-12-16-phasing-out-datacenters",
+                DeprecationWarning,
+                stacklevel=2,
+            )
             data["datacenter"] = datacenter.id_or_name
         if ssh_keys is not None:
             data["ssh_keys"] = [ssh_key.id_or_name for ssh_key in ssh_keys]
diff --git a/hcloud/servers/domain.py b/hcloud/servers/domain.py
@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import warnings
 from typing import TYPE_CHECKING, Literal, TypedDict
 
 from ..core import BaseDomain, DomainIdentityMixin
@@ -11,6 +12,7 @@
     from ..floating_ips import BoundFloatingIP
     from ..images import BoundImage
     from ..isos import BoundIso
+    from ..locations import BoundLocation
     from ..metrics import Metrics
     from ..networks import BoundNetwork, Network
     from ..placement_groups import BoundPlacementGroup
@@ -36,6 +38,7 @@ class Server(BaseDomain, DomainIdentityMixin):
            Public network information.
     :param server_type: :class:`BoundServerType <hcloud.server_types.client.BoundServerType>`
     :param datacenter: :class:`BoundDatacenter <hcloud.datacenters.client.BoundDatacenter>`
+    :param location: :class:`BoundLocation <hcloud.locations.client.BoundLocation>`
     :param image: :class:`BoundImage <hcloud.images.client.BoundImage>`, None
     :param iso: :class:`BoundIso <hcloud.isos.client.BoundIso>`, None
     :param rescue_enabled: bool
@@ -81,13 +84,13 @@ class Server(BaseDomain, DomainIdentityMixin):
     STATUS_UNKNOWN = "unknown"
     """Server Status unknown"""
 
-    __api_properties__ = (
+    __properties__ = (
         "id",
         "name",
         "status",
         "public_net",
         "server_type",
-        "datacenter",
+        "location",
         "image",
         "iso",
         "rescue_enabled",
@@ -104,7 +107,14 @@ class Server(BaseDomain, DomainIdentityMixin):
         "primary_disk_size",
         "placement_group",
     )
-    __slots__ = __api_properties__
+    __api_properties__ = (
+        *__properties__,
+        "datacenter",
+    )
+    __slots__ = (
+        *__properties__,
+        "_datacenter",
+    )
 
     # pylint: disable=too-many-locals
     def __init__(
@@ -116,6 +126,7 @@ def __init__(
         public_net: PublicNetwork | None = None,
         server_type: BoundServerType | None = None,
         datacenter: BoundDatacenter | None = None,
+        location: BoundLocation | None = None,
         image: BoundImage | None = None,
         iso: BoundIso | None = None,
         rescue_enabled: bool | None = None,
@@ -138,6 +149,7 @@ def __init__(
         self.public_net = public_net
         self.server_type = server_type
         self.datacenter = datacenter
+        self.location = location
         self.image = image
         self.iso = iso
         self.rescue_enabled = rescue_enabled
@@ -163,6 +175,27 @@ def private_net_for(self, network: BoundNetwork | Network) -> PrivateNet | None:
                 return o
         return None
 
+    @property
+    def datacenter(self) -> BoundDatacenter | None:
+        """
+        Datacenter the Server was created in.
+
+        .. deprecated:: 2.13
+            See https://docs.hetzner.cloud/changelog#2025-12-16-phasing-out-datacenters
+        """
+        warnings.warn(
+            "The 'datacenter' property is deprecated and will be removed after 1 July 2026. "
+            "Please use the 'location' property instead. "
+            "See https://docs.hetzner.cloud/changelog#2025-12-16-phasing-out-datacenters",
+            DeprecationWarning,
+            stacklevel=2,
+        )
+        return self._datacenter
+
+    @datacenter.setter
+    def datacenter(self, value: BoundDatacenter | None) -> None:
+        self._datacenter = value
+
 
 class ServerProtection(TypedDict):
     rebuild: bool
