address review

Author: arihant2math

src/fs/fops.rs

@@ -138,10 +138,6 @@ pub trait FileOps: Send + Sync {
         Err(KernelError::InvalidValue)
     }
 
-    fn is_socket(&self) -> bool {
-        false
-    }
-
     fn as_socket(&mut self) -> Option<&mut dyn crate::socket::SocketOps> {
         None
     }

src/socket/mod.rs

@@ -4,6 +4,7 @@ mod tcp;
 mod unix;
 
 use crate::drivers::timer::now;
+use crate::memory::uaccess::copy_from_user;
 use crate::sync::OnceLock;
 use crate::sync::SpinLock;
 use alloc::vec;
@@ -22,14 +23,6 @@ fn sockets() -> &'static SpinLock<SocketSet<'static>> {
 }
 
 // static INTERFACE: OnceLock<SpinLock<EthernetInterface<OurDevice>>> = OnceLock::new();
-// static DHCP_CLIENT: OnceLock<SpinLock<Dhcpv4Client>> = OnceLock::new();
-
-static DHCP_ENABLED: OnceLock<bool> = OnceLock::new();
-
-#[expect(dead_code)]
-fn dhcp_enabled() -> bool {
-    *DHCP_ENABLED.get().unwrap()
-}
 
 static SOCKET_WAIT_QUEUE: OnceLock<SpinLock<WakerSet>> = OnceLock::new();
 
@@ -97,11 +90,7 @@ impl TryFrom<SockAddr> for IpEndpoint {
         match sockaddr {
             SockAddr::In(SockAddrIn { port, addr, .. }) => Ok(IpEndpoint {
                 port: u16::from_be_bytes(port),
-                addr: if u32::from_be_bytes(addr) == 0 {
-                    IpAddress::Ipv4(Ipv4Addr::UNSPECIFIED)
-                } else {
-                    IpAddress::Ipv4(Ipv4Addr::from(addr))
-                },
+                addr: IpAddress::Ipv4(Ipv4Addr::from(addr)),
             }),
             _ => Err(KernelError::InvalidValue),
         }
@@ -129,7 +118,7 @@ pub fn process_packets() {
     socket_wait_queue().lock_save_irq().wake_all();
 }
 
-pub fn parse_sockaddr(uaddr: UA, len: usize) -> Result<SockAddr, KernelError> {
+pub async fn parse_sockaddr(uaddr: UA, len: usize) -> Result<SockAddr, KernelError> {
     use crate::memory::uaccess::try_copy_from_user;
     use libkernel::memory::address::TUA;
 
@@ -138,7 +127,7 @@ pub fn parse_sockaddr(uaddr: UA, len: usize) -> Result<SockAddr, KernelError> {
         return Err(KernelError::InvalidValue);
     }
 
-    let family: u16 = try_copy_from_user(TUA::from_value(uaddr.value()))?;
+    let family: u16 = copy_from_user(TUA::from_value(uaddr.value())).await?;
 
     match family as i32 {
         AF_INET => {

src/socket/sops.rs

@@ -85,10 +85,6 @@ where
         Err(KernelError::NotSupported)
     }
 
-    fn is_socket(&self) -> bool {
-        true
-    }
-
     fn as_socket(&mut self) -> Option<&mut dyn SocketOps> {
         Some(self)
     }

src/socket/syscalls/bind.rs

@@ -10,7 +10,7 @@ pub async fn sys_bind(fd: Fd, addr: UA, addrlen: usize) -> libkernel::error::Res
         .ok_or(libkernel::error::KernelError::BadFd)?;
 
     let (ops, _ctx) = &mut *file.lock().await;
-    let addr = parse_sockaddr(addr, addrlen)?;
+    let addr = parse_sockaddr(addr, addrlen).await?;
 
     ops.as_socket()
         .ok_or(libkernel::error::KernelError::NotASocket)?

src/socket/syscalls/connect.rs

@@ -10,7 +10,7 @@ pub async fn sys_connect(fd: Fd, addr: UA, addrlen: usize) -> libkernel::error::
         .ok_or(libkernel::error::KernelError::BadFd)?;
 
     let (ops, _ctx) = &mut *file.lock().await;
-    let addr = parse_sockaddr(addr, addrlen)?;
+    let addr = parse_sockaddr(addr, addrlen).await?;
 
     ops.as_socket()
         .ok_or(libkernel::error::KernelError::NotASocket)?

src/socket/tcp.rs

@@ -58,7 +58,7 @@ impl TcpSocket {
             None => return Err(KernelError::InvalidValue),
         };
 
-        for _ in 0..(self.num_backlogs.load(Ordering::SeqCst) - backlogs.len()) {
+        for _ in 0..(self.num_backlogs.load(Ordering::Relaxed) - backlogs.len()) {
             let socket = TcpSocket::new();
             sockets()
                 .lock_save_irq()