Skip to content

Commit 64f1150

Browse files
committed
Remove option to use v3 artifact actions, remove checkout from build
1 parent e57e57b commit 64f1150

File tree

3 files changed

+4
-42
lines changed

3 files changed

+4
-42
lines changed

.github/workflows/hexdoc.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ on:
3131
description: Set the base site url instead of looking up the current repo's GitHub Pages url
3232
type: string
3333
required: false
34-
use-artifacts-v3:
35-
description: If true, use actions/upload-artifact@v3 instead of actions/upload-artifact@v4
36-
type: boolean
37-
default: false
3834
secrets:
3935
GH_TOKEN:
4036
required: true
@@ -69,7 +65,6 @@ jobs:
6965
props: ${{ inputs.props }}
7066
pip-extras: ${{ inputs.pip-extras }}
7167
subdirectory: ${{ inputs.subdirectory }}
72-
use-artifacts-v3: ${{ inputs.use-artifacts-v3 }}
7368
site-url: ${{ inputs.site-url }}
7469

7570
deploy-pages:
@@ -92,5 +87,4 @@ jobs:
9287
props: ${{ inputs.props }}
9388
pip-extras: ${{ inputs.pip-extras }}
9489
subdirectory: ${{ inputs.subdirectory }}
95-
use-artifacts-v3: ${{ inputs.use-artifacts-v3 }}
9690
site-url: ${{ needs.build.outputs.pages-url }}

build/action.yml

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@ inputs:
3030
description: Name of the Python build artifact to upload
3131
required: false
3232
default: hexdoc-build
33-
use-artifacts-v3:
34-
description: If true, use actions/upload-artifact@v3 instead of actions/upload-artifact@v4
35-
required: false
36-
default: "false"
3733

3834
outputs:
3935
pages-url:
@@ -46,7 +42,6 @@ outputs:
4642
runs:
4743
using: composite
4844
steps:
49-
- uses: actions/checkout@v3
5045
- uses: actions/setup-python@v4
5146
with:
5247
python-version: ${{ inputs.python-version }}
@@ -77,34 +72,18 @@ runs:
7772
shell: bash
7873
run: zip site.zip ./* -r
7974

80-
- name: Upload intermediate Pages artifact (v4)
81-
if: inputs.use-artifacts-v3 != 'true'
75+
- name: Upload intermediate Pages artifact
8276
uses: actions/upload-artifact@v4
8377
with:
8478
name: ${{ inputs.pages-artifact }}
8579
path: _site/src/docs/site.zip
8680

87-
- name: Upload package artifact (v4)
88-
if: inputs.use-artifacts-v3 != 'true'
81+
- name: Upload package artifact
8982
uses: actions/upload-artifact@v4
9083
with:
9184
name: ${{ inputs.build-artifact }}
9285
path: dist
9386

94-
- name: Upload intermediate Pages artifact (v3)
95-
if: inputs.use-artifacts-v3 == 'true'
96-
uses: actions/upload-artifact@v3
97-
with:
98-
name: ${{ inputs.pages-artifact }}
99-
path: _site/src/docs/site.zip
100-
101-
- name: Upload package artifact (v3)
102-
if: inputs.use-artifacts-v3 == 'true'
103-
uses: actions/upload-artifact@v3
104-
with:
105-
name: ${{ inputs.build-artifact }}
106-
path: dist
107-
10887
- name: Add job summary
10988
shell: bash
11089
run: echo "Built version \`$(hatch version)\` from commit \`$(git rev-parse --short "$GITHUB_SHA")\`." >> $GITHUB_STEP_SUMMARY

deploy-pages/action.yml

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@ inputs:
2626
description: Name of the GitHub Pages artifact to download
2727
required: false
2828
default: hexdoc-pages
29-
use-artifacts-v3:
30-
description: If true, use actions/download-artifact@v3 instead of actions/download-artifact@v4
31-
required: false
32-
default: "false"
3329
pages-branch:
3430
description: Name of the branch used for GitHub Pages
3531
required: false
@@ -48,26 +44,19 @@ runs:
4844
shell: bash
4945
run: uv pip install --system -e .${{ inputs.pip-extras }}
5046

51-
- name: Download Pages artifact (v4)
52-
if: inputs.use-artifacts-v3 != 'true'
47+
- name: Download Pages artifact
5348
uses: actions/download-artifact@v4
5449
with:
5550
name: ${{ inputs.pages-artifact }}
5651

57-
- name: Download Pages artifact (v3)
58-
if: inputs.use-artifacts-v3 == 'true'
59-
uses: actions/download-artifact@v3
60-
with:
61-
name: ${{ inputs.pages-artifact }}
62-
6352
- name: Unzip web book
6453
shell: bash
6554
run: |
6655
mkdir -p _site/src
6756
unzip site.zip -d _site/src/docs
6857
6958
- name: Checkout current Pages
70-
uses: actions/checkout@v3
59+
uses: actions/checkout@v4
7160
continue-on-error: true
7261
with:
7362
ref: ${{ inputs.pages-branch }}

0 commit comments

Comments
 (0)