Use Hex.State to store cached repo identifier

Author: sorentwo

lib/hex/state.ex

@@ -102,6 +102,10 @@ defmodule Hex.State do
       env: ["HEX_REPOS_KEY"],
       config: [:repos_key]
     },
+    repo_identifier: %{
+      env: ["HEX_REPO_IDENTIFIER"],
+      config: [:repo_identifier],
+    },
     diff_command: %{
       env: ["HEX_DIFF_COMMAND"],
       config: [:diff_command],

lib/hex/utils.ex

@@ -338,23 +338,23 @@ defmodule Hex.Utils do
   - The current directory isn't within a git repository
   """
   def repo_identifier do
-    case Process.get(:hex_repo_identifier) do
+    case Hex.State.get(:repo_identifier) do
       cached when is_binary(cached) ->
         cached
 
       nil ->
-        cmd_opts = ~w(rev-list --max-parents=0 HEAD)
+        cmd_args = ~w(rev-list --max-parents=0 HEAD)
 
         with false <- Hex.State.get(:no_repo_identifier),
              path when is_binary(path) <- System.find_executable("git"),
-             {output, 0} <- System.cmd("git", cmd_opts, stderr_to_stdout: true) do
+             {output, 0} <- System.cmd("git", cmd_args, stderr_to_stdout: true) do
           identifier =
             output
             |> String.trim()
             |> then(&:crypto.hash(:sha256, &1))
             |> Base.encode16(case: :lower)
 
-          Process.put(:hex_repo_identifier, identifier)
+          Hex.State.put(:repo_identifier, identifier)
 
           identifier
         else

test/hex/utils_test.exs

@@ -1,6 +1,12 @@
 defmodule Hex.UtilsTest do
   use ExUnit.Case
 
+  setup do
+    Hex.State.put(:repo_identifier, nil)
+
+    :ok
+  end
+
   describe "repo_identifier/0" do
     test "an identifier is included within a repository" do
       assert Hex.Utils.repo_identifier() =~ ~r/^[a-f0-9]{64}$/
@@ -37,7 +43,7 @@ defmodule Hex.UtilsTest do
     test "the identifier is cached within the current process" do
       value = "cached-identifier"
 
-      Process.put(:hex_repo_identifier, value)
+      Hex.State.put(:repo_identifier, value)
 
       assert value == Hex.Utils.repo_identifier()
     end