Validates that a hex package does not include a dpendncy that is in an umbrella.

Author: supersimple

lib/mix/tasks/hex.build.ex

@@ -303,7 +303,7 @@ defmodule Mix.Tasks.Hex.Build do
     end
   end
 
-  @scm_keys [:git, :github, :path]
+  @scm_keys [:git, :github, :path, :in_umbrella]
 
   defp package_dep?({_app, _req, opts}) do
     keys = Keyword.keys(opts)

test/mix/tasks/hex.build_test.exs

@@ -401,6 +401,26 @@ defmodule Mix.Tasks.Hex.BuildTest do
     purge([ReleaseIncludeReservedFile.MixProject])
   end
 
+  test "errors with umbrella deps" do
+    Process.put(:hex_test_app_name, :includes_umbrella_deps)
+    Mix.Project.push(ReleaseInUmbrellaDeps.MixProject)
+
+    in_tmp(fn ->
+      Hex.State.put(:cache_home, tmp_path())
+      
+      File.write!("myfile.txt", "hello")
+      File.chmod!("myfile.txt", 0o100644)
+
+      error_msg = "Stopping package build due to errors.\nDependencies excluded from the package (only Hex packages can be dependencies): ecto"
+
+      assert_raise Mix.Error, error_msg, fn ->
+        Mix.Tasks.Hex.Build.run([])
+      end
+    end)
+  after
+    purge([ReleaseInUmbrellaDeps.MixProject])
+  end
+
   test "build and unpack" do
     Process.put(:hex_test_app_name, :build_and_unpack)
     Mix.Project.push(Sample.MixProject)

test/support/case.ex

@@ -221,6 +221,7 @@ defmodule HexTest.Case do
       {:hexpm, :phoenix_live_reload, "1.0.3", [phoenix: "~> 0.16 or ~> 1.0"]},
       {:hexpm, :postgrex, "0.2.0", [ex_doc: "0.0.1"]},
       {:hexpm, :postgrex, "0.2.1", [ex_doc: "~> 0.1.0"]},
+      {:hexpm, :umb, "0.2.1", [ex_doc: "~> 0.1.0"]},
       {:repo2, :hexpm_deps, "0.1.0", [{:poison, ">= 0.0.0", false, :poison, :hexpm}]},
       {:repo2, :poison, "2.0.0", []},
       {:repo2, :repo2_deps, "0.1.0", [poison: ">= 0.0.0"]}

test/support/hexpm.ex

@@ -262,7 +262,7 @@ defmodule HexTest.Hexpm do
       |> Map.put_new(:app, name)
       |> Map.put_new(:build_tools, ["mix"])
       |> Map.put_new(:files, ["mix.exs"])
-
+      
     deps = inspect(deps, pretty: true)
     module = String.capitalize(name)
     mix_exs = :io_lib.format(@mix_exs_template, [module, name, version, deps])

test/support/release_samples.ex

@@ -354,3 +354,22 @@ defmodule ReleaseAppFalseDep.MixProject do
     ]
   end
 end
+
+defmodule ReleaseInUmbrellaDeps.MixProject do
+  def project do
+    [
+      app: Process.get(:hex_test_app_name) || raise("missing app name"),
+      description: "includes umbrella",
+      version: "0.2.1",
+      deps: [
+        {:ecto, "3.3.2", in_umbrella: true},
+        {:postgrex, "0.2.1"}
+      ],
+      package: [
+        licenses: ["MIT"],
+        files: ["myfile.txt"],
+        links: %{"a" => "http://a"}
+      ]
+    ]
+  end
+end