Differentiate repo verification errors

Author: ericmj

src/hex_registry.erl

@@ -55,7 +55,7 @@ decode_names(Payload, Repository) ->
         #{repository := Repository, packages := _Packages} = Result ->
             {ok, Result};
         _ ->
-            {error, unverified}
+            {error, bad_repo_name}
     end.
 
 %% @doc
@@ -84,7 +84,7 @@ decode_versions(Payload, Repository) ->
         #{repository := Repository, packages := _Packages} = Result ->
             {ok, Result};
         _ ->
-            {error, unverified}
+            {error, bad_repo_name}
     end.
 
 %% @doc
@@ -113,7 +113,7 @@ decode_package(Payload, Repository, Package) ->
         #{repository := Repository, name := Package, releases := _Releases} = Result ->
             {ok, Result};
         _ ->
-            {error, unverified}
+            {error, bad_repo_name}
     end.
 
 %% @private
@@ -131,7 +131,7 @@ decode_and_verify_signed(Signed, PublicKey) ->
     #{payload := Payload, signature := Signature} = decode_signed(Signed),
     case verify(Payload, Signature, PublicKey) of
         true -> {ok, Payload};
-        false -> {error, unverified};
+        false -> {error, bad_signature};
         {error, Reason} -> {error, Reason}
     end.
 

test/hex_registry_SUITE.erl

@@ -27,7 +27,7 @@ names_test(_Config) ->
     ?assertMatch({ok, Names}, hex_registry:unpack_names(Payload, <<"hexpm">>, TestPublicKey)),
     ?assertMatch({ok, Names}, hex_registry:unpack_names(Payload, no_verify, TestPublicKey)),
     ?assertMatch(
-        {error, unverified}, hex_registry:unpack_names(Payload, <<"other_repo">>, TestPublicKey)
+        {error, bad_repo_name}, hex_registry:unpack_names(Payload, <<"other_repo">>, TestPublicKey)
     ),
     ok.
 
@@ -54,7 +54,7 @@ versions_test(_Config) ->
     ?assertMatch({ok, Versions}, hex_registry:unpack_versions(Payload, <<"hexpm">>, TestPublicKey)),
     ?assertMatch({ok, Versions}, hex_registry:unpack_versions(Payload, no_verify, TestPublicKey)),
     ?assertMatch(
-        {error, unverified}, hex_registry:unpack_versions(Payload, <<"other_repo">>, TestPublicKey)
+        {error, bad_repo_name}, hex_registry:unpack_versions(Payload, <<"other_repo">>, TestPublicKey)
     ),
     ok.
 
@@ -102,11 +102,11 @@ package_test(_Config) ->
         {ok, Package}, hex_registry:unpack_package(Payload, no_verify, no_verify, TestPublicKey)
     ),
     ?assertMatch(
-        {error, unverified},
+        {error, bad_repo_name},
         hex_registry:unpack_package(Payload, <<"other_repo">>, <<"foobar">>, TestPublicKey)
     ),
     ?assertMatch(
-        {error, unverified},
+        {error, bad_repo_name},
         hex_registry:unpack_package(Payload, <<"hexpm">>, <<"other_package">>, TestPublicKey)
     ),
     ok.
@@ -126,6 +126,6 @@ signed_test(_Config) ->
 
     {error, bad_key} = hex_registry:decode_and_verify_signed(Signed, <<"bad">>),
 
-    {error, unverified} = hex_registry:decode_and_verify_signed(Signed, HexpmPublicKey),
+    {error, bad_signature} = hex_registry:decode_and_verify_signed(Signed, HexpmPublicKey),
 
     ok.