HTTP cleanup

Author: ericmj

lib/hexdocs/http.ex

@@ -8,8 +8,8 @@ defmodule Hexdocs.HTTP do
     :hackney.head(url, headers)
   end
 
-  def get(url, headers) do
-    :hackney.get(url, headers)
+  def get(url, headers, opts \\ []) do
+    :hackney.get(url, headers, "", opts)
     |> read_response()
   end
 
@@ -24,12 +24,8 @@ defmodule Hexdocs.HTTP do
   end
 
   def post(url, headers, body, opts \\ []) do
-    if :with_body in opts do
-      :hackney.post(url, headers, body, opts)
-    else
-      :hackney.post(url, headers, body, opts)
-      |> read_response()
-    end
+    :hackney.post(url, headers, body, opts)
+    |> read_response()
   end
 
   def delete(url, headers, opts \\ []) do

lib/hexdocs/search/typesense.ex

@@ -29,7 +29,7 @@ defmodule Hexdocs.Search.Typesense do
     url = url("collections/#{collection()}/documents/import?action=create")
     headers = [{"x-typesense-api-key", api_key()}]
 
-    case HTTP.post(url, headers, ndjson, [:with_body, recv_timeout: @timeout]) do
+    case HTTP.post(url, headers, ndjson, recv_timeout: @timeout) do
       {:ok, 200, _resp_headers, ndjson} ->
         ndjson
         |> String.split("\n")

lib/hexdocs/source_repo/github.ex

@@ -9,16 +9,15 @@ defmodule Hexdocs.SourceRepo.GitHub do
     url = @github_url <> "/repos/#{repo}/tags"
 
     headers = [
-      accept: "application/json"
+      {"accept", "application/json"}
     ]
 
     options = [
-      :with_body,
       basic_auth: {user, token}
     ]
 
     Hexdocs.HTTP.retry("github", url, fn ->
-      :hackney.get(url, headers, "", options)
+      Hexdocs.HTTP.get(url, headers, options)
     end)
     |> case do
       {:ok, 200, _headers, body} ->