Add repository check for direct hexdocs:search messages

Author: ericmj

lib/hexdocs/queue.ex

@@ -111,7 +111,7 @@ defmodule Hexdocs.Queue do
             process_upload(key, repository, package, version, body, start)
 
           :search ->
-            process_search(key, package, version, body, start)
+            process_search(key, repository, package, version, body, start)
         end
 
       :error ->
@@ -166,21 +166,25 @@ defmodule Hexdocs.Queue do
     end
   end
 
-  defp process_search(key, package, version, body, start) do
-    version =
-      case Version.parse(version) do
-        {:ok, version} -> version
-        :error when package in @special_package_names -> version
-      end
+  defp process_search(key, repository, package, version, body, start) do
+    if repository != "hexpm" do
+      Logger.warning("SKIPPING SEARCH INDEX #{key} (repository is not hexpm)")
+    else
+      version =
+        case Version.parse(version) do
+          {:ok, version} -> version
+          :error when package in @special_package_names -> version
+        end
 
-    case Hexdocs.Tar.unpack(body, package: package, version: version) do
-      {:ok, files} ->
-        update_search_index(key, package, version, files)
-        elapsed = System.os_time(:millisecond) - start
-        Logger.info("FINISHED INDEXING DOCS #{key} #{elapsed}ms")
+      case Hexdocs.Tar.unpack(body, package: package, version: version) do
+        {:ok, files} ->
+          update_search_index(key, package, version, files)
+          elapsed = System.os_time(:millisecond) - start
+          Logger.info("FINISHED INDEXING DOCS #{key} #{elapsed}ms")
 
-      {:error, reason} ->
-        Logger.error("Failed unpack #{package} #{version}: #{reason}")
+        {:error, reason} ->
+          Logger.error("Failed unpack #{package} #{version}: #{reason}")
+      end
     end
   end
 

test/hexdocs/queue_test.exs

@@ -417,6 +417,25 @@ defmodule Hexdocs.QueueTest do
       ref = Broadway.test_message(Hexdocs.Queue, search_message("invalid/key/#{test}"))
       assert_receive {:ack, ^ref, [_], []}
     end
+
+    @tag :capture_log
+    test "does not index private packages", %{test: test} do
+      key = "repos/private_org/docs/#{test}-1.0.0.tar.gz"
+
+      tar =
+        Hexdocs.Tar.create([
+          {"index.html", "contents"},
+          {"dist/search_data-ABC123.js",
+           """
+           searchData={"items":[{"type":"module","title":"Example","doc":"example text","ref":"Example.html"}]}
+           """}
+        ])
+
+      Store.put!(:repo_bucket, key, tar)
+
+      ref = Broadway.test_message(Hexdocs.Queue, search_message(key))
+      assert_receive {:ack, ^ref, [_], []}
+    end
   end
 
   describe "delete object" do