fix(client): handle empty response bodies for various content types

Author: volesen

packages/openapi-ts/src/plugins/@hey-api/client-fetch/bundle/client.ts

@@ -106,23 +106,41 @@ export const createClient = (config: Config = {}): Client => {
     };
 
     if (response.ok) {
+      const parseAs =
+        (opts.parseAs === 'auto'
+          ? getParseAs(response.headers.get('Content-Type'))
+          : opts.parseAs) ?? 'json';
+
       if (
         response.status === 204 ||
         response.headers.get('Content-Length') === '0'
       ) {
+        let emptyData: any;
+        switch (parseAs) {
+          case 'arrayBuffer':
+          case 'blob':
+          case 'text':
+            emptyData = await response[parseAs]();
+            break;
+          case 'formData':
+            emptyData = new FormData();
+            break;
+          case 'stream':
+            emptyData = response.body;
+            break;
+          case 'json':
+          default:
+            emptyData = {};
+            break;
+        }
         return opts.responseStyle === 'data'
-          ? {}
+          ? emptyData
           : {
-              data: {},
+              data: emptyData,
               ...result,
             };
       }
 
-      const parseAs =
-        (opts.parseAs === 'auto'
-          ? getParseAs(response.headers.get('Content-Type'))
-          : opts.parseAs) ?? 'json';
-
       let data: any;
       switch (parseAs) {
         case 'arrayBuffer':

packages/openapi-ts/src/plugins/@hey-api/client-next/bundle/client.ts

@@ -101,21 +101,39 @@ export const createClient = (config: Config = {}): Client => {
     };
 
     if (response.ok) {
+      const parseAs =
+        (opts.parseAs === 'auto'
+          ? getParseAs(response.headers.get('Content-Type'))
+          : opts.parseAs) ?? 'json';
+
       if (
         response.status === 204 ||
         response.headers.get('Content-Length') === '0'
       ) {
+        let emptyData: any;
+        switch (parseAs) {
+          case 'arrayBuffer':
+          case 'blob':
+          case 'text':
+            emptyData = await response[parseAs]();
+            break;
+          case 'formData':
+            emptyData = new FormData();
+            break;
+          case 'stream':
+            emptyData = response.body;
+            break;
+          case 'json':
+          default:
+            emptyData = {};
+            break;
+        }
         return {
-          data: {},
+          data: emptyData,
           ...result,
         };
       }
 
-      const parseAs =
-        (opts.parseAs === 'auto'
-          ? getParseAs(response.headers.get('Content-Type'))
-          : opts.parseAs) ?? 'json';
-
       let data: any;
       switch (parseAs) {
         case 'arrayBuffer':