Merge pull request #1594 from hey-api/fix/text-plain-serializer

fix: generate correct response for text/plain content type

Author: mrlubos

.changeset/green-dancers-pull.md

@@ -0,0 +1,5 @@
+---
+'@hey-api/openapi-ts': patch
+---
+
+fix: generate correct response for text/plain content type

packages/openapi-ts/src/ir/__tests__/mediaType.test.ts

@@ -52,7 +52,7 @@ describe('isMediaTypeFileLike', () => {
       mediaType: 'text/javascript; charset=ISO-8859-1',
     },
     {
-      fileLike: true,
+      fileLike: false,
       mediaType: 'text/plain; charset=utf-8',
     },
     {

packages/openapi-ts/src/ir/mediaType.ts

@@ -1,5 +1,5 @@
 const fileLikeRegExp =
-  /^(application\/(pdf|rtf|msword|vnd\.(ms-|openxmlformats-officedocument\.)|zip|x-(7z|tar|rar|zip|iso)|octet-stream|gzip|x-msdownload|json\+download|xml|x-yaml|x-7z-compressed|x-tar)|text\/(plain|yaml|css|javascript)|audio\/(mpeg|wav)|video\/(mp4|x-matroska)|image\/(vnd\.adobe\.photoshop|svg\+xml))(; ?charset=[^;]+)?$/i;
+  /^(application\/(pdf|rtf|msword|vnd\.(ms-|openxmlformats-officedocument\.)|zip|x-(7z|tar|rar|zip|iso)|octet-stream|gzip|x-msdownload|json\+download|xml|x-yaml|x-7z-compressed|x-tar)|text\/(yaml|css|javascript)|audio\/(mpeg|wav)|video\/(mp4|x-matroska)|image\/(vnd\.adobe\.photoshop|svg\+xml))(; ?charset=[^;]+)?$/i;
 const jsonMimeRegExp = /^application\/(.*\+)?json(;.*)?$/i;
 const multipartFormDataMimeRegExp = /^multipart\/form-data(;.*)?$/i;
 const xWwwFormUrlEncodedMimeRegExp =

packages/openapi-ts/test/2.0.x.test.ts

@@ -34,6 +34,13 @@ describe(`OpenAPI ${version}`, () => {
   });
 
   const scenarios = [
+    {
+      config: createConfig({
+        input: 'body-response-text-plain.yaml',
+        output: 'body-response-text-plain',
+      }),
+      description: 'handle text/plain content type',
+    },
     {
       config: createConfig({
         input: 'enum-names-values.json',

packages/openapi-ts/test/3.0.x.test.ts

@@ -63,6 +63,13 @@ describe(`OpenAPI ${version}`, () => {
       description:
         'generates correct array when items are oneOf array with single item',
     },
+    {
+      config: createConfig({
+        input: 'body-response-text-plain.yaml',
+        output: 'body-response-text-plain',
+      }),
+      description: 'handle text/plain content type',
+    },
     {
       config: createConfig({
         input: 'case.json',

packages/openapi-ts/test/3.1.x.test.ts

@@ -63,6 +63,13 @@ describe(`OpenAPI ${version}`, () => {
       description:
         'generates correct array when items are oneOf array with single item',
     },
+    {
+      config: createConfig({
+        input: 'body-response-text-plain.yaml',
+        output: 'body-response-text-plain',
+      }),
+      description: 'handle text/plain content type',
+    },
     {
       config: createConfig({
         input: 'case.json',

packages/openapi-ts/test/__snapshots__/2.0.x/body-response-text-plain/index.ts

@@ -0,0 +1,2 @@
+// This file is auto-generated by @hey-api/openapi-ts
+export * from './types.gen';

packages/openapi-ts/test/__snapshots__/2.0.x/body-response-text-plain/types.gen.ts

@@ -0,0 +1,17 @@
+// This file is auto-generated by @hey-api/openapi-ts
+
+export type PostFooData = {
+    body: string;
+    path?: never;
+    query?: never;
+    url: '/foo';
+};
+
+export type PostFooResponses = {
+    /**
+     * OK
+     */
+    200: string;
+};
+
+export type PostFooResponse = PostFooResponses[keyof PostFooResponses];

packages/openapi-ts/test/__snapshots__/3.0.x/body-response-text-plain/index.ts

@@ -0,0 +1,2 @@
+// This file is auto-generated by @hey-api/openapi-ts
+export * from './types.gen';

packages/openapi-ts/test/__snapshots__/3.0.x/body-response-text-plain/types.gen.ts

@@ -0,0 +1,17 @@
+// This file is auto-generated by @hey-api/openapi-ts
+
+export type PostFooData = {
+    body: string;
+    path?: never;
+    query?: never;
+    url: '/foo';
+};
+
+export type PostFooResponses = {
+    /**
+     * OK
+     */
+    200: string;
+};
+
+export type PostFooResponse = PostFooResponses[keyof PostFooResponses];